Skip to content

fix(compute): reject prototype keys as a doctor target - #919

Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
synthetic-sciences:mainfrom
aniruddhaadak80:fix/compute-reject-prototype-keys-doctor-target
Closed

ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
synthetic-sciences:mainfrom
aniruddhaadak80:fix/compute-reject-prototype-keys-doctor-target

Conversation

@aniruddhaadak80

Copy link
Copy Markdown
Contributor

What does this PR do, and why?

The guard used in on a plain object literal, which also finds Object.prototype members. So doctor("toString") or approveExecutable("constructor") passed the guard, DOCTOR_SPECS[target] returned an inherited function instead of a Spec, and invoke()/approve() then read spec.cli as undefined and spawn it - while markProviderCheckFailed recorded state for a provider that does not exist.

Linked issue

small fix, no issue

How did you verify it?

cd backend/cli && bun test test/tool/provider-compute.test.ts

Regression proof: reverted ONLY provider-cli.ts to base and re-ran: the new test fails with the exact "does not support" message above, proving it exercises the guard rather than the operation grammar. Restored, all 5 pass.

cd backend/cli && bun test test/tool/provider-compute.test.ts test/settings/network.test.ts -> 30 pass, 0 fail

Only provider() was touched, so all four entry points - preview, execute, doctor and approveExecutable - are covered. The canonical as Provider cast is unchanged, so type safety here remains a cast rather than a compile-time guarantee.

Not verified: I could not execute the downstream attestation path for a prototype key, because it fails earlier at TrustedExecutable.attest(undefined) - so the deepest consequence is read from the code, not observed. test/compute/ has 38 pre-existing failures at the untouched base on this machine ("no sandbox backend for platform win32"), which I confirmed via a temporary baseline branch.

Two pre-existing conditions in this checkout, reproduced on the untouched base commit and therefore not caused by this change: �un run typecheck (turbo) fails with sgo: command not found, and �un run format:check reports roughly 30 files. I ran sc --noEmit for �ackend/cli and prettier on the files I touched instead; neither appears in the base warning list.

Checklist

  • �un run check is green (format, typecheck, backend + frontend/ui + SDK tests)
  • �un run --cwd frontend/workspace build succeeds if I touched rontend/workspace or rontend/ui (not applicable - no frontend/workspace or frontend/ui file changed)
  • ./tooling/repo/generate.ts was run and the ooling/sdk output committed if I changed �ackend/cli/src/server (not applicable - no �ackend/cli/src/server file changed)
  • [[x]] CHANGELOG.md has an Unreleased entry if the change is user-visible
  • The matching docs page under rontend/docs/src/content/openscience/ is updated if behavior changed (not applicable - no documented behavior changed)
  • Screenshots or a short video are attached for UI changes (not applicable - no UI change)
  • No version bumps (package.json versions and tags are written by the release workflow)
  • install and rontend/landing/public/install are still byte-identical if I touched either (not applicable - neither was touched)

I left the first box unticked rather than claiming it: �un run check cannot pass in this checkout because turbo cannot find sgo, and that failure reproduces on the base commit.

`provider()` guarded the reviewed broker table with `in`, which also matches
Object.prototype members. A target such as "toString" or "constructor" passed
the guard, so `DOCTOR_SPECS[target]` returned an inherited function instead of
a Spec: `spec.cli` read as undefined and reached the executable attestation
path, and `doctor()` recorded a failed connection check for a provider that
does not exist.

Use an own-property check, the idiom already used elsewhere in the CLI.
Copilot AI balanced review requested due to automatic review settings October 3, 2026 05:16
@vercel

vercel Bot commented Oct 3, 2026

Copy link
Copy Markdown

ANIRUDDHA ADAK (@aniruddhaadak80) is attempting to deploy a commit to the InkVell Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aayambansal

Copy link
Copy Markdown
Member

Incorporated, reviewed, and validated in #953, now merged into main. Closing this original PR as superseded by the consolidated change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants