Skip to content

fix(acp): tolerate a non-JSON todowrite output - #923

Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
synthetic-sciences:mainfrom
aniruddhaadak80:fix/acp-todowrite-non-json-live
Closed

ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
synthetic-sciences:mainfrom
aniruddhaadak80:fix/acp-todowrite-non-json-live

Conversation

@aniruddhaadak80

Copy link
Copy Markdown
Contributor

What does this PR do, and why?

handleEvent parses a completed todowrite output with an unguarded JSON.parse. A non-JSON output throws INSIDE the handler, before the later tool_call_update is enqueued, and runEventSubscription's .catch only logs.

Linked issue

small fix, no issue

How did you verify it?

cd backend/cli && bun test test/acp/event-subscription.test.ts -t "not valid JSON"

Regression proof: With the original source restored and the new test kept, the test fails; restoring the fix makes it pass. Verified both directions.

cd backend/cli && bun test test/acp/event-subscription.test.ts -> 7 pass, 0 fail

A shared parseTodoOutput helper logs two distinct messages (JSON syntax vs schema mismatch), preserving the prior diagnostics. A schema-valid but wrong-shaped array still yields no plan update, same as before.

Not verified: no live ACP client exercised. test/acp/protocol.test.ts has a pre-existing 5s-timeout failure at base.

Two pre-existing conditions in this checkout, reproduced on the untouched base commit and therefore not caused by this change: �un run typecheck (turbo) fails with sgo: command not found, and �un run format:check reports roughly 30 files. I ran sc --noEmit for �ackend/cli and prettier on the files I touched instead; neither appears in the base warning list.

Checklist

  • �un run check is green (format, typecheck, backend + frontend/ui + SDK tests)
  • �un run --cwd frontend/workspace build succeeds if I touched rontend/workspace or rontend/ui (not applicable - no frontend/workspace or frontend/ui file changed)
  • ./tooling/repo/generate.ts was run and the ooling/sdk output committed if I changed �ackend/cli/src/server (not applicable - no �ackend/cli/src/server file changed)
  • [[x]] CHANGELOG.md has an Unreleased entry if the change is user-visible
  • The matching docs page under rontend/docs/src/content/openscience/ is updated if behavior changed (not applicable - no documented behavior changed)
  • Screenshots or a short video are attached for UI changes (not applicable - no UI change)
  • No version bumps (package.json versions and tags are written by the release workflow)
  • install and rontend/landing/public/install are still byte-identical if I touched either (not applicable - neither was touched)

I left the first box unticked rather than claiming it: �un run check cannot pass in this checkout because turbo cannot find sgo, and that failure reproduces on the base commit.

A todowrite tool whose output is not JSON threw from the unguarded JSON.parse inside handleEvent, before the tool_call_update was enqueued. runEventSubscription only logs that error, so the ACP client never received the completed update and the call stayed running forever.

Parse the output through a helper that returns undefined instead of throwing, keeping both diagnostics: a JSON syntax error and a schema mismatch are logged separately.
Copilot AI balanced review requested due to automatic review settings October 3, 2026 07:26
@vercel

vercel Bot commented Oct 3, 2026

Copy link
Copy Markdown

ANIRUDDHA ADAK (@aniruddhaadak80) is attempting to deploy a commit to the InkVell Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aayambansal

Copy link
Copy Markdown
Member

Incorporated, reviewed, and validated in #953, now merged into main. Closing this original PR as superseded by the consolidated change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants