Repository navigation
fix(acp): tolerate a non-JSON todowrite output - #923
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Conversation
A todowrite tool whose output is not JSON threw from the unguarded JSON.parse inside handleEvent, before the tool_call_update was enqueued. runEventSubscription only logs that error, so the ACP client never received the completed update and the call stayed running forever. Parse the output through a helper that returns undefined instead of throwing, keeping both diagnostics: a JSON syntax error and a schema mismatch are logged separately.
ANIRUDDHA ADAK (aniruddhaadak80)
requested review from
Aayam Bansal (aayambansal) and
Ishaan Gangwani (ishaan1124)
as code owners
October 3, 2026 07:26
|
ANIRUDDHA ADAK (@aniruddhaadak80) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Incorporated, reviewed, and validated in #953, now merged into main. Closing this original PR as superseded by the consolidated change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
handleEventparses a completedtodowriteoutput with an unguardedJSON.parse. A non-JSON output throws INSIDE the handler, before the latertool_call_updateis enqueued, andrunEventSubscription's.catchonly logs.Linked issue
small fix, no issue
How did you verify it?
cd backend/cli && bun test test/acp/event-subscription.test.ts -t "not valid JSON"Regression proof: With the original source restored and the new test kept, the test fails; restoring the fix makes it pass. Verified both directions.
cd backend/cli && bun test test/acp/event-subscription.test.ts -> 7 pass, 0 failA shared
parseTodoOutputhelper logs two distinct messages (JSON syntax vs schema mismatch), preserving the prior diagnostics. A schema-valid but wrong-shaped array still yields no plan update, same as before.Not verified: no live ACP client exercised.
test/acp/protocol.test.tshas a pre-existing 5s-timeout failure at base.Two pre-existing conditions in this checkout, reproduced on the untouched base commit and therefore not caused by this change: �un run typecheck (turbo) fails with sgo: command not found, and �un run format:check reports roughly 30 files. I ran sc --noEmit for �ackend/cli and prettier on the files I touched instead; neither appears in the base warning list.
Checklist
I left the first box unticked rather than claiming it: �un run check cannot pass in this checkout because turbo cannot find sgo, and that failure reproduces on the base commit.