Repository navigation
fix(acp): do not fail a session load on one bad tool output - #924
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Conversation
The session-replay path parsed todowrite output with the same unguarded JSON.parse. loadSession and unstable_forkSession await processMessage inside their own try, so a single todowrite tool with non-JSON output threw a SyntaxError back to the ACP client and the whole session failed to load instead of replaying its history. Route the replay site through the same non-throwing helper. Both call sites would share one helper once either PR merges; they are kept apart here so each change stands on its own.
ANIRUDDHA ADAK (aniruddhaadak80)
requested review from
Aayam Bansal (aayambansal) and
Ishaan Gangwani (ishaan1124)
as code owners
October 3, 2026 07:27
|
ANIRUDDHA ADAK (@aniruddhaadak80) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Incorporated, reviewed, and validated in #953, now merged into main. Closing this original PR as superseded by the consolidated change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
The session-replay path shared the same unguarded
JSON.parse.loadSessionandunstable_forkSessioncallawait this.processMessage(msg)inside their owntry, so ONEtodowriteentry with non-JSON output throws aSyntaxErrorback to the client and the entire session load fails.Linked issue
small fix, no issue
How did you verify it?
cd backend/cli && bun test test/acp/event-subscription.test.ts -t "replays a session"Regression proof: With the source reverted the test fails on that SyntaxError; with the fix it passes. The diff hunk is confined to the replay site, leaving the live path untouched.
cd backend/cli && bun test test/acp/event-subscription.test.ts -> 7 pass, 0 failThis PR adds a
parseTodoOutputhelper identical to the one in the companion live-path PR, so each stands alone as an independently reviewable and mergeable change. Once one merges, the other should drop its duplicate helper - noted in the commit body.Not verified:
unstable_forkSessionis not directly tested (it shares theprocessMessagepath).Two pre-existing conditions in this checkout, reproduced on the untouched base commit and therefore not caused by this change: �un run typecheck (turbo) fails with sgo: command not found, and �un run format:check reports roughly 30 files. I ran sc --noEmit for �ackend/cli and prettier on the files I touched instead; neither appears in the base warning list.
Checklist
I left the first box unticked rather than claiming it: �un run check cannot pass in this checkout because turbo cannot find sgo, and that failure reproduces on the base commit.