Repository navigation
fix(acp): do not leave the write-text-file promise unhandled - #925
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Conversation
connection.writeTextFile was the only connection call in the file whose returned promise was neither awaited nor caught. A rejection, such as a path outside the client's roots or a closed connection, became an unhandled rejection, which under Bun's default policy terminates the ACP server process. Catch it and log, matching every other connection call. It stays un-awaited so a slow client cannot delay the permission reply that follows.
ANIRUDDHA ADAK (aniruddhaadak80)
requested review from
Aayam Bansal (aayambansal) and
Ishaan Gangwani (ishaan1124)
as code owners
October 3, 2026 07:27
|
ANIRUDDHA ADAK (@aniruddhaadak80) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Incorporated, reviewed, and validated in #953, now merged into main. Closing this original PR as superseded by the consolidated change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
connection.writeTextFile(...)was the onlyconnection.*call in the file whose returned promise was neither awaited nor.catch-ed.Linked issue
small fix, no issue
How did you verify it?
cd backend/cli && bun test test/acp/event-subscription.test.ts -t "rejected edit preview"Regression proof: The same test fails on the reverted source with the rejection escaping, and passes with the fix. The existing oversized-preview test still passes, so the success path is unchanged.
cd backend/cli && bun test test/acp/event-subscription.test.ts -> 7 pass, 0 failDeliberately left un-awaited so a slow client cannot delay the permission reply that follows; awaiting would change ordering behaviour beyond the bug. The error is logged rather than propagated, matching the sibling calls.
Not verified: only the rejection path is asserted; no test covers a mid-flight connection close.
Two pre-existing conditions in this checkout, reproduced on the untouched base commit and therefore not caused by this change: �un run typecheck (turbo) fails with sgo: command not found, and �un run format:check reports roughly 30 files. I ran sc --noEmit for �ackend/cli and prettier on the files I touched instead; neither appears in the base warning list.
Checklist
I left the first box unticked rather than claiming it: �un run check cannot pass in this checkout because turbo cannot find sgo, and that failure reproduces on the base commit.