Repository navigation
fix(science): read a requirement line that carries no == pin - #928
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 3 commits into
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 3 commits into
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 3 commits into
Conversation
requirementArtifacts assumed every non-comment line carries an == pin.
TaskSpec validates pip_requirements only as a non-empty string, so a range
("requests>=2.31"), a bare name, or a direct URL reached the parser.
indexOf("==") returned -1 for those and name and version were sliced at
the wrong offsets, yielding artifacts such as name "requests>=2.3" and
version "equests>=2.31".
verifiedWheels compares the parsed entries against the pinned packages and
the downloaded wheel filenames, so a corrupted entry mis-counted the pins
and either accepted a wrong wheel or failed with "Downloaded wheels do not
exactly cover the hashed task requirements".
Drop an entry that carries no == pin rather than fabricate a name and a
version from it. This complements the existing skip for comments and blank
lines; an environment marker after a real pin is still read as that pin.
ANIRUDDHA ADAK (aniruddhaadak80)
requested review from
Aayam Bansal (aayambansal) and
Ishaan Gangwani (ishaan1124)
as code owners
October 3, 2026 07:27
|
ANIRUDDHA ADAK (@aniruddhaadak80) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Incorporated, reviewed, and validated in #953, now merged into main. Closing this original PR as superseded by the consolidated change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
requirementArtifactsassumes every non-comment line carries an==pin. When it does not,indexOf("==")returns -1 andname/versionare carved out of the wrong offsets - sopip_requirements: "requests>=2.31\n"yields namerequests>=2.3, versionequests>=2.31.Linked issue
small fix, no issue
How did you verify it?
cd backend/cli && bun test test/science/kernel/requirement-artifacts.test.tsRegression proof: Reverting the source reproduces 4 pass 2 fail; restoring gives 6 pass 0 fail.
cd backend/cli && bun test test/science/kernel/requirement-artifacts.test.ts -> 6 pass 0 fail. The 4 pre-existing tests still pass, including the merged #813 comment/blank-line case, so this complements rather than duplicates it.Environment markers after a real pin (
numpy==1.26.4 ; python_version >= "3.10") are still read correctly, pinned by a test. A spec whose entries are all valid==pins still fails closed throughverifiedWheelswith the exact coverage error unchanged.Not verified: end-to-end wheel verification needs conda plus network, unavailable here.
environment-manager.test.tshas 10 pre-existing failures on this box (R/micromamba absent), verified identical at base.Two pre-existing conditions in this checkout, reproduced on the untouched base commit and therefore not caused by this change: �un run typecheck (turbo) fails with sgo: command not found, and �un run format:check reports roughly 30 files. I ran sc --noEmit for �ackend/cli and prettier on the files I touched instead; neither appears in the base warning list.
Checklist
I left the first box unticked rather than claiming it: �un run check cannot pass in this checkout because turbo cannot find sgo, and that failure reproduces on the base commit.