Repository navigation
fix(provider): use the renamed web-search tool in the stream handler - #944
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Closed
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Conversation
getArgs resolves webSearchToolName from the tool the caller registered, and output_item.added, doGenerate, and the ongoingToolCalls entry all report webSearchToolName ?? "web_search". The output_item.done handler hardcoded "web_search" instead. A caller that registered the provider-defined tool under its own name therefore saw tool-input-start emitted under that name and tool-call/tool-result emitted under the default, so the emitted call could not be routed to the registered tool, and the streaming path disagreed with the non-streaming one. Resolve the name the same way at both sites.
ANIRUDDHA ADAK (aniruddhaadak80)
requested review from
Aayam Bansal (aayambansal) and
Ishaan Gangwani (ishaan1124)
as code owners
October 3, 2026 10:00
|
ANIRUDDHA ADAK (@aniruddhaadak80) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Incorporated, reviewed, and validated in #953, now merged into main. Closing this original PR as superseded by the consolidated change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
The
response.output_item.donehandler HARDCODED"web_search"while theoutput_item.addedhandler,doGenerate, and theongoingToolCallsentry all resolve the registered name viawebSearchToolName ?? "web_search".Linked issue
small fix, no issue
How did you verify it?
cd backend/cli && bun test test/provider/openai-responses-web-search-name.test.tsRegression proof:
a renamed tool keeps one name across input-start and tool-callregisters the tool asdocs_searchand asserts both events carry it. Fails before, passes after.2 pass / 0 fail; with test/provider/xai-responses-usage.test.ts -> 3 pass / 0 failA second test covers default-name behaviour so the change cannot silently alter the common path. Canned SSE replay, nothing stubbed - the same style as the existing xAI test. All six
toolNamesites now read identically (verified by grep).Not verified: HONEST SCOPE NOTE: no in-repo caller renames the tool today - a grep for
provider-definedacross src finds only the model itself. This is a LATENT divergence in a path the surrounding?? "web_search"fallbacks explicitly exist to support, not a live user-facing break. The SDK tolerated the mismatched name without raising in this test, so the harm is an unroutable tool-call name rather than a thrown failure; I did not confirm how the agent loop reacts to one.Two pre-existing conditions in this checkout, reproduced on the untouched base commit and therefore not caused by this change: �un run typecheck (turbo) fails with sgo: command not found, and �un run format:check reports roughly 30 files. I ran sc --noEmit for �ackend/cli and prettier on the files I touched instead; neither appears in the base warning list.
Checklist
I left the first box unticked rather than claiming it: �un run check cannot pass in this checkout because turbo cannot find sgo, and that failure reproduces on the base commit.