Repository navigation
TestBuilder.BuildTestsStreamingAsync is unused and duplicates the row-building loop #7327
Description
Summary
TestBuilder.BuildTestsStreamingAsync (src/TUnit.Engine/Building/TestBuilder.cs, declared on ITestBuilder) has no callers besides its own recursion for generic instantiations. Discovery and execution use BuildTestsFromMetadataAsync. The streaming copy duplicates the class/method row loop. Every fix to that loop, such as #7157 and #7205, has to be mirrored there without test coverage.
Where
src/TUnit.Engine/Building/Interfaces/ITestBuilder.cs:BuildTestsStreamingAsyncsrc/TUnit.Engine/Building/TestBuilder.cs:BuildTestsStreamingAsync,BuildSingleTestAsync
grep -rn BuildTestsStreamingAsync src tests finds only the interface, the implementation, and its recursive call.
Expected
Remove the unused streaming path (and BuildSingleTestAsync). If it is meant to be used, wire it up and cover it with tests.
Activity
thomhurst commentedon Nov 2, 2026
Still valid on origin/main d8badac:
BuildTestsStreamingAsynchas only its interface declaration, implementation and recursive call;BuildSingleTestAsyncis used only by that loop. #7328 closed without merging. Its row-event changes now live in #7381 / open PR #7384, which edits the same streaming path; added #7381 as the direct prerequisite. #7326 remains the failed-row follow-up that may also touch this path.Remove unused streaming test builder path (#7327)
Remove unused streaming test builder path (#7327)
Remove unused streaming test builder path (#7327)
Remove unused streaming test builder path (#7327) (#7535)