test(session): follow sibling actor test naming convention by senamakel · Pull Request #396 · tinyhumansai/tinyagents

senamakel · 2026-10-11T17:18:21Z

Changes

Follow up merged #395: rename the second driver module test group to mod_actor_tests.rs and update its sibling module path, matching AGENTS.md lines128–129. Test contents and behavior are unchanged.

Addresses #395 (comment).

Validation

cargo test -p tinyagents-session --features storage-drivers actor_tests --quiet: 3 passed, 550 filtered out.
cargo fmt -p tinyagents-session --check: passed.
git diff --check: passed.

Verified in an isolated canonical checkout based on merged6ae6ecf1, without changing the shared host/submodule dependency source.

Summary by CodeRabbit

Tests
- Updated the source file used for actor tests.

Relocate the actor factory and takeover tests to a new module file and update the path attribute in the drivers module so the tests continue to compile from their new location. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>

chatgpt-codex-connector · 2026-10-11T17:18:34Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-11T17:19:37.682120Z	`305744b`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-11T17:18:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: f75687b7-de54-48c1-87d1-83a49e8ac9f4

📥 Commits

Reviewing files that changed from the base of the PR and between 6ae6ecf and 305744b.

📒 Files selected for processing (2)

crates/tinyagents-session/src/port/drivers/mod.rs
crates/tinyagents-session/src/port/drivers/mod_actor_tests.rs

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The test-only actor_tests module now loads from mod_actor_tests.rs instead of actor_tests.rs.

Changes

Actor test module

Layer / File(s)	Summary
Update actor test module path `crates/tinyagents-session/src/port/drivers/mod.rs`	The test-only `actor_tests` module declaration now points to `mod_actor_tests.rs`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 30574

This is a test-only file rename with a matching module-path update; runtime behavior is unchanged, so no merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 30574

The change affects 1 system.

Changed systems: crates

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — crates (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in crates/tinyagents-session/src/port/drivers/mod.rs: The test-only actor_tests module’s source path changed from actor_tests.rs to mod_actor_tests.rs.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly summarizes the module naming change and matches the pull request objectives.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{A rabbit checks the test path today,
mod_actor_tests.rs leads the way.
The module points to its new place,
One small edit, a tidy trace.
Then off I hop with ears held high!}

_{Comment @coderabbitai help to get the list of available commands.}

tinysweeper · 2026-10-12T01:20:36Z

Tiny Sweeper review

Tiny Sweeper completed its review; deterministic results follow.

State: Ready for maintainer review
Priority: none
Reviewed head: 305744bc50a3
Updated: 2026-10-12T01:22:08Z

Review snapshot

Change surface	Files	Review signal
Production	1	Active findings
Tests	1	Noted findings
Documentation	0	Resolved findings
Configuration	0	Pending checks/questions

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The `#[path]` attribute for the `#[cfg(test)] mod actor_tests` declaration in `crates/tinyagents-session/src/port/drivers/mod.rs` now points at `mod_actor_tests.rs` instead of `actor_tests.rs`. No production code or test contents are modified.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["DriverSessionStores<br/>changed"]:::changed
  n1["memory"]:::impacted
  n2["SessionStoreProvider"]:::impacted
  n3["scope_for"]:::impacted
  n4["try_for_agent"]:::impacted
  n5["sqlite"]:::impacted
  n6["build"]:::impacted
  n0 -->|implements| n2
  n1 -->|uses| n0
  n4 -->|calls| n3
  n4 -->|calls| n6
  n5 -->|uses| n0
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff

Agent review details

critique

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The change only repoints the `#[cfg(test)]` module's `#[path]` from `actor_tests.rs` to `mod_actor_tests.rs`; the directory listing at the reviewed commit shows `mod_actor_tests.rs` present and no `actor_tests.rs`, so the module declaration resolves to a real sibling file and the rename matches the repository's `<module>_<topic>_tests.rs` naming rule. No defect found in this file. _The code index is behind this pull request (indexed at `ddf6a2056e2b`), so retrieved context may be out of date._

security

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The change is a single rename of a test module's `#[path]` attribute from `actor_tests.rs` to `mod_actor_tests.rs`. The repository context shows other test files in this directory named `mod_tests.rs`, and the AGENTS.md rule requires test files to be named `<module>_tests.rs` — the new name `mod_actor_tests.rs` does not match the actor module whose tests it holds, but I cannot confirm from the diff alone whether the corresponding file `mod_actor_tests.rs` exists in the tree; if it does not, the crate would fail to compile under `cfg(test)`. I was unable to verify the file's presence with a lookup in this pass. _The code index is behind this pull request (indexed at `ddf6a2056e2b`), so retrieved context may be out of date._

tests

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The change is a pure test-module rename: the `#[path]` attribute for the actor tests in `port/drivers/mod.rs` now points at `mod_actor_tests.rs`, and that file exists at that path. No behaviour changes, no production code is touched, and the repository's rule that test files be named `<module>_<topic>_tests.rs` is satisfied by the new name. Nothing here can regress silently, so no test is needed. _The code index is behind this pull request (indexed at `ddf6a2056e2b`), so retrieved context may be out of date._

commits

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: Nothing sensitive found in what this pull request commits.

description

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The description matches the diff: a one-line change updating the `#[path]` attribute for the actor test module to `mod_actor_tests.rs`, consistent with the sibling `mod_tests.rs` convention, with test contents untouched. No findings. _The code index is behind this pull request (indexed at `ddf6a2056e2b`), so retrieved context may be out of date._

Evidence and run details

Models: ladder/vectors-oai3, deepseek-v4.1-flash
Spend: $0.000329
Tokens: 77973 input · 4382 output · 25856 cached · 47 embedding

Head	State	Pass summary
`305744bc50a3`	ready for maintainer review	0 active finding(s), 0 resolved finding(s) (at 2026-10-12T01:22:08Z)

tinysweeper

tinysweeper found nothing blocking. Approving.

             $0.0003 · 77,973 in / 4,382 out · 25,856 cached (33%) · ladder/vectors-oai3, deepseek-v4.1-flash · 47 embedded
critique:    $0.0002 · 27,002 in / 2,751 out · 13,312 cached (49%) · deepseek-v4.1-flash
security:    $0.0000 · 13,001 in / 166 out   · 1,920 cached (15%)  · deepseek-v4.1-flash
tests:       $0.0000 · 26,610 in / 441 out   · 5,504 cached (21%)  · deepseek-v4.1-flash
description: $0.0000 · 9,785 in  / 325 out   · 5,120 cached (52%)  · deepseek-v4.1-flash

coderabbitai Bot approved these changes Oct 11, 2026

View reviewed changes

senamakel merged commit a55f25a into main Oct 11, 2026
11 checks passed

senamakel mentioned this pull request Oct 11, 2026

Update TinyAgents and preserve typed definition routing tinyhumansai/openhuman#7470

Merged

11 of 12 tasks

tinysweeper Bot approved these changes Oct 12, 2026

View reviewed changes

tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 12, 2026

Navigation Menu

Repository navigation

test(session): follow sibling actor test naming convention - #396

test(session): follow sibling actor test naming convention#396
senamakel merged 1 commit into
mainfrom
actor-test-filename

senamakel commented Oct 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

Uh oh!

tinysweeper Bot commented Oct 12, 2026 •

edited

Loading

critique

security

tests

commits

description

Uh oh!

tinysweeper Bot left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

senamakel commented Oct 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Validation

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

Uh oh!

tinysweeper Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tiny Sweeper review

Review snapshot

What changed

Features

Tests

Findings

Before merge

How this fits together

critique

security

tests

commits

description

Uh oh!

tinysweeper Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

senamakel commented Oct 11, 2026 •

edited by coderabbitai Bot

Loading

chatgpt-codex-connector Bot commented Oct 11, 2026 •

edited

Loading

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

tinysweeper Bot commented Oct 12, 2026 •

edited

Loading