Repository navigation
Audit pm CLI SDK and package ecosystem - #88
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @unbraind, your pull request is larger than the review limit of 150000 diff characters
|
Warning Review limit reached
More reviews will be available in 24 minutes and 5 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (70)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a package-first ecosystem audit, introducing lazy extension activation, shared repeatable metadata parsers, runtime-resolved shell completions, vector store orphan pruning, and SDK ergonomics improvements such as package-safe expected errors and testing helpers. Feedback on these changes focuses on optimizing calendar recurrence loops by removing redundant ISO string normalization, and enhancing runtime safety through defensive nullish/falsy checks when mapping over command arguments and type registry definitions.
2419528 to
7969703
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 241952855b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
7969703 to
3818c60
Compare
Implement the 2026-05-31 manual ecosystem audit slice across the pm CLI, SDK, and bundled package ecosystem, including PR review follow-ups. Highlights: - add manifest-scoped lazy extension activation with template probing, type-aware help preservation, and search-capability activation for command-scoped manifests - add SDK expected-error helpers, runtime/testing exports, manifest version gates, and package authoring docs - reset/re-embed semantic vectors on provider/model/dimension changes, preserve existing vectors during mutation refresh metadata changes, record actual extension embedding identities, prune extension vector orphans, and recreate Qdrant collections when dimensions change - normalize calendar recurrence exdates by parsed instant and document recur_count anchoring - add runtime status/type completion helpers and package guide-shell completion support - deduplicate create/update repeatable metadata parsers into a shared helper - classify module import failures as module_import_failed for actionable telemetry/Sentry recovery Verification: - node scripts/run-tests.mjs test -- tests/integration/extension-startup.integration.spec.ts tests/unit/search-cache.spec.ts tests/unit/reindex-command.spec.ts tests/unit/vector-store-adapter.spec.ts tests/unit/sdk-index.spec.ts tests/unit/calendar-command.spec.ts tests/unit/completion-command.spec.ts tests/unit/package-manifest.spec.ts: 8 files, 227 tests passed - node scripts/run-tests.mjs coverage: 135 files, 2061 tests, 100% statements/branches/functions/lines - pnpm quality:static - pnpm changelog:pm:check - pnpm release:gates - node scripts/release/sentry-telemetry-gate.mjs --json --telemetry-mode best-effort - timeout 45 bash scripts/prod/telemetry/check-stack-health.sh - pnpm audit --json - manual temp-project dogfood with all bundled packages, SDK smoke, custom schema, and Ollama+LanceDB hybrid search
3818c60 to
601b6fb
Compare
….15 recovery verified, pm-hvt3 filed (residual staging-base canonicalization, third pm-0fhw-class site), GH-569 mapped to pm-j8vq, roadmap phase map on pm-doxj Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ico2SMPEHn6PL97EwEERL
Summary
Verification
Notes