Repository navigation
pr-set : swap the DeepSeek-V4.1 pin #298 for #332 - #333
Merged
Merged
Conversation
…eek41 + MXFP8)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap the DeepSeek-V4.1 pin in
scripts/unsloth/pr-set.json: #298 (full DeepSeek-V4.1 stack) is replaced at the same position, after #61, by #332, which keeps upstreamdeepseek41verbatim and adds only MXFP8 (type 43, the Engram table of the published UD-Q3_K_XL / UD-Q4_K_XL / UD-Q8_K_XL GGUFs) and the other extras listed in #332.feature-checks.json: thedeepseek41owner moves from #298 to #332.Why: upstream ggml-org#31137 (in b11890 and later) conflicts with #298 in four DeepSeek-V4.1 files, so #298 is refused on every base the nightly can pick now.
80f0f5aSimulated merge loop over the tag window (b11923 .. b11932): #332 merges cleanly on every tag and its lines are intact;
merge_checksclean.Still refused in the same window, independent of this change (separate pin fixes):
src/llama-model-saver.cpp, upstream llama : add llama_arch_* query API and refactor test-llama-archs to use it ggml-org/llama.cpp#30880 (from b11897)src/llama-memory-hybrid-idx.cpp, upstream llama : move no_alloc out of llama_hparams ggml-org/llama.cpp#31141common/common.cpp,common/fit.cpp, upstream server: add router device memory margin parameter for dynamic unloading ggml-org/llama.cpp#21231 (from b11930)The nightly stays red until those are repinned; this PR only removes the DeepSeek-V4.1 refusal.