Repository navigation
pr-set : repin DiffusionGemma, Inkling, #241 and #251 for upstream b11946 - #334
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repin four pins in
scripts/unsloth/pr-set.jsonthat no longer merge on the bases the nightly picks now (aged base b11946 today, newest tag b11954). Each pin branch gotFix merge conflictsmerges of upstream release tags (b11935, the aged base when this started; Inkling also b11938; DiffusionGemma also b11946), keeping the upstream code as is and re-applying only the pin's own change. All four pushes are fast-forwards of the existing PR branches.Stacked on #333 (the DeepSeek-V4.1 pin swap #298 -> #332); merge #333 first.
llama_arch_supports_saveinsrc/llama-arch.cpp), then ggml-org#31275 (b11946,encode()insrc/llama-context.cpp)LLM_ARCH_DIFFUSION_GEMMAadded to the upstream list; inencode()the upstream code is taken as is, since ggml-org#31275 already makes a decoder without memory output only its marked tokens, which is what the pin's change there did2e715c063LLM_ARCH_INKLINGadded to the upstream list; LFM3 and Inkling entries kept side by side3582c5ee0no_allocmoved into the KV cache constructor,n_paddropped)type_idxwith the new constructor arguments82b228db0common_fit_apply, logger scope helper)moe_cache_autopassed throughcommon_fit_apply; the chosen cache size is stored back into params after the fit, as before44e810753Both ggml-org branches also merge cleanly with ggml-org
masteragain (ggml-org#25731 showed as conflicting before this).Simulated merge loop with these four, the DeepSeek-V4.1 pin #332 from #333, and the Metal NVFP4 pin #330 from #331:
The pin-set dry-run check on #331 and #333 fails on the current master set (the four pins above refuse, and #298 refuses since upstream took DeepSeek-V4.1); with this PR and #333 merged, #331 should go green after an update from master.
Merged tree (same set), CUDA sm_100 on B200:
CPU gate and CPU feature matrix pass on both tags.
Numeric gates on the two model pins:
Q4_K_M,-s 42 -n 256, each arm twicedd7f73b19, previous repin15ce29a4a, new head2e715c063, new head + ggml-org masterUD-IQ1_S, wikitext-2-c 512 --chunks 2048ad1d844vs new head3582c5ee0; new head vs new head + ggml-org masterBoth differences come from upstream CUDA changes that every current base already has (the fused gate/up MMQ path, and rms_norm float4 variants), not from these merges. Against a CPU reference on 4 chunks the Inkling old head and new head are equally far (KLD 0.236 and 0.240, top-1 80.7% and 82.7%), so the change moves the numbers without making them worse. The second DiffusionGemma merge (b11946,
encode()) changes nothing: its output is byte-identical to the previous repin.Not covered here: ROCm, Vulkan, macOS, Windows and ARM legs (nightly only).