[astro-factory]

Changes

• NormalizeLocales now extracts T[K]['path'] instead of T[K]['codes'][number] from object locales, so the TypeScript type for i18n.defaultLocale (and i18n.fallback / i18n.domains keys) matches what config validation and the i18n runtime actually require. Previously, passing a locale path as defaultLocale was a type error, while passing a codes value was a runtime error — making it impossible to satisfy both at once.
• No runtime behavior changes; this is a type-only fix.

Testing

• Updated the type test in packages/astro/test/types/define-config.ts to assert that defaultLocale accepts a locale path value, and added positive/negative cases covering the corrected type.

Docs

• No docs update needed; this corrects an incorrect TypeScript type with no change to documented behavior.

Closes #18423

[changeset-bot]

🦋 Changeset detected

Latest commit: e0358c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[astro-factory]

astro-author owns this pull request

Factory's code author persona works on this branch when a maintainer or Factory's reviewer requests changes, or when checks fail: it pushes follow-up commits, replies to review threads, and asks for another review. It never merges. Unassign astro-author to take the pull request back; reassign it to start a fresh budget.

Rounds used: 0 of 5
Status: waiting for feedback.

_{— astro-author (Factory persona)}

[astro-factory]

Verdict: approved. No blocking findings remain.

_{GitHub doesn't let Factory approve a pull request it opened, so this verdict is recorded as a comment.}

Findings

No findings.

Merge Requirement Assessment

Status: satisfied

• i18n.defaultLocale, i18n.fallback, and i18n.domains types accept a custom locale's path instead of its codes. NormalizeLocales now maps object locales to T[K]['path']. This matches validateI18nDefaultLocale, validateI18nFallback, and validateI18nDomains in core/config/schemas/refined-validators.ts. Each of those validators turns locales into a list of locale.path values before checking keys and values against it.
• The change is type-only, with no runtime behavior change. Only the public type alias changed. No runtime files are touched.
• Type tests cover the corrected behavior.
  • The existing assertion now expects 'en' | 'french'.
  • A new positive case uses only object locales, with fallback and domains keyed by path. Before this change, it would not have compiled.
  • A new @ts-expect-error case rejects a codes value used as defaultLocale. Before this change, that value was accepted, so the case would have failed.

Review Status

Verdict: ready to merge based on static review
Context: PR #18467 plus linked issue #18423, as referenced in the PR body
Scope: PR base d7f5c54 to head e0358c2: .changeset/hip-worlds-grab.md, packages/astro/src/types/public/config.ts, packages/astro/test/types/define-config.ts.
Changeset: present and covers astro (patch).
Limitations: I didn't read the full text of linked issue #18423. I took the requirements from the PR description and checked them against the config validators.
Validation: Static review only; no project code, tests, builds, or checks were run.
GitHub context: collected
Git scope: PR base/head verified

This review was made by an LLM. The analysis may be wrong, and reports might be incorrect.

[github-actions]

⚠️ New Duplicate Dependencies (found: 6, threshold: 1)

📦 Package	📋 Versions
vitest	2 versions root@ vitest@4.1.11 vitest@5.0.4
find-up	4 versions find-up@4.1.0 root@ eslint@10.12.0 find-up@5.0.0 find-up@6.3.0 find-up@7.0.0
tinybench	2 versions root@ vitest@4.1.11 tinybench@2.9.0 tinybench@6.2.2
@vitest/spy	2 versions root@ vitest@4.1.11 @vitest/expect@4.1.11 @vitest/spy@4.1.11 @vitest/spy@5.0.4
@vitest/mocker	2 versions root@ vitest@4.1.11 @vitest/mocker@4.1.11 @vitest/mocker@5.0.4
why-is-node-running	2 versions root@ vitest@4.1.11 why-is-node-running@2.3.0 why-is-node-running@3.2.1

💡 To find out what depends on a specific package, run: pnpm -r why example-package

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package	🔒 Before	🔓 After
@codspeed/core	trustedPublisher	provenance
@codspeed/vitest-plugin	trustedPublisher	provenance
tinybench	stagedPublish	none
tinyrainbow	stagedPublish	none
why-is-node-running	provenance	none

[codspeed]

Merging this PR will not alter performance

⚠️ 3 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

• Build: full static site
• Build: hybrid site (static + server)
• Build: full server site

✅ 21 untouched benchmarks

---

_{Comparing factory/fix-18423 (e0358c2) with main (dda9ec3)¹}

Footnotes

1. No successful run was found on main (d7f5c54) during the generation of this report, so dda9ec3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩