Repository navigation
Conversation
🦋 Changeset detectedLatest commit: cd7f2a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will not alter performance1 warning, 1 note
Comparing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
i18n.fallbackvalues are locale paths: config validation checks them against each locale'spath, and in i18n object locale codes are rejected as defaultLocale in config validation #16117 the routing was confirmed to be driven bypath. For a locale whosepathis not one of itscodes, such as{ path: 'french', codes: ['fr', 'fr-CA'] }, the fallback code passed that path togetPathByLocale(), which only looks atcodes, so it threwi18nNoLocaleFoundInPath. Withfallback: { es: 'french' },astro buildfails withi18nNoLocaleFoundInPathwhile rendering/es/about.{ path: 'en-us', codes: ['en-US'] }as the default locale,fallback: { french: 'en-us' }) makescomputeFallbackRoute()throw the same error for a missing/french/page.computeFallbackRoute()andredirectToFallback()now use it directly.Testing
fallback.test.ts(a fallback to a locale object, and a fallback to a default locale with a custom path) and inmanual-routing.test.ts(redirectToFallback). They fail withi18nNoLocaleFoundInPathbefore the change and pass after it; reverting either call site makes its own test fail.locales: ['en', 'es', { path: 'french', codes: ['fr', 'fr-CA'] }]andfallback: { es: 'french' },astro buildnow succeeds and/es/aboutredirects to/french/about/. Withfallback: { es: 'en' },/es/aboutstill redirects to/about/.Docs
No docs change: this makes an existing configuration work as configured.