Repository navigation
fix: improve TimeCapsule timeline controls and restoration - #164
Open
MaxMichel2 wants to merge 1 commit into
Open
MaxMichel2 wants to merge 1 commit into
MaxMichel2 wants to merge 1 commit into
Conversation
Only earlier timeline entries offer Restore. Keep expansion through screen recreation within the same recording, reject saved IDs from a new recording, and use shared empty-history guidance. Preserve the timeline rail and highlights. Validation: 39 TimeCapsule host tests, 9 connected Android device tests, 15 Konsist tests, Detekt Full and sample Android debug build passed. Light/dark screenshots reviewed; manual earlier-entry restore checked on the device. iOS runtime, TalkBack and enlarged-font execution remain pending.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+45
to
+48
| var expandedIds by rememberSaveable( | ||
| recordingId, | ||
| stateSaver = listSaver<List<Long>, Any>( | ||
| save = { listOf(element = recordingId) + it }, |
There was a problem hiding this comment.
expandedIds now goes into saved state, but it keeps IDs after their entries leave the timeline. A long-running recording can therefore save an ever-growing list even though maxEntries bounds the history. This wastes memory and increases the work needed to save the screen. Filter expansion against retained entry IDs when history changes, including after Clear.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Stack
Depends on #163. The description and merge diff cover only the TimeCapsule layer against
refactor/console-log-rows.Intended merge order: #157 → #159 → #160 → #161 → #163 → this PR. Add this layer to existing GitHub stack #162; do not merge before its predecessors.
The PR appears safe to merge, with a non-blocking cleanup needed for saved expansion IDs.
Findings
Summary
Updates Time Capsule controls and saves expansion for the active recording.
Reviews (1) · Last reviewed commit: ":lipstick: Hide no-op Restore and enlarg..." · Reviewed by Greptile