Skip to content

chore: polish sample and record DevView UI audit follow-up - #166

Open
MaxMichel2 wants to merge 5 commits into
refactor/networkmock-sheet-detailfrom
chore/sample-tidy-audit-report
Open

MaxMichel2 wants to merge 5 commits into
refactor/networkmock-sheet-detailfrom
chore/sample-tidy-audit-report

Conversation

@MaxMichel2

@MaxMichel2 MaxMichel2 commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Tidy the sample integration with labelled sections, accessible controls, corrected Android system-bar appearance and cancellation-safe request handling.
  • Apply owner-approved NetworkMock follow-ups: compact saved-state/sequence header, Responses/Failures browsing, searchable responses, consistent outcome badges, explicit Details actions and measured keyboard relocation.
  • Reject enabled Console noise before the bounded queue/history so excluded bursts cannot evict useful logs. Load saved rules before capture; disabling rules affects future entries only.
  • Record all 50 original audit findings, joint light/dark Android approvals and the complete qualified 52-item antislop worksheet in anti-slop/report-001-2026-11-09.md.

Validation

  • 435 registered host tests and 15 Konsist tests passed. Unchanged host results were reused from Gradle cache in the last aggregate run; all four new Console regressions executed in the preceding focused run.
  • Complete Hybrid device run: 198 tests passed, including 116 NetworkMock tests and 30 sheet tests.
  • After the Console admission fix, all 21 unchanged Console device tests passed on one retry. The first run had four Compose hierarchy failures; a complete 198-test rerun after this fix is not claimed.
  • Detekt, API compatibility, sample assembly and updated Dokka/versioned Zensical passed. Known Detekt KMP/generated-serializer analysis diagnostics remain documented, not suppressed. Normal secret-detection and Detekt commit hooks passed.
  • Owner accepted the recorded normal-font light/dark Android module, detail, diff, sequence and sample states. TalkBack and further 200% checks are deferred. iOS runtime, exhaustive keyboard/reduced-motion, every breakpoint and arbitrary host theme are not certified. This is not a blanket antislop certificate.

Stack and merge order

This is PR G, based on refactor/networkmock-sheet-detail, appended to native stack 162. Merge bottom to top; do not merge this independently against main. Existing PRs are not retargeted or rewritten.

Order PR Head Base
1 #157 feat/networkmock-ux-revamp main
2 (A) #159 refactor/devview-shell-ui-kit feat/networkmock-ux-revamp
3 (B) #160 refactor/featureflip-segmented-control refactor/devview-shell-ui-kit
4 (C) #161 feat/analytics-event-detail refactor/featureflip-segmented-control
5 (D) #163 refactor/console-log-rows feat/analytics-event-detail
6 (E) #164 fix/timecapsule-restore-target refactor/console-log-rows
7 (F) #165 refactor/networkmock-sheet-detail fix/timecapsule-restore-target
8 (G) This PR chore/sample-tidy-audit-report refactor/networkmock-sheet-detail

Scope notes

No new library public API is added by these follow-ups. Unrelated local settings, roadmaps and generated caches are excluded. The separate cleanup commit df34c02 removes 577 tracked graphify-out/ artifacts and ignores the entire output directory. All 770 existing local output files were preserved with unchanged SHA-256 hashes. Audit reports and Graphify skills remain tracked. This is a one-time deletion diff; future graph updates stay local. Git history and earlier stack branches are not rewritten.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge in the stated stack order.

Summary

This PR polishes the sample, updates the NetworkMock picker and rejects enabled Console noise before it enters the queue.

  • NetworkMock shows saved behavior separately from response browsing.
  • Enabled Console noise rules reject matching logs before buffering.
  • The sample groups its demos and follows its Dark Mode flag on Android.
  • The audit follow-up records its scope and refreshes the generated code graph.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Load saved Console rules] --> B[Apply enabled patterns]
  B --> C[Start native capture and queue drain]
  D[Incoming log] --> E{Matches enabled noise rule?}
  E -->|Yes| F[Discard]
  E -->|No| G[Bounded pending queue]
  G --> H[Recheck rules and clear generation]
  H --> I[Bounded retained history]
  J[Saved rule changes] --> B
Loading

Reviews (1) · Last reviewed commit: ":memo: Record owner-approved DevView UI ..." · Reviewed by Greptile

Give the sample labelled sections, one primary DevView action, wrapping secondary
controls and an inset-safe scrollable result card. Preserve CounterScreen's
composition lifetime and propagate request cancellation.

Make Android system-bar icons follow the app theme, with a matching legacy
navigation background on API 26-28. Keep the approved iOS host-owned no-op.
Sample analytics already seed once; verify the count stays stable on theme changes.

Validation: sample debug assemble and shared host-test task, Konsist and Detekt
passed. Runtime XML/assert checks cover greeting, counter hide/reset, mocked
request/reset, 34 -> 34 analytics count and reachable content at 200% font.
Android 17 reports light system-bar appearance in light mode and clears it in dark.
Graph update and hash-checked document recovery passed. Detekt reports eight
analysis compiler errors; Kotlin compilation passes. API 26-28 and iOS runtime,
spoken TalkBack and final visual approval remain unverified.
Separate saved configuration from Responses/Failures browsing. Add response search, explicit Details actions, consistent status badges and measured focus relocation that keeps choices visible above the keyboard. Preserve selection, sequencing and persistence behavior.

Validation: 431 host tests, 198 device tests and 15 architecture tests passed after the sheet revision; the sheet includes 30 device tests and two search host tests. Detekt, API compatibility, sample assembly and versioned documentation build passed. The owner approved the reviewed light/dark states on the connected Android device. Wider platform and exhaustive accessibility checks remain unverified.
Apply persisted admission rules before capture and both bounded buffers so excluded bursts cannot evict useful logs. Keep older retained history and make disabling rules future-only; retain rules across collector lifetimes and I/O retries.

Validation: 435 registered host tests, 15 Konsist tests, Detekt, API compatibility and sample assembly passed. All 33 Console host tests and the unchanged 21-test device suite passed; the first device run had four Compose hierarchy failures before one successful retry. The owner approved the installed light-mode explanation. No complete cross-platform or accessibility sign-off is claimed.
Map all 50 original findings to implementation or approved disposition, record joint light/dark Android reviews and the accepted sheet/Console follow-ups, and retain the complete 52-item qualified gate worksheet.

Record 435 host tests, 15 architecture tests, the complete 198-test Hybrid device run and the later 21-test Console retry, build/API/docs checks and local AST integrity checks. No blanket antislop, cross-platform or exhaustive accessibility certificate is claimed. Generated Graphify changes are not included; the owner requested local-only tracking in a follow-up.
@MaxMichel2
MaxMichel2 added this pull request to stack #162 November 9, 2026 18:07
Ignore the entire root graphify-out directory and remove its 577 tracked artifacts from the index without deleting local files. Clarify the local-only policy for agents and fresh clones. Keep Graphify skills, audit reports and source intact.

Validation: all 770 existing local output files retain their SHA-256 hashes after index-only removal; zero graphify-out paths remain tracked and ignore checks cover graph, manifest and cache. This is a one-time removal, not a rewrite of repository history.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant