Repository navigation
chore: polish sample and record DevView UI audit follow-up - #166
Open
MaxMichel2 wants to merge 5 commits into
Open
MaxMichel2 wants to merge 5 commits into
MaxMichel2 wants to merge 5 commits into
Conversation
Give the sample labelled sections, one primary DevView action, wrapping secondary controls and an inset-safe scrollable result card. Preserve CounterScreen's composition lifetime and propagate request cancellation. Make Android system-bar icons follow the app theme, with a matching legacy navigation background on API 26-28. Keep the approved iOS host-owned no-op. Sample analytics already seed once; verify the count stays stable on theme changes. Validation: sample debug assemble and shared host-test task, Konsist and Detekt passed. Runtime XML/assert checks cover greeting, counter hide/reset, mocked request/reset, 34 -> 34 analytics count and reachable content at 200% font. Android 17 reports light system-bar appearance in light mode and clears it in dark. Graph update and hash-checked document recovery passed. Detekt reports eight analysis compiler errors; Kotlin compilation passes. API 26-28 and iOS runtime, spoken TalkBack and final visual approval remain unverified.
Separate saved configuration from Responses/Failures browsing. Add response search, explicit Details actions, consistent status badges and measured focus relocation that keeps choices visible above the keyboard. Preserve selection, sequencing and persistence behavior. Validation: 431 host tests, 198 device tests and 15 architecture tests passed after the sheet revision; the sheet includes 30 device tests and two search host tests. Detekt, API compatibility, sample assembly and versioned documentation build passed. The owner approved the reviewed light/dark states on the connected Android device. Wider platform and exhaustive accessibility checks remain unverified.
Apply persisted admission rules before capture and both bounded buffers so excluded bursts cannot evict useful logs. Keep older retained history and make disabling rules future-only; retain rules across collector lifetimes and I/O retries. Validation: 435 registered host tests, 15 Konsist tests, Detekt, API compatibility and sample assembly passed. All 33 Console host tests and the unchanged 21-test device suite passed; the first device run had four Compose hierarchy failures before one successful retry. The owner approved the installed light-mode explanation. No complete cross-platform or accessibility sign-off is claimed.
Map all 50 original findings to implementation or approved disposition, record joint light/dark Android reviews and the accepted sheet/Console follow-ups, and retain the complete 52-item qualified gate worksheet. Record 435 host tests, 15 architecture tests, the complete 198-test Hybrid device run and the later 21-test Console retry, build/API/docs checks and local AST integrity checks. No blanket antislop, cross-platform or exhaustive accessibility certificate is claimed. Generated Graphify changes are not included; the owner requested local-only tracking in a follow-up.
Ignore the entire root graphify-out directory and remove its 577 tracked artifacts from the index without deleting local files. Clarify the local-only policy for agents and fresh clones. Keep Graphify skills, audit reports and source intact. Validation: all 770 existing local output files retain their SHA-256 hashes after index-only removal; zero graphify-out paths remain tracked and ignore checks cover graph, manifest and cache. This is a one-time removal, not a rewrite of repository history.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anti-slop/report-001-2026-11-09.md.Validation
Stack and merge order
This is PR G, based on
refactor/networkmock-sheet-detail, appended to native stack 162. Merge bottom to top; do not merge this independently against main. Existing PRs are not retargeted or rewritten.feat/networkmock-ux-revampmainrefactor/devview-shell-ui-kitfeat/networkmock-ux-revamprefactor/featureflip-segmented-controlrefactor/devview-shell-ui-kitfeat/analytics-event-detailrefactor/featureflip-segmented-controlrefactor/console-log-rowsfeat/analytics-event-detailfix/timecapsule-restore-targetrefactor/console-log-rowsrefactor/networkmock-sheet-detailfix/timecapsule-restore-targetchore/sample-tidy-audit-reportrefactor/networkmock-sheet-detailScope notes
No new library public API is added by these follow-ups. Unrelated local settings, roadmaps and generated caches are excluded. The separate cleanup commit
df34c02removes 577 trackedgraphify-out/artifacts and ignores the entire output directory. All 770 existing local output files were preserved with unchanged SHA-256 hashes. Audit reports and Graphify skills remain tracked. This is a one-time deletion diff; future graph updates stay local. Git history and earlier stack branches are not rewritten.

Confidence Score: 5/5
This PR appears safe to merge in the stated stack order.Summary
This PR polishes the sample, updates the NetworkMock picker and rejects enabled Console noise before it enters the queue.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Load saved Console rules] --> B[Apply enabled patterns] B --> C[Start native capture and queue drain] D[Incoming log] --> E{Matches enabled noise rule?} E -->|Yes| F[Discard] E -->|No| G[Bounded pending queue] G --> H[Recheck rules and clear generation] H --> I[Bounded retained history] J[Saved rule changes] --> BReviews (1) · Last reviewed commit: ":memo: Record owner-approved DevView UI ..." · Reviewed by Greptile