Repository navigation
fix(safe-delete): collected SDK fixturesを所有照合付きで保存する - #250
Open
mashfromband wants to merge 2 commits into
Open
mashfromband wants to merge 2 commits into
mashfromband wants to merge 2 commits into
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: ee41ffe3-e686-465e-b969-1e1e7d246dcc) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 11042053-b5e1-41ac-a7e9-256626a7e2c9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PassShareの回収済み検査SDKを既存safe-deleteで退避できるようにします。元の所有記録が一致する3rootだけに限定し、rustup相対link・Windows内部junction・全inventory/内容を移動前後で検証します。一般planのreparse/Git/外部hardlink保護は維持します。
Go race/vet/buildと合成fixtureの回帰検査に成功しました。実物3rootの読み取りinspectも成功し、内容量は合計2,813,105,600bytesです。別モデルレビューとCI成功後に配備・退避します。退避は削除量や空き増加として報告しません。
Note
Medium Risk
Bounded to three fixed receipts but performs large same-drive moves with complex Windows reparse/junction rules; mis-invocation or partial failure can leave dual locations until manual follow-up.
Overview
Adds a ToDo3004 path in
safe-deleteto preserve (not delete) three PassShare SDK inspection roots whose ownership receipts match fixed integrity hashes.New
inspect-sdk --idruns read-only collection/evidence checks and reports measured inventory;quarantine --id --reason sdk-linksmoves the tree to same-drive削除希望after fixture lock + stoppedCC-PSW-fixtureservice checks. Quarantine uses a dedicatedsdkScopethat snapshots metadata and SHA256 intopreservation.json, validates before/after move, and allows only the 13runtime/sdk/bootstrap/bin→rustup.exerelative symlinks plus the internalINetCache/Content.IE5junction (raw reparse hash + absolute target preserved, not walked).rawIdentityand optionalTargeton preservation entries support that scanner; ordinaryplan/ default walks still reject reparse points.Docs (
README,docs/todo3004-sdk-recovery.md) describe scope and remaining rollout steps. Windows tests cover link/junction preservation, external links/Git/secrets rejection, tamper detection, and receipt forgery.Reviewed by Cursor Bugbot for commit 7c261a1. Bugbot is set up for automated code reviews on this repo. Configure here.