Repository navigation
オーナーの返事を反映するresume-のジョブをreq-と同じ最上位で起動する - #38
Open
mashfromband wants to merge 1 commit into
Open
mashfromband wants to merge 1 commit into
mashfromband wants to merge 1 commit into
Conversation
resume- jobs reflect an owner's Discord answer or new instruction into an existing session. Waiting behind ordinary work left the owner's reply unacted on.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: cd11c4cf-5c62-4cb8-807a-7a9e87b37661) |
Contributor
Author
別モデルによる読み取りレビューの結果判定: Must なし 確認した点:
Suggestion・Nit はありません。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
オーナーの Discord の返事・新しい指示・停止作業の再開を既存のセッションへ反映する
resume-のジョブを、req-と同じ最上位の順位にします。オーナーが答えたのに作業が進まない時間をなくすためです。変更
queue_priorityでresume-をreq-と同じ順位 0 にする(同じ順位の中は従来どおり待ち時間の長い順)lowest_priority_todo_ids(ToDo 18・23)の指定は従来どおり名前より優先するテスト
owner_then_shepherd_then_other_jobs_use_fifo_within_each_classにresume-を追加しました。修正前は失敗し、修正後は通ることを確認しています。手元では
cargo nextest run --locked --workspaceが 1186 件すべて成功し、cargo clippy -p cc-jobs --all-targets -D warningsとcargo fmtの確認も通りました。Note
Low Risk
Small, localized queue ordering change with a parity test; no auth or data-path impact.
Overview
Owner reply / session resume jobs (
resume-, e.g. Discord answers reflected into an existing session) now share top priority (tier 0) with direct owner requests (req-), ahead of shepherd (shep-) and other work. Within that tier, FIFO by queue time is unchanged.queue_prioritytreats names starting withresume-likereq-.lowest_priority_todo_ids/normal_priority_todo_idsstill override name-based priority. README documents the updated ordering.Parity test
owner_then_shepherd_then_other_jobs_use_fifo_within_each_classnow asserts aresume-job runs between older and newerreq-jobs when slots allow.Reviewed by Cursor Bugbot for commit 5bdf527. Bugbot is set up for automated code reviews on this repo. Configure here.