Repository navigation
元レビューのsource参照を受付文字列とジョブ名の構文に分ける - #436
Merged
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: b8435339-3143-4fbe-968b-e71fd54ad64e) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 6126b15c-b5f6-4f57-852a-0c47c9636aa3) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
元レビューの保存参照が、元受付の文字列なのかジョブ名なのかを、参照の有無だけでは区別できませんでした。固定対象・入力を維持し、復旧source参照だけに文字列の完全一致・部分一致、queueの固定語・接頭語、ジョブ名の構文と日時部分を補います。
参照文字列、ハッシュ、ラベル、パスは出さず、参照先も開きません。日時のタイムゾーン・実ジョブの存在は未確認とし、文字列や構文の一致を同一性や来歴の証明へ昇格させません。既存の状態・依存・受付・閲覧資格を変更しません。
新しいテストで未実装のRedを確認し、追加後の関連テスト、モジュール全体のrace(4.601秒)、vetが成功しました。参照の部分一致、パス、不正日時・非ASCII名、不在/null/型不正と出力の秘匿を確認しています。PR433で残った文書の指示語とmain試験の名称も訂正し、標準出力と予期しない標準エラーを分けて確認します。
初回のSonnet 5.5/maxレビュー(Must0/Suggestion2/Nit3)を反映し、出力キーの許可セットを厳密に固定しました。他4参照が有無だけのままであること、追加の日時・文字・長さ境界も確認しています。関係するraceテスト1.096秒とmodule vetが成功しました。
最終head
d63234f11dbb36f0d543184eab9ffa121cedd74aの追加差分レビューはMust0/Suggestion0/Nit3。現在の許可リストに重複はなく、残るNitはテスト補助の将来の堅牢性・コメント・文書体裁の提案です。正式CIのWindows/Linux2job・CodeQL4jobも成功しました。元の製品レビューの開始・受入とは別の修復です。Closes #435