Repository navigation
Description
Problem
An approver or admin doesn't see the "Multiple attendees required for this category." violation on another member's expense. The expense creator does see it.
The backend leaves out the report owner when it counts attendees. The client check leaves out the current viewer instead. So when the approver views the expense, the client leaves out the approver, counts the creator as an extra attendee, and hides the violation.
Steps to reproduce
Preconditions: a Control workspace with attendee tracking on, and a category that requires attendees. Invite a member.
- As the member, create an expense in that category. Leave the member as the only attendee.
- As the member, go to Spend > Expenses. The expense shows the attendees violation.
- Log in as the admin or approver, or clear the cache if already logged in.
- Go to Spend > Expenses.
Expected: The member's expense shows the "Multiple attendees required for this category." violation.
Actual: The violation is hidden for the approver.
Reproducible on staging.
| Creator | Approver |
|---|---|
![]() |
![]() |
Root cause
getIsMissingAttendeesViolation takes the viewer's personal details and leaves that person out of the attendee count (AttendeeUtils.ts:71-72).
The violation builder in ViolationsUtils already leaves out the report owner, with the current user as the fallback when the report isn't available (ViolationsUtils.ts:981-995). The two checks disagree whenever the viewer isn't the owner.
These callers pass the current user:
TransactionListItem/index.tsx:213(Spend > Expenses row)ExpenseReportListItem.tsx:204(Spend > Reports row)MoneyRequestView.tsx:811(expense view)ViolationsUtils.ts:594(violation-fixed check)
The confirmation page (useConfirmationValidation.ts) can keep the current user, because there the current user is the creator.
Suggested fix
Have getIsMissingAttendeesViolation and syncMissingAttendeesViolation leave out the report owner's login, like the backend does. Use the current user as the fallback for unreported expenses. Update every caller listed above.
Context
Found during review of Fix false missingAttendees violation in Search rows. See the review analysis and the screenshots.
The same problem was reported earlier in Attendee - Multiple attendee violation only applicable for the owner of the WS, which was closed in January 2026.
Issue Owner
Current Issue Owner: @mallenexpensifyUpwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022113018264415730660
- Upwork Job ID: 2113018264415730660
- Last Price Increase: 2026-10-21
Metadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone


Activity
nkdengineer commentedon Oct 21, 2026
@MelvinBot
Let's update the image in the issue's description to be correct.
MelvinBot commentedon Oct 21, 2026
Done. I updated the Creator / Approver table in the issue description with your screenshots:
merexpense shows "Multiple attendees required for this category."merexpense fromnkde243shows no violation.The rest of the description is unchanged.
view run
MelvinBot commentedon Oct 21, 2026
Proposal
What is the root cause of that problem?
The Spend > Expenses row rechecks the attendees violation on the client. The client check leaves out the viewer when it counts attendees, but the backend leaves out the report owner.
When an approver views the member's expense, the client leaves out the approver. It then counts the creator as a real attendee and decides there's no violation.
syncMissingAttendeesViolationthen removes the backend's violation from the row.Code references
AttendeeUtils.ts:71-78:getIsMissingAttendeesViolationleaves outuserPersonalDetails.login/email, which is always the current user.AttendeeUtils.ts:122-125:syncMissingAttendeesViolationdrops the backend violation when the client check returns false.TransactionListItem/index.tsx:211-220: the row passescurrentUserDetails, even though the owner'ssubmitterLoginis already loaded at line 136.ViolationsUtils.ts:983-994: the client violation builder already leaves out the owner (ownerLoginParam ?? getCurrentUserEmail()), which matches the backend.These callers have the same mismatch but only add violations, so they can miss a client-added violation but can't hide a backend one:
ExpenseReportListItem.tsx:204(owner login:submitterLogin)MoneyRequestView.tsx:810(owner login:iouReportOwnerLogin, line 232)The two creation-flow callers,
useConfirmationValidation.ts:276andViolationsUtils.ts:594(viauseFormErrorManagement), are correct as is, because there the current user is the creator.Fix false missingAttendees violation in Search rows only changed where attendees are read from. It didn't change who gets left out.
What changes do you think we should make in order to solve the problem?
In
AttendeeUtils.ts, changegetIsMissingAttendeesViolationandsyncMissingAttendeesViolationto take the owner's login instead of the current user's personal details. Leave out attendees whoseemailmatches that login, the same wayViolationsUtilsdoes. If no login is available, use the same fallback: assume one attendee is the owner (attendees.length - 1).Pass the report owner's login, falling back to the current user's login for unreported expenses:
TransactionListItem:submitterLogin(this fixes the reported bug)ExpenseReportListItem:submitterLoginMoneyRequestView:iouReportOwnerLoginIn
useConfirmationValidationandgetIsViolationFixed, pass the current user's login. Behavior there doesn't change.Add unit tests in
tests/unit/AttendeeUtilsTest.ts:synckeeps the backend violation.Then update the existing
getIsViolationFixedtests inViolationUtilsTest.tsfor the new argument.What alternative solutions did you explore? (Optional)
Keep the current parameter type and have callers pass
{...currentUserDetails, login: ownerLogin, email: ownerLogin}. This is a smaller diff, but it hides the intent, so changing the parameter is clearer.Related issues and open questions
submitterLoginis undefined. The row then falls back to the current user and the old behavior returns for that row.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/104596)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Oct 21, 2026
Current assignee @nkdengineer is eligible for the External assigner, not assigning anyone new.
[-]Missing attendees violation is hidden when an approver views another member's expense[/-][+][$175] Missing attendees violation is hidden when an approver views another member's expense[/+]26 remaining items
melvin-bot commentedon Nov 7, 2026
melvin-bot commentedon Nov 9, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Nov 9, 2026
Payment Summary
Resolving PRs:
Fix missing attendees violation is hidden #104855
Contributor: @VickyStash does not require payment (Contractor)
Reviewer: @nkdengineer owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
nkdengineer commentedon Nov 12, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: https://github.com/Expensify/App/pull/79050/changes#r4547492545
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Preconditions: a Control workspace with attendee tracking on, and a category that requires attendees. Invite a member.
Do we agree 👍 or 👎
melvin-bot commentedon Nov 12, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Nov 13, 2026
Claude posting on behalf of Matt:
Ready. Job price: $175 (standard, no Help Wanted, assigned 2026-10-21).
No deploy blockers or regressions on the issue or the PR. Next: press Caps+Y, then pay.
Evidence
PAYPREP v1mallenexpensify commentedon Nov 13, 2026
Payment Summary
Contributor+: @nkdengineer due $175 via NewDot