Repository navigation
Deploy Checklist: New Expensify 2023-09-13 #27313
Description
Release Version: 1.3.69-2
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Hide flagged attachment in attachment carousel #24564
- fix: cursor issue starting on left of text #25528
- [No QA] [TS migration] Migrate display.js to TypeScript #25817
- Improve translations - flatten translation objects #25846
- [No QA] [TS Migration] migrate bold to TypeScript #25851
- [No QA] [TS migration] Migrate 'cardStyles' style to TypeScript #25886
- [No QA] [TS Migration] migrate containerComposeStyles style to TypeScript #25920
- [No QA] [TS migration] Migrate 'useThemeStyles.js' style to TypeScript #25946
- fix: change field style colors when input is not editable #25991
- [No QA] [TS Migration] Migrate ThemeStylesProvider component to TypeScript #26060
- Fix/deeplinks when app in background #26073
- [No QA] [TS migration] Migrate 'getComponentDisplayName.js' lib to TypeScript #26080
- [No QA][TS migration] Migrate 'willBlurTextInputOnTapOutside' lib to TypeScript #26107
- Add /workspaces/* path into universal_link #26172
- [No QA] [TS migration] Migrate 'focusTextInputAfterAnimation' lib to TypeScript #26180
- reopen keyboard when tap back on gallery page. #26221
- [NO QA] Feat: Add theme switching HOCs #26276
- [No QA] [TS migration] Migrate 'VisualViewport' lib to TypeScript #26290
- Fix overlay size #26385
- Restrict Plaid link on Native too #26394
- fix(selection-list): focus input on screen focus #26415
- fix image props for web #26452
- Categories UI/UX #26501
- Fix: adds FullPageNotFoundView view for completed task #26634
- [No QA] [TS Migration] migrate GetStyledTextArray to Typescript #26644
- Update en.js: 'Home page' to 'home page' #26671
- [TS migration] Migrate 'getSecureEntryKeyboardType' lib to TypeScript #26673
- Fix: Add avatar details to the Lounge Access Page #26687
- fixed race condition in task creation and onyx #26692
- [No QA] [TS migration] Migrate 'StartupTimer' lib to TypeScript #26771
- [No QA] [TS migration] Migrate 'HapticFeedback' lib to TypeScript #26774
- disable "Didn't receive magic code" while loading #26783
- Implement new layout for SecurityPage #26784
- Fix: 25448 ESC keyboard shortcut shows up in modal on second render on login page #26809
- [TS migration] Migrate 'StringUtils.js' lib to TypeScript #26810
- Disable sequential keyboard navigation to pickers on Safari #26846
- [No QA][TS migration] Migrate 'tryResolveUrlFromApiRoot.js' lib to TypeScript #26855
- Fix: styling of Google Sign In button on Safari #26874
- [TS migration] Migrate 'Tab.js' lib to TypeScript #26932
- [No QA] [TS migration] Migrate 'Growl.js' lib to TypeScript #26933
- [No QA] [TS migration] Migrate 'Network.js' lib to TypeScript #26949
- Update electron-builder to fix semver vulnerabilities #27001
- Add margin left to green dot icon #27008
- [No QA][TS migration] Migrate 'ActiveClients.js' lib to TypeScript #27014
- [No QA][TS migration] Migrate 'Metrics' lib to TypeScript #27022
- [NoQA] Copy category over from expense when Editing a Money Request #27055
- Fix scroll to bottom when number of waypoints increases don't work properly #27076
- Fix: Request Money/Scan: Validation messages are not translated to Spanish #27089
- Update Onyx to use a map for Onyx collection keys #27130
- fix: don't focus on composer when open right modal #27155
- fix DM disappears after open IOU report #27197
- Hide settle button when the request is canceled #27212
- Use correct app icon colour bg for notifications #27213
- Display "Receipt missing details" title when needed #27218
- [CP Staging] Fix OptionRow selection condition #27350
- fix: regressions of flat translations #27358
Deploy Blockers:
- [HOLD for payment 2023-09-21] [HOLD for payment 2023-09-20] Web - Bank account - App crashes when checking ToS checkbox and Continue CTA is not working #27234
- [HOLD for payment 2023-09-21] [HOLD for payment 2023-09-20] web - Pronouns - Unable to deselect pronouns once it is selected #27235
- [$500] [HOLD for payment 2023-09-21] Web - allStates.Greater London.stateName appears on select United state as Country #27325
- Web - App crashes on click of priority mode #27326
- Workspace - Company type dropdown in Adding bank account page (Step 2) is broken #27334
- [$500] [HOLD for payment 2023-09-21] In split bill confirmation page Row stay selected even if we deselect it #27341
- Pronouns - pronoun not translated when language changes #27343
- Category IOU - All the categories are bold #27347
- [HOLD for payment 2023-10-05] [$500] Web - Overlay background colour is different #27353
- [HOLD for payment 2023-10-05] [$500] Category IOU - Two categories are highlighted in the search result when only one is selected #27354
- Home Address - Incorrect input appear in State field when input value than select US country #27366
- Android - Distance - Scrolling doesn't work when the number of waypoints increases #27382
- PR26501 - Category IOU - The recently selected categories do not appear under Recent section #27391
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Sep 13, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.69-0 🚀
kavimuru commentedon Sep 13, 2023
@Julesssss Interim report summary:
Regression TR is only 13% left
#26172 failing with #27345 repro in production
#26415 failing for android #25893
#26501 failing with #27391
#27089 failing with #27389
#27218 blocked with #27328 for native apps
mvtglobally commentedon Sep 14, 2023
@Julesssss Regression is completed
Unchecked PRs
#25846 is failing #27343
#26172 failing with #27345 repro in production. Checking off
#26415 failing for android #25893
#26501 failing with #27391
#26671 is failing #24627, repro in PROD checking off
#27076 is failing #27382
#27089 failing with #27389
#27213 is failing #27145
#27218 blocked with #27328 for native apps
studentofcoding commentedon Sep 14, 2023
Hello guys, I've come from #26172 and want to share some Important Context
#26172 only can be tested after being deployed on production (https://new.expensify.com/) as we discussed with the Internal team on slack discussion here
cc: @kavimuru @mvtglobally
mountiny commentedon Sep 14, 2023
checking #27382 off as its apparently not a blocker.
mountiny commentedon Sep 14, 2023
Checking #25846 off as the regressions have been fixed after a CP
mountiny commentedon Sep 14, 2023
Checking #26415 off as the failing QA is not a blocker
mountiny commentedon Sep 14, 2023
checking #26501 off as that is behind beta and will be worked on by the agency
checking #27076 off as it was repro in production too
checking #27089 off the failing QA seems not to be a blocker
checking off #27213 as not a blocker
checking off #27218 since its backend issue and not only on staging
mountiny commentedon Sep 14, 2023
Left to one CP
Julesssss commentedon Sep 14, 2023
The only remaining change not reverted is simply changing a hex value. Which means that this GH issue already existed on prod for the specific test device OS... explanation
Julesssss commentedon Sep 14, 2023
Latest iOS build failed and will be missing. Being discussed here
mountiny commentedon Sep 14, 2023
Verified the #27350 CP worked, checklist is clear
mountiny commentedon Sep 14, 2023
Codespaces are not a problem for us
New new crashes or some odd things in the graphs
mountiny commentedon Sep 14, 2023