Skip to content

[HOLD for payment 2023-09-27] mWeb/safari- Transition is not smooth when search page opened #27457

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #24316

Action Performed:

  1. Launch the Url and login
  2. Open the search panel

Expected Result:

The transition is smooth

Actual Result:

Transition is not smooth when search page opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.70-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6200598_Search_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Sep 14, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. amyevans commented on Sep 14, 2023

    @amyevans
    Contributor

    Hmm things seem pretty snappy on dev on a sim:

    Screen.Recording.2023-09-14.at.12.53.36.PM.mov

    I'll try to reproduce on staging

  4. amyevans commented on Sep 14, 2023

    @amyevans
    Contributor

    Looks good to me there too:

    RPReplay_Final1694714330.MP4

    @lanitochka17 is this reproducible for you in any account or only a specific one?

  5. lanitochka17 commented on Sep 14, 2023

    @lanitochka17
    Author

    @amyevans This happens only in expensifail account

  6. amyevans commented on Sep 14, 2023

    @amyevans
    Contributor

    Okay thanks! I can reproduce with Expensifail

  7. amyevans commented on Sep 14, 2023

    @amyevans
    Contributor

    Looks like we refactored the Search Page in #23076 which just deployed to staging so that seems like a possible cause (original GH for it: #16251). Mind taking a closer look @Piotrfj?

  8. francoisl commented on Sep 14, 2023

    @francoisl
    Contributor

    Here's a side-by-side comparison between the current main and with #23076 reverted. It looks a little smoother indeed after reverting.

    On `main` With PR 23076 reverted
    main.mov
    revert-23076.mov
  9. amyevans commented on Sep 14, 2023

    @amyevans
    Contributor

    Thanks! We're going to just revert: #27476

  10. amyevans commented on Sep 18, 2023

    @amyevans
    Contributor

    Revert PR is being cherry picked, so closing this out.

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 20, 2023
  12. changed the title [-]mWeb/safari- Transition is not smooth when search page opened[/-] [+][HOLD for payment 2023-09-27] mWeb/safari- Transition is not smooth when search page opened[/+] on Sep 20, 2023
  13. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-27. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions