You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-27] mWeb/safari- Transition is not smooth when search page opened #27457
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Looks like we refactored the Search Page in #23076 which just deployed to staging so that seems like a possible cause (original GH for it: #16251). Mind taking a closer look @Piotrfj?
changed the title [-]mWeb/safari- Transition is not smooth when search page opened[/-][+][HOLD for payment 2023-09-27] mWeb/safari- Transition is not smooth when search page opened[/+]on Sep 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
OSBotify commentedon Sep 14, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to @amyevans (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.amyevans commentedon Sep 14, 2023
Hmm things seem pretty snappy on dev on a sim:
Screen.Recording.2023-09-14.at.12.53.36.PM.mov
I'll try to reproduce on staging
amyevans commentedon Sep 14, 2023
Looks good to me there too:
RPReplay_Final1694714330.MP4
@lanitochka17 is this reproducible for you in any account or only a specific one?
lanitochka17 commentedon Sep 14, 2023
@amyevans This happens only in expensifail account
amyevans commentedon Sep 14, 2023
Okay thanks! I can reproduce with Expensifail
amyevans commentedon Sep 14, 2023
Looks like we refactored the Search Page in #23076 which just deployed to staging so that seems like a possible cause (original GH for it: #16251). Mind taking a closer look @Piotrfj?
francoisl commentedon Sep 14, 2023
Here's a side-by-side comparison between the current
mainand with #23076 reverted. It looks a little smoother indeed after reverting.main.mov
revert-23076.mov
amyevans commentedon Sep 14, 2023
Thanks! We're going to just revert: #27476
amyevans commentedon Sep 18, 2023
Revert PR is being cherry picked, so closing this out.
[-]mWeb/safari- Transition is not smooth when search page opened[/-][+][HOLD for payment 2023-09-27] mWeb/safari- Transition is not smooth when search page opened[/+]melvin-bot commentedon Sep 20, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue: