Repository navigation
Revert "Convert SearchPage to functional component" - #27476
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
thesahindia
and removed request for
a team
September 14, 2023 22:35
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
amyevans
requested review from
AndrewGable
and removed request for
thesahindia
September 14, 2023 22:56
Closed
1 of 6 tasks
robertjchen
approved these changes
Sep 17, 2023
Contributor
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
AndrewGable
approved these changes
Sep 18, 2023
AndrewGable
deleted the
revert-23076-fix/16251-SearchPage-refactoring
branch
September 18, 2023 01:51
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
OSBotify
pushed a commit
that referenced
this pull request
Sep 18, 2023
…hPage-refactoring Revert "Convert SearchPage to functional component" (cherry picked from commit 7876929)
AndrewGable
added a commit
that referenced
this pull request
Sep 18, 2023
…ing-27476-1 🍒 Cherry pick PR #27476 to staging 🍒
Contributor
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.70-6 🚀
|
1 task
Contributor
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀
|
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
May 16, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
May 28, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Jul 12, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Aug 15, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Aug 15, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Aug 15, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Aug 25, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Aug 25, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Aug 25, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Sep 10, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Sep 10, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Sep 10, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Sep 24, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Sep 24, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Sep 29, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Sep 29, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Oct 7, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Oct 7, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Oct 15, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Oct 15, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Oct 24, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Oct 24, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Oct 28, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Oct 28, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Nov 3, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Nov 3, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Nov 10, 2026
…251-SearchPage-refactoring
parag-radadiya
pushed a commit
to parag-radadiya/App
that referenced
this pull request
Nov 10, 2026
…251-SearchPage-refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Straight revert of #23076 + 1 line change to resolve merge conflict
Details
Revert to resolve a deploy blocker
Fixed Issues
$ #27457
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android