Repository navigation
Deploy Checklist: New Expensify 2023-09-22 #28013
Description
Release Version: 1.3.73-1
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Increase VirtualizedList batch size on iOS and Android #19345
- Added recovery code option to 2fa #23390
- Fix Inconsistency in the security page and Request money page #23712
- fix: ensure processing of markup in comment #24319
- Wildan/fix/21518/client pusher method #24407
- Sort group member avatar icons correctly to avoid avatar rearranging upon receiving backend response #25416
- [No QA] Add automated tests for delete money request #26029
- [No QA] Add previousReportActionID to reportAction type #26236
- Fix image loads on resize window #26543
- [Navigation] Make fallback route necessary for Navigation.goBack method #26710
- [No QA] Prevent double translation of hint #26727
- [No QA] [TS migration] Migrate 'Permissions.js' lib to TypeScript #26861
- Disable sticky header on selection list #26934
- Unused styles translation script #26969
- Fix: prevent receiving notification when logging out #26973
- Update policy type definitions and use
areChatRoomsEnabledflag #26982 - Fix: Leaving thread navigates to Concierge page #27127
- Rename receiptFilename to filename #27203
- [No QA] [TS migration] Migrate 'DeviceCapabilities' lib to TypeScript #27314
- [No QA][TS migration] Migrate 'StatusBar' lib to TypeScript #27368
- [No QA][TS migration] Migrate 'Visibility' lib to TypeScript #27437
- use getReportName and getParentNavigationSubtitle from ReportUtils for reports with title or subtitle as empty string for QR code page #27439
- Allow Viewing/Editing a category on a Money Request #27459
- Feat/initial settings page layout change #27468
- Fix: Request money - No autofocus blink cursor shown in Request money page #27475
- [No QA] Add curly option to ESLint config #27505
- [No QA][TS migration] Migrate 'RenameActiveClientsKey.js' lib to TypeScript #27506
- Added a function to validate currency code from route #27550
- style search result can scroll to bottom #27619
- Fix deprecated dark key for lounge access page #27638
- fix: Reimbursements - Track distance: inconsistency in units capitalization #27640
- Fix/27243: Display default pointer in completed task #27643
- Trim currency search #27644
- Fix unavailable workspace display when creating a task #27645
- Fix remove dragover listner when popover hides #27649
- fix: Refocus issue on address field on delete and cancel #27653
- Fix: Flag comment page does not show
Not foundwhen delete thread's first comment #27656 - Fix/26888: New design when adding stop waypoint #27657
- [No QA] [TS migration] Migrate 'Firebase' lib to TypeScript #27661
- fix persist receipt error #27664
- Fix Shows blue color in Bottom Safearea when going offline (via Styling) #27679
- Fix deleted composer message reappears when revisiting the chat #27682
- focus logic update for multiline fields #27702
- Fix console error when zoom avatar with keyboard #27734
- Fix: Adding zoom scale condition to profile image to prevent the App from glitches when opening a smaller profile pic from the user details page #27739
- Fix unread marker of modified messsage #27740
- Fix/27173: Offline deleted workspace allow to open reimburse page #27743
- fix: 26505 Losing focus on the amount input field when switching between apps #27749
- fix: consolidate 'I am a Teacher' and 'Intro to School Principal' pages #27750
- Fix: Money request skeleton is shown when delete IOU in offline mode #27753
- add failure data when edit request money #27758
- [TS migration] Migrate 'BootSplash' lib to TypeScript #24846 #27762
- #26126: Tag picker sections #27765
- Create different files for HTML Render and fix scroll width #27769
- Migrate OnfidoStep.js to a functional component #27784
- [No QA][TS migration] Migrate 'MoveToIndexedDB.js' lib to TypeScript #27795
- #27768: support missing report when requesting money from FAB #27797
- [NoQA] Update docs to add guidelines to auto-focus TextInput #27808
- Update picker to avoid showing svg images on android #27834
- [No QA] Include newest version of eslint-config-expensify with new rule of no-multiple-onyx-in-file #27840
- [No QA] Bump Onyx #27842
- [NO QA] Temporarily pause deployment of helpdot #27845
- [HelpDot] New structure to support platforms #27851
- fix: clear errors when removing waypoint #27859
- fix transition of profiles on request confirmation page #27876
- feat: arrow navigation in context menu #27877
- Docs: ForwardRef convention #27880
- Add yalc to gitignore #27882
- Fix loading overlay header for PrivateNotes page #27911
- fix: hover not shown when scroll on same item #27921
- [No QA] Add curly option to ESLint config for Typescript #27925
- [HelpDot] Show platforms and hubs #27932
- [No QA] add lastFourPAN to Card.ts #27945
- Allow currency search by currency name #27946
- Avoid re-render when no iouReport #27955
- [NoQA] Memoize expensive calls in ReportActionsList renderItem #27957
- [No QA] Add testID to ScreenWrapper #27969
- [No QA] Use displayName for testID #27978
- [CP Staging] Android - App crashes when opening Settings > Wallet #28089
Internal QA:
Deploy Blockers:
- [$500] [HOLD for payment 2023-10-02] No way to create new room even from policyRoom beta enabled account #27094
- [$500] [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] RM - App crashed when tap replace receipt #27903
- [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] Pressing 'Next' while setting up 2FA does not redirect the user #27928
- Web - Login - 'Couldn't retrieve account details' error shows up for new account #28033
- [HOLD for payment 2023-11-06] [$1000] Web - Profile - Atachment clip icon is displayed instead of spinner when avatar is loading #28036
- [$500] Web - Login - Console error shows up after logging in #28042
- [$500] [Awaiting Payment]2FA login - Error message shows incorrect 2FA code when incorrect recovery code is used #28044
- [HOLD for payment 2023-10-05] [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet #28057
- [HOLD for payment 2023-10-13] [$500] mWeb-Conversation-User A in offline typing message, User B is shown "user A is typing" #28063
- IOU Tag - Tag section does not show up in the split confirmation screen #28069
- [HOLD for payment 2023-10-10] [HOLD for payment 2023-10-05] Category - Blank Category RHP appears when navigating to 1:1 IOU details with /edit/category #28079
- [HOLD for payment 2023-10-12] [$500] Request money - Inappropriate Error message show up when going back #28086
- [HOLD for payment 2023-10-13] [$500] Login - Enter key does not submit recovery code #28092
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Sep 22, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.73-0 🚀
mvtglobally commentedon Sep 22, 2023
#27851 & #27932 - PROD QA. Ok to check off?
kavimuru commentedon Sep 24, 2023
Regression TR iOS 17 slots are left
#27765 failing with #28069
#27739 failing with #28054 in mweb
#23390 failing with #28042
#24407 failing with #26136 repro in production . Checking it off
#25416 failing with #28048
#26982 failing with #28046
#27459 failing with #28079
#27619 failing with #27365 (not fixed in mweb and iPhone)
#27739 failing with #28054 reproduced in production, ok to check it off?
#27750 failing with #28084 (As per this #27479 shouldn't be available- ok to check it off?)
#27784 - could you check internally, Our accounts have silver wallet and this PR requires golden wallet with balance
kavimuru commentedon Sep 25, 2023
@thienlnam Regression is completed.
#27765 failing with #28069
#27739 failing with #28054 in mweb
#23390 failing with #28042
#25416 failing with #28048
#26982 failing with #28046
#27459 failing with #28079
#27619 failing with #27365 (not fixed in mweb and iPhone)
#27739 failing with #28054 reproduced in production, ok to check it off?
#27750 failing with #28084 (As per this #27479 shouldn't be available- ok to check it off?)
#27784 - could you check internally, Our accounts have silver wallet and this PR requires golden wallet with balance
thienlnam commentedon Sep 25, 2023
cc @chiragsalian As he is the App deployer this week
Julesssss commentedon Sep 25, 2023
Checking off #28086 as a blocker, it's very low priority.
suneox commentedon Sep 25, 2023
Hi @ntdiary Could you please help me to confirm for an issue #27365 we don't have staging environment for help document?
amyevans commentedon Sep 25, 2023
Checked off #28057 following cherry pick of fix and re-test in staging
ntdiary commentedon Sep 25, 2023
Hi, can someone please help deploy ExpensifyHelp? Verifying PR #27619 requires deploying it, however it seems we stopped deploying it 5 days ago.
0xmiroslav commentedon Sep 25, 2023
@ntdiary no need to worry. It's intentional to prevent deploying help site for HelpDot project.
It will be deployed back from #27988.
mountiny commentedon Sep 25, 2023
Checked of the deploy blockers, some of them were fixed and demoted some as they are not blocking users or not issues in production:
mountiny commentedon Sep 25, 2023
Checking #28089 off, verified internally
mountiny commentedon Sep 25, 2023
checking off:
As these are related to ExpensiHelp page which is normally deployed on main and we can QA it separately and it should not be a staging blocker, this PR will resume it #27988
Checking off #23390 as the found issue was demoted to normal bug
Checking #26982 off as that is behind beta still'
checking #27739 off as the found issues are in production/ not reproducible
checking #27765 off as that is behind beta too
checking #27459 off as that is behind categories beta
#27784 verified internally https://expensify.slack.com/archives/C03TQ48KC/p1695630600830069
Checking #25416 off as the issue found is not a blocker
Checking #27750 as the save the world is not accessible yet
mountiny commentedon Sep 25, 2023
Graphs looking good
No new crashes standing out
mountiny commentedon Sep 25, 2023