Repository navigation
Deploy Checklist: New Expensify 2023-10-20 #30108
Description
Release Version: 1.3.88-11
Compare Changes: production...staging
This release contains changes from the following pull requests:
- forward reportID to ReportActionItemMessageEdit #25951
- Web - App allows user to open request money link of other user and displays amount page twice #26149
- Show red dot on the transaction thread/ iou report row in the LHN and only for the payee #27494
- Update LHN/chat header to handle displayName not being set #27547
- Optimized context usages and set up eslint rule for optimization #28549
- [No QA] [TS migration] Migrate 'ReportActionsUtils.js' lib to TypeScript #28570
- feat: migrate KYCWall class component to functional #28798
- Update Expenses.md #28854
- mWeb: Keep the focus state of the composer when closing three dots menu in report header #28899
- Fix map preview not extended to full view #28922
- [No QA] [TS Migration] Migrate PaymentMethods.js to TypeScript #29074
- fix: money request report scroll fix #29102
- Fix report action context menu stuck when open search page with keyboard shortcut #29152
- fix money request tabs animation #29231
- Refactor: Migrate EmojiPickerMenu Class component to Functional Component #29241
- Fix/28952: Add subtitle to category page #29266
- fix: 29056 Back from request money details page does not open request money page #29268
- [No QA][TS migration] Migrate useCopySelectionHelper #29308
- [NoQA] feat: show next steps for draft reports #29309
- Feat: Remove parseISO #29324
- [CP Staging] Fix send button popover position #29361
- [No QA] [TS migration] Migrate 'TestTool.js' lib to TypeScript #29364
- Update TravelPerk.md #29398
- Fix edit chat converts text to link when making no changes #29418
- Images for Approval Workflows Help SIte #29427
- Create Managing-Employees-and-Reports->-Approval-Workflows.md #29429
- [Internal QA] Add enable wallet state button if the submitter hasn't completed the kyc #29430
- Update Card-Settings.md #29478
- Update Statements help site article.md #29485
- Delete docs/articles/expensify-classic/integrations/travel-integratio… #29516
- Delete docs/articles/expensify-classic/integrations/travel-integratio… #29517
- [No QA] [TS Migration] migrate withNavigation.js to TypeScript #29531
- [No QA] [TS migration] Migrate 'withViewportOffsetTop.js' HOC to TypeScript #29546
- [No QA] [TS migration] Migrate 'withCurrentUserPersonalDetails.js' HOC to TypeScript #29547
- Fix no Paste option menu shows when long pressing a text input #29601
- Close the modal after clicking on three-dot menu item #29653
- Add deep link for send money #29655
- fix: console error on the description push-to-page in the Send money flow #29673
- inserted zero width character for emoji selection prevention #29686
- LHN OptionItem subtitle - If money request total is 0, say 'user owes… #29689
- Rename const from MONEY_REQUEST_TYPE to TYPE #29696
- Login keyboard is not consistent in apps and browsers #29699
- [HelpDot] Add a new hub, and rename hubs #29705
- fix: made the the status emoji selector toggle popover #29716
- fixes the cursor for emoji dropdown button #29722
- fix: Android - Keyboard stays open when getting back to amount input page. #29723
- fix: 29620 Site in Spanish automatically changes to English on signing out #29736
- Fix can't download scan receipt image #29738
- Open the correct report when access sub report page by deep link #29739
- Fix: Large legal name are not saved and no error message is displayed #29740
- fix:28078 Search message shows Invalid email when typing email addres… #29741
- fix iOS receipt border radius is not round #29776
- Revert "Fix navigation breaks on opening search page after reloading the attachment" #29784
- [NoQA] feat: add perf tests to ReportActionsList #29786
- fixed money request button text center issue #29759 #29787
- Fix: Login page loads infinitely when logging in from
Another login page is openpage #29797 - Delete docs/articles/expensify-classic/bank-accounts-and-credit-cards… #29801
- DRY up the code for the backTo param in routes #29813
- [Wave 8- Card Settings] CLEAN UP - Filter out personal cards, fix route to card page, fix card icons #29834
- Update QuickBooks-Time.md #29838
- show loading indicator when policy is loading #29842
- Fix distance waypoint ordering #29843
- [CP Staging] Revert "Remove
withNavigationFallback.jsHOC" #29844 - fix: Chat - Emoji reactions are not being displayed in order of who reacted first #29846
- Fix: navigate to enable-payment page after adding Bank account #29847
- fix: 29850 IOU-Tapping on distance receipt, the receipt thumbnail is missing in the receipt page #29863
- Update Deposit-Accounts-USD.md #29867
- get image from IOU when there is no source in transaction #29873
- Onfido: update the disabled Send button and Sending button style #29874
- Remove and fix some TODOs that exist in the code #29880
- Revert "Feat: Remove moment from datepicker" #29889
- Fix/country not changing from autosuggestion #29890
- fix: IOU - "TBD" is missing in the IOU details of the "Amount" field in offline mode #29892
- revert: from empty string to null #29893
- Add tooltip for long names in the settings page of workspace chat #29894
- Optimize getLastVisibleAction #29897
- fix: show payment options for the settlement button in the report preview #29902
- Update getOptions to exclude selected options on FAB #29903
- categoryFix #29904
- Update @types/semver to fix vulnerabilities #29913
- fix inconsistent text selection of currency selection list #29928
- skip getting personalDetail for 0 accountID #29930
- Optimize shouldReportActionBeVisible #29938
- [TS migration] Migrate 'QRCode' component to TypeScript #29941
- Fix/28379: Remove auto select text search emoji #29949
- Prevent mentions from popping up unexpectadly #29951
- update updateTargetAndMousePosition function #29968
- Fix/button left icon #29974
- fix translate my note es #29980
- Move to Xero.md to expensify-classic hub #29999
- [No QA]Deploy to cloudflare pages on push #30009
- Revert "Update LHN/chat header to handle displayName not being set" #30040
- [CP Staging] Show Wallet Card in Wallet Page if User has Available Balance, Fix Wallet Page BG #30066
- [CP Stag] Prevent crash when login is undefined #30102
- [CP Staging] feat: Improve KYC error handling #30103
- Revert "feat: migrate KYCWall class component to functional" #30110
- [CP Staging] Add handling for undefined route #30141
- [CP Staging] fix: unify the spacing on the money report #30143
- [CP Staging] Fix getBackToParam #30144
- [CP Staging] Fix concierge chat highlight #30145
- [CP Staging] Fix Incorrect onyx key for selected tab #30151
Internal QA:
Deploy Blockers:
- [HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [$500] Concierge not highlights on login #30080
- [HOLD for payment 2023-10-31] Staging is crashing when opening a chat #30109
- [HOLD for payment 2023-10-31] Web - Login - Chat report loads infinitely with /undefined URL when logging in with a new account #30126
- [HOLD for payment 2023-10-31] Address - 'Hmm it's not here' page shows up when selecting a country #30128
- IOU - Total with amount line is misaligned in IOU report page #30129
- [HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] IOU - Bank account and Debit card modal appears on the left of Pay with Expensify button #30130
- [HOLD] [LOW] [Splits] IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash #30140
- [$500] [HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] Web - Drag and drop feature works on Scan and Distance request money #30148
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
francoisl commentedon Oct 20, 2023
There are dupes from the last deploy again, going to check them
Edit: done
Dupes
OSBotify commentedon Oct 20, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.88-0 🚀
kavimuru commentedon Oct 20, 2023
Checking off these PRs from the past Buid
#29601
#29844
#29863
#29873
#29889
francoisl commentedon Oct 21, 2023
Checking off blocker 30109, fix tested on staging.
kavimuru commentedon Oct 21, 2023
Regression 34% progress.
#29890 failing with #30128
#29893 failing with #30126
kavimuru commentedon Oct 22, 2023
Regression completed.
#29890 failing with #30128
#29893 failing with #30126
#27547 failing with #30125
mountiny commentedon Oct 22, 2023
Checking off #29890 as its fixed
Checking #29893 off, did not see nay console errors now
Checking #27547 off should have been noQA
luacmartins commentedon Oct 22, 2023
Checking off #30148. Merged and CPed a fix
luacmartins commentedon Oct 22, 2023
Checking off #30066, tests passed
luacmartins commentedon Oct 22, 2023
Checking #30151, tests passed
kevinksullivan commentedon Oct 23, 2023
checking #30103, tests passed
chiragsalian commentedon Oct 23, 2023