Repository navigation
Deploy Checklist: New Expensify 2023-11-02 #30752
Description
Release Version: 1.3.95-9
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [TS migration] Migrate 'SelectionScraper' lib to TypeScript #27796
- Add https to webpack dev server #28422
- Fix/28098: Clicking back button bring back the workspace #28573
- [No QA] [TS migration] Migrate 'Environment' lib to TypeScript #28600
- Fix receipt image is opened in transaction thread report #28640
- fixed offline jumping behaviour #29045
- Update Auto-Reconciliation.md to add image/screenshot placeholder #29140
- [No QA] [TS migration] Migrate 'useArrowKeyFocusManager.js' hook to TypeScript #29328
- [TS migration] Migrate 'withPolicy.js' HOC to TypeScript #29554
- Add README section on how to add certificate to simulators #29754
- [NO QA][TS migration] Migrate 'RenderHTML.js' component to TypeScript #29756
- Update composer number of lines when window width changes #29845
- 27456 Chat - The green line is displayed chaotically at the recipient #29860
- Rename shouldDisableWriteActions to canUserPerformWriteAction #29887
- [No QA] [TS Migration] migrate KeyboardAvoidingView.js to TypeScript #29955
- [Form Provider Refactor] AddDebitCardPage #29983
- Reopened/Feature: Remove moment from datepicker #29984
- [Form Provider Refactor] NewTaskDescriptionPage #30061
- Fix 17866: After pressing the back arrow to "Send/Request money" screen, the keyboard flashes #30065
- Fix - mWeb/Safari- Chat - After tapping on "Copy to clipboard", options menu does not close #28820 #30085
- fix: console error old-dot to new-dot new workspace transition #30115
- [Form Provider Refactor] NewTaskTitlePage #30167
- fix: Settings - Long email address appears differently between Android native and mWeb #30173
- enable maxHeight to avoid keyboard overlapping the save button #30238
- perf: improve performance when opening Search with cmd+k #30263
- Design follow up to Tag and Category lists #30264
- fixed auto submit form when enter key pressed in selection modals #30300
- Update CONTRIBUTING.md #30320
- fix show name on tooltip member page #30322
- Fix/29812: Same page has different error text color for different errors #30325
- Update LHN/chat header to handle displayName not being set - MR participants list fix #30342
- [Form Provider Refactor] EditRequestDescriptionPage #30382
- Amount in the Distance e-receipt is cut off when device font size is minimum #30401
- Fix bug when editing any IOU information the date is automatically reduced by one #30410
- [NoQA] feat: add Reassure perf tests to ReportScreen #30414
- [Form Provider Refactor] MoneyRequestDescriptionPage #30419
- Fix/29854 #30429
- Fix: Wallet - Once after login, debit card page exits without open #30433
- Focus on the first item of the selection list when user changes the search input #30438
- [TS migration] Migrate 'SplashScreenHider' component to TypeScript #30439
- [Form Provider Refactor] IntroSchoolPrincipalPage #30444
- Fix pressing the task report (with assignee) header opens the assignee profile page #30452
- Fix skeleton animation on web #30458
- Add server-side report searching for task destination and money requests #30471
- Update Lounge Access page #30473
- Fix: FAB - New workspace option disappears from FAB in offline mode #30475
- Fix selection includes SVG style and data-testid value #30476
- Generate error when request money failure #30477
- Fix: Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown #30478
- Category-Long category is truncated although space available #30479
- [NoQA] test(reassure): get last visible action #30482
- fix: don't focus composer if emoji picker is opened #30483
- [NoQA] [DEV] E2e/increase reliability #30484
- fix: set null to unread marker when there are no new messages #30485
- fix: offline indicator inside a keyboard avoiding view #30491
- description/comment to string #30526
- [HelpDot] Style markdown tables #30530
- Update "Remaining spending power" to "Remaining limit" #30542
- [CP Staging] input of '[' and other special characters fixed #30559
- [NoQA] [DEV] Prevent babel from failing when CAPTURE_METRICS true #30566
- Remove openreport api calls while switching windows #30572
- rename lastFourDigits to cardLastFourDigits for API call #30573
- [NO QA] Remove unnecessary screenshot/videos section from issue template #30574
- BA icon style fix #30589
- Fix user display name is changed to their login after doing a money request #30591
- Migrate MacOS desktop to use
notarytoolto notarize #30599 - Rodrigo fix shortcut bindings #30602
- [No QA] Clean up for added by secondary login messages #30604
- Parsing the welcome message into html in the create new room action #30609
- Add a basic sitemap #30612
- [No QA] Fix ncc builds #30614
- [NoQA] Add sleep cooldowns to e2e tests #30635
- fix clipboard in report utils #30640
- Fix incorrect command name for RevealDetails button #30647
- [No QA] Delete docs/articles/expensify-classic/expensify-card/CPA-Card.md #30651
- Feat: Update how GBR is determined for IOU/expense reports #30655
- Remove CPA Card mention in sign in page footer #30656
- Fix/29228: Task needs revisit to update members #30671
- [No QA] Update footer.html #30709
- Delete docs/articles/expensify-classic/send-payments/Pay-Invoices.md #30710
- Default to true to make type happy #30731
- Update CONTRIBUTING.md #30736
- [CP Staging] Fix issue where displayed selected date is a day before actually selected date #30810
- [CP Staging] Fix there is no assign task option on a task report #30816
- [CP Staging] fix regression copy to clipboard #30818
- [CP Staging] fix: Green dot for money request is still displayed in spite of having deleted the workspace #30830
- [CP Staging] fix: use parseISO instead od Date #30845
- Show displayName in IOU if the primary actor is a workspace #30862
- [CP Stag] fix an issue with min height of screen when Offline Indicator is shown #30887
- Fix/30848: Reset hasOutstandingChildRequest to false after paying money #30918
- feat: replace more dates by parseISO #30923
Internal QA:
Deploy Blockers:
- [Wave 6: Workspace Chats] GBR shown on chats that shouldn't have them #30775
- Focus mode showing tons of unread reports that I have no idea why are there #30781
- [HOLD for payment 2023-11-13] [$500] Bank - Calendar Is broken in Bank account flow #30792
- [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-13] Expense - Copy to clipboard option for system message for paid expense crashes the app #30796
- [HOLD #30668] [$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages #30798
- [HOLD for payment 2023-11-13] Assign task – Unable to assign subtask in task report when create task in 1:1 DM. #30804
- [HOLD for payment 2023-11-13] Request Money - Selected date is correct but another one is highlighted #30807
- [HOLD for payment 2023-11-13] [$500] LHN - Green dot for money request is still displayed in spite of having deleted the workspace #30824
- iOS - IOU - Save button and offline message in Edit Amount page overlaps with navigation bar #30840
- [HOLD for payment 2023-11-13] Expense - Workspace avatar and name change after creating a workspace expense #30846
- Chat - Tooltip for WS avatar is broken #30847
- [HOLD for payment 2023-11-13] [$500] IOU - Green dot in 1:1 DM in LHN does not disappear after paying the IOU offline #30848
- iOS - Request money - Green CTA button in BNP and confirmation page has different placement #30861
- [HOLD for payment 2023-11-13] Android - Bank - After opening calendar for incorporation date day that comes before is selected #30871
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Nov 2, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.95-0 🚀
kavimuru commentedon Nov 2, 2023
Checking off the PRs from the past builds
#27796
#28422
#28573
#28640
#29045
#29554
#29754
#29860
#29887
#29983
#30061
#30085
#30115
#30167
#30173
#30238
#30264
#30300
#30325
#30382
#30410
#30419
#30429
#30433
#30438
#30439
#30444
#30452
#30458
#30471
#30473
#30475
#30476
#30477
#30479
#30483
#30485
#30491
#30526
#30530
#30542
#30559
#30572
#30573
#30589
#30599
#30602
#30612
#30647
kavimuru commentedon Nov 2, 2023
Regression at 34% progress.
#29984 failing with #30807
#30342 failing with KI #30125 (Ok to check it off)
jasperhuangg commentedon Nov 3, 2023
Checking off #30807 was fixed by #30810
Beamanator commentedon Nov 3, 2023
Multiple people agreed #30781 is not a blocker, it might not even be an issue, so checking it off
Beamanator commentedon Nov 3, 2023
@kavimuru are you able to retest the following issues, to see if they're still bugs on staging?
kavimuru commentedon Nov 3, 2023
@Beamanator We will retest and update you shortly.
kavimuru commentedon Nov 3, 2023
Regression is down to 3%. Cps are done.
Beamanator commentedon Nov 3, 2023
Thanks @kavimuru ! So CPs above were tested & none are still occurring? 🙏 If so, I'll check them all off the list & remove the Deploy Blockers from those issues 👍
kavimuru commentedon Nov 3, 2023
@Beamanator They were all pass and checked off.
Beamanator commentedon Nov 3, 2023
Sweet, checked off the deploy blockers 👍 that's about all i can get to today, there's a few other blockers that had fixes CP'd (example) so the next deployer will have to look into these next week!
puneetlath commentedon Nov 3, 2023
#30019 did not pass, but we don't need to block the deploy over it.
kavimuru commentedon Nov 3, 2023
Regression completed.
Unchecked PRs:
#29984 failing with #30807
#30342 failing with KI #30125 (Ok to check it off?)
Open Blockers:
#30792
#30798
#30840
#30846
#30848
#30861
#30871
puneetlath commentedon Nov 6, 2023
Checking off #30798 as we decided it's not a deploy blocker.
puneetlath commentedon Nov 6, 2023
Checking off #29984 since a fix was CP'd
puneetlath commentedon Nov 6, 2023
Going to go ahead and check off #30342 since this can't really be tested.
puneetlath commentedon Nov 6, 2023
#30846 is fixed. Checking it off.
puneetlath commentedon Nov 6, 2023
#30861 is fixed. Checking it off.
puneetlath commentedon Nov 6, 2023
#30840 is fixed. Checking it off.
puneetlath commentedon Nov 6, 2023
#30848 is fixed. Checking it off.
puneetlath commentedon Nov 6, 2023
#30871 is fixed. Checking it off.
puneetlath commentedon Nov 6, 2023