[$250] Thread – Unable to leave thread in a task detail.

@akinwale

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.5-3

Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4700550
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Log in
Open any chat
Send a message
Right click on the message and select Reply in thread
Send a message in a thread
Click on the header

Expected Result:

Leave thread option is present in a task detail

Actual Result:

Leave thread option is missing in a task detail

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6535884_1720445500918.Leave_thread.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0186cdebe249073b07
Upwork Job ID: 1810358159239707374
Last Price Increase: 2024-07-08
Automatic offers:

akinwale | Reviewer | 103047193

Issue Owner

Current Issue Owner: @akinwale

@puneetlath

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@abekkala

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no option to leave thread in report details page.

What is the root cause of that problem?

The condition of showing the leave button requires the report to not be a thread.

App/src/pages/ReportDetailsPage.tsx

Lines 243 to 244 in e0ccba5

    
           const shouldShowLeaveButton = 
        
               !isThread && (isGroupChat || (isChatRoom && ReportUtils.canLeaveChat(report, policy)) || (isPolicyExpenseChat && !report.isOwnPolicyExpenseChat && !isPolicyAdmin));

Previously, we had a 3-dot button that shows the leave option for the thread, but now it's removed, but the leave button condition isn't updated yet.

What changes do you think we should make in order to solve the problem?

I propose that we just use ReportUtils.canLeaveChat function to check whether we can leave a report or not. Then, we can move the other current conditions to canLeaveChat.

const shouldShowLeaveButton = ReportUtils.canLeaveChat(report, policy)

function canLeaveChat(report: OnyxEntry<Report>, policy: OnyxEntry<Policy>): boolean {
    if (isGroupChat) return true;
    if (isPolicyExpenseChat && !report.isOwnPolicyExpenseChat && !isPolicyAdmin) return true;
    ...

Last, we need to update the leaveChat logic so that leaving a thread will call leaveRoom instead of leaveGroupChat.

App/src/pages/ReportDetailsPage.tsx

Lines 224 to 232 in e0ccba5

    
           const leaveChat = useCallback(() => { 
        
               Navigation.dismissModal(); 
        
               if (isChatRoom) { 
        
                   const isWorkspaceMemberLeavingWorkspaceRoom = (report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED || isPolicyExpenseChat) && isPolicyEmployee; 
        
                   Report.leaveRoom(report.reportID, isWorkspaceMemberLeavingWorkspaceRoom); 
        
                   return; 
        
               } 
        
               Report.leaveGroupChat(report.reportID); 
        
           }, [isChatRoom, isPolicyEmployee, isPolicyExpenseChat, report.reportID, report.visibility]);

We can do that by switching the check.

if (isGroupChat) {
    leaveGroupChat()
    return;
}
leaveRoom()

Sounds good. I like consolidating the logic into ReportUtils.canLeaveChat.

@akinwale

PR is ready

cc: @akinwale

@akinwale

waiting on PR Review @akinwale

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

deployed to production Jul 23

@akinwale

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:

[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

This was a regression from #44252.

[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

[@akinwale] Determine if we should create a regression test for this bug.

[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Launch Expensify
Open a chat report
Send a message
Reply in the thread of the message that was sent
Click or tap on the chat header
Verify that the Leave option is displayed in the menu

Do we agree 👍 or 👎?

@bernhardoj

PAYMENT SUMMARY FOR JULY 30

Fix: @bernhardoj [$250] payment via New Dot
PR Review: @akinwale [$250] Offer

@akinwale

@akinwale payment sent and contract ended - thank you!

Requested in ND.

@bernhardoj

$250 approved for @bernhardoj

Navigation Menu

Repository navigation

[$250] Thread – Unable to leave thread in a task detail. #44964

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

16 remaining items

PAYMENT SUMMARY FOR JULY 30

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const shouldShowLeaveButton =
	!isThread && (isGroupChat \|\| (isChatRoom && ReportUtils.canLeaveChat(report, policy)) \|\| (isPolicyExpenseChat && !report.isOwnPolicyExpenseChat && !isPolicyAdmin));

	const leaveChat = useCallback(() => {
	Navigation.dismissModal();
	if (isChatRoom) {
	const isWorkspaceMemberLeavingWorkspaceRoom = (report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED \|\| isPolicyExpenseChat) && isPolicyEmployee;
	Report.leaveRoom(report.reportID, isWorkspaceMemberLeavingWorkspaceRoom);
	return;
	}
	Report.leaveGroupChat(report.reportID);
	}, [isChatRoom, isPolicyEmployee, isPolicyExpenseChat, report.reportID, report.visibility]);

[$250] Thread – Unable to leave thread in a task detail. #44964

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 8, 2024

melvin-bot commented on Jul 8, 2024

github-actions commented on Jul 8, 2024

m-natarajan commented on Jul 8, 2024

m-natarajan commented on Jul 8, 2024

bernhardoj commented on Jul 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

16 remaining items

puneetlath commented on Jul 9, 2024

bernhardoj commented on Jul 10, 2024

abekkala commented on Jul 11, 2024

melvin-bot commented on Jul 22, 2024

melvin-bot commented on Jul 22, 2024

abekkala commented on Jul 24, 2024

akinwale commented on Jul 30, 2024

abekkala commented on Jul 30, 2024

PAYMENT SUMMARY FOR JULY 30

abekkala commented on Jul 30, 2024

bernhardoj commented on Jul 30, 2024

JmillsExpensify commented on Jul 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions