Repository navigation
Deploy Checklist: New Expensify 2021-08-25 #4828
Description
Release Version: 1.0.90-2
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Add offline message to IOU and Split bill and allow currency selection while offline #4019
- [CP Staging] Remove duplicate form fields #4117
- fix: paste and Ctrl+z #4131
- Modify line height so text does not get cut off in LHN #4143
- Make sure we get state/status from the right variable name when we get chat report name #4239
- Web - Settings - Dropdown symbol overlaps with text in the box #4243
- Fix staging due to undefined Onyx key #4286
- Fix broken list components on staging #4300
- Patch for PR #4190 #4322
- Update getPullRequestsMergedBetween to run pre-set string command #4336
- Update XCode to fix iOS deploy #4339
- Fix User is able to upload a file larger than 50mb #4358
- Fix: Selecting a language does not update in real time #4366
- Fix: Infinite loader on login #4397
- add autofocus #4402
- Ping ApplauseLeads when PRs get CPed #4414
- Attempt at fixing race #4416
- Race fix attempt 2 #4436
- fix: message alignment #4503
- Allow users to login with validate code and be redirected to Workspace/Card modal #4519
- Fix the text style in about page #4522
- [No QA] Make a dummy change for a test PR #4568
- Fix ExpensiInput autoFocus & tab Focus #4593
- Hide Password mismatch incase both the passwords are empty #4607
- Check for value before checking length #4613
- Clear storage immediately on sign out #4614
- Fix: autofill on the BaseExpensiInput #4632
- Update state picker component in VBA flow #4633
- Changed Personal and Company Address Labels #4636
- Add Guides call request flow to workspace card configuration screen #4637
- Change picker value color #4641
- update copy for login #4644
- don't show user while searching #4647
- Hide automated accounts from Recent sections of Split Money/Request Money #4648
- Multiline for ExpensiTextInput #4649
- Added tooltips to all Icon buttons #4661
- Update withOnyx to fix prop dependent key updates #4676
- [CP Staging] Use props not state in NewPasswordForm #4684
- Fix context-menu on native devices #4687
- Add capatilisation to translation & some margin for the input #4688
- Search label removed, added no results found instead #4689
- select default/local currency #4691
- [No QA] Make Firebase traces an opt-in feature of global Timing class #4697
- Bump Onyx version to fix recent regressions #4706
- Only trigger deploy blocker notifications on issues #4707
- Exclude cards that are not activated #4720
- Fix enable payments page with another Onyx update #4721
- [NO QA] Document why we pass the
currentDatebut we don't use it #4724 - [NO QA] Update the PR template to enforce issue linking formatting #4725
- Change UI view for Attachments in Chat #4736
- Increase to 5 seconds #4740
- Handle errorText in TextInputWithLabel #4741
- Display the /bank-account/requestor page #4742
- Bumped expensify-common(Supports nested markdown links) #4750
- Update CONTRIBUTING.md #4751
- Hide localtime for Expensify Emails (Automated Accounts) #4755
- [No QA] Post deploy announcements in slack #4757
- [No QA] Performance tracking with flipper-plugin-performance #4760
- Fix StagingDeployBlocker where chat draft message is kept in the test input while switching chats #4761
- Added translations for CompanyStep #4765
- [No QA] Tag mobile deployers instead of @here in #announce for deploy failures #4767
- Refactor the componentDidUpdate method for ReportActionCompose #4768
- Web - Attachments Preview_3901 #4769
- Fix MarkerBadge Count #4773
- Fix: marker is not clickable on android #4774
- Added translations for "edited" label in chats #4776
- call debounce only when it's required #4777
- Block system user from Inviting into Workspace #4781
- Reduced emoji spacing and increased emoji size #4782
- Update height of default buttons to to match the text inputs #4792
- New breakpoint for tablet size #4793
- Fix: IOU - Final review modal design #4795
- Update NewDot deploy permissions. #4796
- Update StagingDeployCash for manual cherry-picks #4798
- #4517 update timezone on user activity #4799
- [No QA] Fix regression on web due to #4760 #4800
- Fix Web Safari Signin page layout #4802
- Remove expensifySMS domain from the request IOU page #4803
- Update fastlane version #4804
- Bank account load animation issue #4696 #4805
- Add missing period to preferences page #4806
- Remove unnecessary style causing bug in android #4807
- fix Locale Picker and small picker styles #4810
- Revert "Update StagingDeployCash for manual cherry-picks" #4815
- Fixed tooltip pointer in left/right-aligned tooltips #4820
- Fix owner to fix 404 when trying to comment #4824
- [No QA] Announce CP failures in the #announce Slack channel #4829
- Fix syntax error in GitHub action expression #4833
- Trim long workspace name #4835
- Styles h3/h4 missing bold fixed for web, desktop, iOS #4839
- Fixed icon alignment on ReportComposeAction #4851
- Stop automatically creating a workspace when landing on an invalid url #4852
- Update capitalization of copy to match new guidelines #4854
- Remove onSubmitEditing if submit button disabled #4858
- Update the HTML entity parsing #4859
- Fix autocomplete issue in VBA flow #4862
- fix count when LHN is open on mobile #4865
- Download Filename and Tooltip to Download #4871
- Fix notification preference selector label #4872
- Prioritize reports with draft comments in the Most Recent priority mode #4873
- Remove Growl from VBA flow, for non-server errors #4875
- Ensure Requestor Info validation shows error growl #4879
- Password Error message Translation on Language change #4880
- Prevent errorAttemptsCount from being wiped out by JSON.stringify #4889
- Update CONTRIBUTING.md #4893
- Hopefully fix persistent splash screen #4895
- Fixed alignment issue for Workspace name #4901
- remove sms domain from login #4907
- dlt the comment when it's empty #4909
- Add string comparison to boolean expressions #4915
- Revert regex changes for
comment #4917 - Remove redundant placeholder for login form #4918
- Add icons to buttons, fix inboxcallbutton text size #4919
- Link Workspace ID to reimbursement account setup so it is accessible during validation step #4923
- [No QA] Use pretext in chrerry pick workflow to tag mobile-deployers #4925
- Properly JSON-decode outputs #4927
- Make dummy change in README #4931
- Make dummy change #4934
- [No QA] Use fromJSON in platformDeploy.yml #4940
- Workspace Admin Translation fix, few es copy changes #4954
- Grab iOS version from release event #4957
- Allow builds to distribute to external testers #4961
- Remove internationalization beta #4967
Deploy Blockers:
- [Apple rejecting release] Investigate splash screen issue with apple test credentials #4608
- Android - Left half of the new message badge is unresponsive #4716
- [HOLD for payment 2021-09-28] If you mark a message as unread and close the app or minimize it, the unread status is removed. #4855
- Chat - Incorrect number of new messages are shown in green marker badge count #4863
- Download file doesn't have the same name as preview #4868
- Chat - Clicking on download does not show same filename as in the preview #4869
- Chat - Additional lines are shown when editing a text with markdown type Quote #4898
- Login form - No option to change the password in login and password entry form #4958
cc @Expensify/applauseleads
Activity
isagoico commentedon Aug 25, 2021
Checking off these PRs that were incorrectly added to the list:
isagoico commentedon Aug 25, 2021
Starting QA 🚀
isagoico commentedon Aug 26, 2021
Another batch of PRs that were incorrectly added:
roryabraham commentedon Aug 26, 2021
Removing the lock label to fix staging deploys
isagoico commentedon Aug 26, 2021
Everything was a pass here 🎉 https://github.com/Expensify/App/actions/runs/1168597268
Only thing is that I still don't see the "Deployed to staging" messages, can we ignore that and start QA? CC @roryabraham
roryabraham commentedon Aug 26, 2021
Yes, those will not appear because of the bug that existed when we ran the prod deploy. Ignore and begin QA please.
isagoico commentedon Aug 26, 2021
Starting QA 🚀
isagoico commentedon Aug 26, 2021
These PRs are missing QA steps:
isagoico commentedon Aug 27, 2021
Regression is finished!
Issues found:
Comments left in PRs:
Going to test this once all PRs and deploy blockers are checked off #4824
isagoico commentedon Aug 27, 2021
#4793 (comment) Resolved - Checking it off
24 remaining items
roryabraham commentedon Aug 31, 2021
Trying that one more time after merging #4940
roryabraham commentedon Aug 31, 2021
Okay, staging deploy for
v1.0.90-0is running here. Once that's done, feel free to begin QA (regression + testing unchecked PRs).isagoico commentedon Aug 31, 2021
Starting QA!
isagoico commentedon Aug 31, 2021
CP issue is back, Checking off:
isagoico commentedon Aug 31, 2021
We're almost finished with QA, all PRs have been tested and I already updated the checklist with the results.
These 2 PRs have unresolved comments:
#4880 is failing because of #4958 (It's currently being fixed 🎉)
On regression, we haven't found any issues or deploy blocker yet. Still about 25% left in the TestRail.
CC @roryabraham
roryabraham commentedon Sep 1, 2021
Please retest #4880 / #4958 in version
1.0.90-2, being deployed hereisagoico commentedon Sep 1, 2021
Checking off #4880 since it's a pass 🎉
roryabraham commentedon Sep 1, 2021
@TomatoToaster is going to QA #4923 internally, but since it's still hidden behind a beta, I'm not going to block the production deploy on it. So I'm going to go ahead and check it off on the checklist and run a prod deploy.
isagoico commentedon Sep 1, 2021
@roryabraham We're about to finish the regression testing, only 10% left, should be done in a little bit.
isagoico commentedon Sep 1, 2021
It's finished! feel free to trigger the Prod deploy 🎉 (no deploy blocker were found!)
TomatoToaster commentedon Sep 1, 2021
Just noting that this one is QA'ed and passed too: #4923 (comment)
roryabraham commentedon Sep 1, 2021