Repository navigation
Deploy Checklist: New Expensify 2024-11-21 #52862
Description
Release Version: 9.0.65-5
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [NoQA] Tests for group chat name #46661
- fix: deleted workspace with invoices is accessible by url #49509
- Feat: Implement to use a 👍icon next to approved report preview #50387
- fix: Room - Create room whisper reappears when interacting with it after workspace is deleted. #50692
- fix: show video control when video ended #51218
- fix: sorted suggestion emoji #51220
- fix: Update second Allow location access modal on web #51709
- Fixing duplicate Concierge chat #51794
- [No QA] Change guidelines to forbid defaulting values #52094
- [No QA] Console cleanup pt.1 #52187
- fix:
ValidateCodeActionModalis not dismissed on backdrop press #52232 - Fix fullscreen video controls difficult to click #52302
- fix navigation to annouce room #52349
- Open switch to expensify classic on the same tab for web #52352
- Feat: Add account validation step to Invoices page #52356
- feat: Step 4 UI #52384
- fix: Web - Chat - Error message not translated when changing language #52435
- fix: The shortcut CTRL + K does not work with a user as employee in a WS #52448
- Enable/disable option shows rates text in plural instead rate #52465
- Create a Pay an Expense help article and update the header on the existing Pay an Invoice article #52520
- Update: Default / Custom Workspace Invite Behavior #52524
- fix: prevent open search on onboarding route #52534
- Fix: User not scrolled to top of chats list when scrolling down and deleting search #52606
- fix category menu still presents while the list is empty #52608
- Hide search input caret while search modal is animating #52659
- Docs updates 2 #52662
- Fix lhn list only shows 1 item when going back after create new ws from FAB #52675
- Fix text link style is not applied in code block #52680
- [NOQA] chore(perf): start reporting the sidebar_loaded event #52709
- Remove "Let's get you set up 🔧 " line during onboarding #52728
- Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroid feature flag #52732
- PATCH: Android - Fix caret resetting to the beginning of the input #52734
- fix: username, last 4 and limit amount are not aligned on the same line #52743
- [NoQA] bump onyx version to 2.0.81 #52767
- Fix - Ellipsis color shown in wrong color in Expense Report details #52779
- Fix: Track Expense Options are still present in thread details after the expense is deleted #52786
- Update Netsuite-Troubleshooting.md #52796
- [No QA]Change path to iOS and Android fastlane keys to fix production builds #52797
- [No QA] remove cachedTotal key #52806
- Accounting task instruction update #52808
- Update es.ts #52839
- fix: new member shows fallback avatar in report invite page #52844
- [No QA] Update es.ts #52846
- [CP Staging] fix: Search - Website crashes after exploring expenses in search for some time. #52888
- [CP Staging] Revert "Feat: Implement to use a 👍icon next to approved report preview" #52901
- [CP Staging] Fixes unread indicator #52919
- [NO QA] [CP STAGING] Minor formatting change -- used to bump HybridApp build #52962
Internal QA:
- Fix submit expense on internal Expensify policy #52794 - @mountiny
- [Internal QA]: Show card name instead of Bank for Company cards search #52625 - @mountiny
- [Internal QA]: Add a loader to the cards page while waiting for cards collection and feed settings #52615 - @mountiny
- [Company Cards] Update the Amex cards format #52578 - @mountiny
Deploy Blockers:
- [HOLD for payment 2024-12-03] [HOLD for payment 2024-11-29] Search - Website crashes after exploring expenses in search for some time #52864
- [$250] Chat - Specific "not found page" link crashes the app #52866
- Group - Website crashes when leaving group chat #52868
- Workspace - Custom invite message remains when invite other members #52869
- mWeb-chat-The text and code block box is smaller in staging #52870
- Android - Expense - Nothing happens after approving expense and tapping dropdown button #52873
- Hybrid - Launch - App is reloaded everytime that it´s backgrounded and opened again. #52874
- Workspace-App crashes on back navigation from new workspace #52875
- [$250] Expense - Submit button is missing after switching layout from mobile to web #52883
- Report - App crashes when trying to open unloaded paid distance expenses #52889
- [HOLD for payment 2024-12-03] [HOLD for payment 2024-11-29] Chat - No green line when click New message from top of the chat #52891
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Nov 21, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.65-0 🚀
izarutskaya commentedon Nov 21, 2024
Regression is at 44% completed.
Unchecked PRs:
#52844 - Failing in Desktop and iOS with original KI #52639
Blockers:
#52864
#52866
#52868
#52869
lakchote commentedon Nov 21, 2024
Checked off #52870 (comment)
mountiny commentedon Nov 21, 2024
Checking off #52794 as the QA worked ✅
mvtglobally commentedon Nov 21, 2024
Regression is at 20% left.
Majority of the testers still unable to get the latest IOS build. We are working on the IOS slots
mvtglobally commentedon Nov 21, 2024
Regression is at 10% left.
Blockers
#52864
#52868
#52873
#52874
#52891
PRs
#52384 - Can this be QAed internally?
mvtglobally commentedon Nov 22, 2024
Regression is at 4% left.
Blockers
#52864
#52868
#52873
#52874
#52891
PRs
#51709 - Pending validation on Desktop
#52384 - Can this be QAed internally? We are not able to add non-US bank account
#52435 - Pending validation on IOS
#52520 - PROD QA, checking off
#52662 - QA Steps are missing. Can we check it off?
#52779 - Pending validation on IOS
#52844 - Failing with #52639
#52888 - Pending validation on IOS, Android and Desktop
#52919 - Pending validation on IOS, Android and Desktop
mjasikowski commentedon Nov 22, 2024
#52873 reverted and CP'd
gijoe0295 commentedon Nov 22, 2024
@mvtglobally Can you add recordings here on #52844 failing? We tested ourselves and it worked well.
izarutskaya commentedon Nov 22, 2024
Regression is completed.
PRs:
#51709 - KI Desktop only #49571
#52384 - Can this be QAed internally?
#52844 - Failing with original KI #52639
Blockers
#52864
#52868
#52874
#52891
izarutskaya commentedon Nov 22, 2024
Hi @gijoe0295
#52844
Desktop
1732161996161.PR_52639__Desktop.mp4
iOS
1732160272060.52844_iOS.mp4
gijoe0295 commentedon Nov 22, 2024
@izarutskaya As discussed in #52639 (comment), if you search an INEXISTING account, it would show the fallback avatar so your attached videos are expected.
To test #52639 correctly, you need to use an EXISTING account that the current user hasn't chatted with before. Sorry for the confusion. I'll update the PR's QA Steps accordingly.
cc @deetergp @brunovjk
izarutskaya commentedon Nov 22, 2024
@gijoe0295 I have this behavior in my iOS. Still show the fallback avatar for my EXISTING account. This is my old account (izarutskachat1@gmail.com)
Build 9.0.65-4 Maybe something wrong?
Rpreplay.Final1732279927.mp4
gijoe0295 commentedon Nov 22, 2024
@izarutskaya I think it's due to the capitalized
Iat the beginning. Only happen on iOS because it automatically capitalizes the first character. TheSearchForReportsAPI is case-sensitive soizarutskachat1andIzarutskachat1(capitali) are different. The correct result is returned if you searched for the exact email (izarutskachat1@gmail.com).This problem also happens in the Start chat flow (and all other search flows) so I think it's not related to our PR and we can either ignore it or create a separate issue to fix it.
cc @brunovjk @deetergp WDYT?
rlinoz commentedon Nov 22, 2024
Checking off #52891, it is fixed here #52891 (comment)
chiragsalian commentedon Nov 22, 2024
@kavimuru, can you retest
I checked off #52883 since its not a blocker. I'll check the remaining items.
kavimuru commentedon Nov 22, 2024
#52868 not reproducible
screen-20241122-161720.mp4
screen-20241122-161609.mp4
kavimuru commentedon Nov 22, 2024
#52864 is not reproducible either.
screen-20241122-161413.mp4
screen-20241122-161231.mp4
chiragsalian commentedon Nov 22, 2024
I checked off,
chiragsalian commentedon Nov 22, 2024