Skip to content

[Due for payment 2025-07-18] [Due for payment 2025-07-15] [Multi-Files Drag-and-Drop] (Bulk Drag-and-Drop - Phase 4) fix: follow-ups Split Screen Drop Zone #63312

Closed

Description

@lakchote

Activity

  1. koko57 commented on Jun 3, 2025

    @koko57
    Contributor

    I would like to work on this issue after Stage 5&3

  2. changed the title [-](Splits - Phase 4) fix: follow-ups Split Screen Drop Zone[/-] [+](Bulk Drag-and-Drop - Phase 4) fix: follow-ups Split Screen Drop Zone[/+] on Jun 3, 2025
  3. koko57 commented on Jun 4, 2025

    @koko57
    Contributor

    let's add another one: #62650 (comment)

  4. getusha commented on Jun 6, 2025

    @getusha
    Contributor
  5. koko57 commented on Jun 26, 2025

    @koko57
    Contributor
  6. koko57 commented on Jun 26, 2025

    @koko57
    Contributor

    started investigating these issues while waiting for the review on Stage 3 & 5 PRs

  7. koko57 commented on Jun 30, 2025

    @koko57
    Contributor

    I have a potential fix for #62650 (comment) (extra rerenders), but I need to test it thoroughly.

    For #62650 (comment) (triggering both flows on desktop) - I cannot reproduce:

    Screen.Recording.2025-06-30.at.12.49.03.mp4
  8. koko57 commented on Jun 30, 2025

    @koko57
    Contributor

    #63855 (comment) (attaching receipt on search page) - checking this one - this will be fixed in #64941

  9. koko57 commented on Jun 30, 2025

    @koko57
    Contributor

    @lakchote - #62650 (comment) (system message when we replace a receipt) - this one will require some BE changes

  10. koko57 commented on Jun 30, 2025

    @koko57
    Contributor

    Can someone please explain to me one thing:

    Why when we have a single transaction we don't have transactionID and the isReportTransactionThread is false in this view?

    Image

    and the report object and parentReport look like this:

    {
        "isTransactionThreadView": false,
        "report": {
            "lastReadTime": "2025-06-30 12:18:37.650",
            "reportID": "179215004119440",
            "policyID": "C429AFBE3C4DB856",
            "lastVisibleActionCreated": "2025-06-30 12:18:25.975",
            "statusNum": 1,
            "stateNum": 1,
            "writeCapability": "all",
            "type": "iou",
            "errorFields": {},
            "parentReportID": "7372312670936639",
            "parentReportActionID": "7351669742543309889",
            "chatType": "",
            "reportName": "IOU",
            "description": "",
            "managerID": 18600507,
            "total": 122300,
            "nonReimbursableTotal": 0,
            "ownerAccountID": 20178471,
            "currency": "PLN",
            "unheldTotal": 122300,
            "unheldNonReimbursableTotal": 0,
            "participants": {
                "18600507": {
                    "notificationPreference": ""
                },
                "20178471": {
                    "notificationPreference": ""
                }
            },
            "isWaitingOnBankAccount": false,
            "isOwnPolicyExpenseChat": false,
            "isPinned": false,
            "chatReportID": "7372312670936639",
            "oldPolicyName": "",
            "permissions": []
        },
        "parentReport": {
            "chatType": "",
            "currency": "USD",
            "description": "",
            "errorFields": {},
            "hasOutstandingChildRequest": false,
            "hasOutstandingChildTask": false,
            "iouReportID": "179215004119440",
            "isCancelledIOU": false,
            "isOwnPolicyExpenseChat": false,
            "isPinned": false,
            "isWaitingOnBankAccount": false,
            "lastActionType": "CREATED",
            "lastActorAccountID": "",
            "lastMessageHtml": "",
            "lastMessageText": "",
            "lastReadSequenceNumber": 0,
            "lastReadTime": "2025-06-30 12:18:30.362",
            "lastVisibleActionCreated": "2025-06-30 12:18:25.971",
            "lastVisibleActionLastModified": "2025-06-30 12:18:25.971",
            "managerID": 0,
            "nonReimbursableTotal": 0,
            "oldPolicyName": "",
            "ownerAccountID": 0,
            "participants": {
                "18600507": {
                    "notificationPreference": "always"
                },
                "20178471": {
                    "notificationPreference": "always"
                }
            },
            "permissions": [
                "read",
                "write"
            ],
            "policyID": "_FAKE_",
            "private_isArchived": "",
            "reportID": "7372312670936639",
            "reportName": "Chat Report",
            "stateNum": 0,
            "statusNum": 0,
            "total": 0,
            "type": "chat",
            "unheldNonReimbursableTotal": 0,
            "unheldTotal": 0,
            "welcomeMessage": "",
            "writeCapability": "all"
        }
    }
    

    while when we have two or more transactions in the chat we have transactionID for each of them and isReportTransactionThread is true for this view (IIRC it was displayed on the main screen back then, not in the RHP)

    Image
    {
        "isTransactionThreadView": true,
        "transactionID": "8425086865840198524",
        "report": {
            "reportID": "2836074615633377",
            "policyID": "C429AFBE3C4DB856",
            "lastVisibleActionCreated": "2025-06-30 13:38:38.975",
            "statusNum": 0,
            "stateNum": 0,
            "writeCapability": "all",
            "type": "chat",
            "errorFields": {},
            "parentReportID": "6476316253640400",
            "parentReportActionID": "6224888092507050050",
            "chatType": "",
            "reportName": "Chat Report",
            "description": "",
            "managerID": 0,
            "total": 0,
            "nonReimbursableTotal": 0,
            "ownerAccountID": 0,
            "currency": "USD",
            "unheldTotal": 0,
            "unheldNonReimbursableTotal": 0,
            "participants": {
                "18184571": {
                    "notificationPreference": ""
                },
                "20178471": {
                    "notificationPreference": ""
                }
            },
            "isWaitingOnBankAccount": false,
            "isOwnPolicyExpenseChat": false,
            "isPinned": false,
            "chatReportID": "6476316253640400",
            "oldPolicyName": "",
            "permissions": [
                "read",
                "write",
                "share"
            ]
        },
        "parentReport": {
            "reportName": "IOU",
            "chatReportID": "3284845864020223",
            "chatType": "",
            "currency": "PLN",
            "description": "",
            "errorFields": {},
            "hasOutstandingChildRequest": false,
            "hasOutstandingChildTask": false,
            "hasParentAccess": true,
            "isCancelledIOU": false,
            "isOwnPolicyExpenseChat": false,
            "isPinned": false,
            "isWaitingOnBankAccount": false,
            "lastActionType": "CREATED",
            "lastActorAccountID": "20178471",
            "lastMessageHtml": "",
            "lastMessageText": "",
            "lastReadSequenceNumber": 0,
            "lastReadTime": "2025-06-30 13:38:43.777",
            "lastVisibleActionCreated": "2025-06-30 12:47:00.448",
            "lastVisibleActionLastModified": "2025-06-30 12:47:00.448",
            "managerID": 18184571,
            "nonReimbursableTotal": 0,
            "oldPolicyName": "",
            "ownerAccountID": 20178471,
            "parentReportActionID": "1045400392480626655",
            "parentReportID": "3284845864020223",
            "participants": {
                "18184571": {
                    "notificationPreference": ""
                },
                "20178471": {
                    "notificationPreference": ""
                }
            },
            "permissions": [],
            "policyID": "C429AFBE3C4DB856",
            "private_isArchived": "",
            "reportID": "6476316253640400",
            "stateNum": 1,
            "statusNum": 1,
            "total": 124300,
            "type": "iou",
            "unheldNonReimbursableTotal": 0,
            "unheldTotal": 124300,
            "welcomeMessage": "",
            "writeCapability": "all"
        }
    }

    same happens for a single expense in the workspace (no transactionID) vs two or more expenses

    I need this info to fix both: #62650 (comment) (Replace Receipt in single transaction) and #63807 ("it's not here..." on going

  11. lakchote commented on Jul 1, 2025

    @lakchote
    ContributorAuthor

    Why when we have a single transaction we don't have transactionID and the isReportTransactionThread is false in this view?

    Because when you create an IOU report with only a single expense inside, CreateMoneyRequest explicitly doesn't create a transaction thread.

    For a single expense, the frontend displays the IOU report directly (type: "iou"). Since you're viewing the IOU report itself and not a transaction thread, isReportTransactionThread returns false.

    When you have multiple expenses in an IOU report, clicking on any individual expense navigates you to its transaction thread (type: "chat", with the IOU report as parent). This is when isReportTransactionThread returns true.

    Regarding the transactionID - it's only needed when navigating to a specific transaction thread among multiple transactions. For a single expense viewing the IOU report directly, there's no ambiguity about which transaction is being displayed, so no transactionID is necessary.

  12. koko57 commented on Jul 1, 2025

    @koko57
    Contributor

    @lakchote ok, but what when I want to add/replace a receipt to this single IOU? I need transactionID for ReplaceReceipt command

  13. 32 remaining items

  14. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 14, 2025
  15. melvin-bot commented on Jul 14, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  16. lakchote commented on Jul 14, 2025

    @lakchote
    ContributorAuthor

    @lakchote can you assign a BZ here for payment please

    Done

  17. koko57 commented on Jul 15, 2025

    @koko57
    Contributor

    @lakchote there is still one left - #62650 (comment) (system message when we replace a receipt) but maybe we can move it to #65722 and close this one?

  18. isabelastisser commented on Jul 16, 2025

    @isabelastisser
    Contributor

    @allgandalf, what's your Upwork profile?

  19. isabelastisser commented on Jul 16, 2025

    @isabelastisser
    Contributor

    Payment summary:

    @koko57 does not require payment (Contractor)
    @allgandalf requires payment for C+ review. $250 Upwork job

  20. isabelastisser commented on Jul 16, 2025

    @isabelastisser
    Contributor

    Thanks, @allgandalf! The offer was sent.

  21. isabelastisser commented on Jul 16, 2025

    @isabelastisser
    Contributor

    All set!

  22. changed the title [-][Due for payment 2025-07-18] [Due for payment 2025-07-15] (Bulk Drag-and-Drop - Phase 4) fix: follow-ups Split Screen Drop Zone[/-] [+][Due for payment 2025-07-18] [Due for payment 2025-07-15] [Multi-Files Drag-and-Drop] (Bulk Drag-and-Drop - Phase 4) fix: follow-ups Split Screen Drop Zone[/+] on Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions