Repository navigation
Deploy Checklist: New Expensify 2022-02-15 #7759
Description
Release Version: 1.1.39-3
Compare Changes: production...staging
This release contains changes from the following pull requests:
-
Add Keyboard disable and autogrow functionality to TextInput component #7318
- QA
- Accessibility
-
Show delete confirmation for the action when saving empty comment #7387
- QA
- Accessibility
-
Translate alternate text to Spanish #7552
- QA
- Accessibility
-
Fix: Add payment dynamic #7566
- QA
- Accessibility
-
Fix: Missing PayPal account when trying to delete it #7571
- QA
- Accessibility
-
Add counter and hint to TextInput #7577
- QA
- Accessibility
-
fix: remove extra space between paragraph text #7592
- QA
- Accessibility
-
fix the thumnail size relative to viewport #7600
- QA
- Accessibility
-
Output logs client-side in production as well as dev #7614
- QA
- Accessibility
-
[NO QA]Run tests and lint on merge into main #7632
- QA
- Accessibility
-
- QA
- Accessibility
-
[No QA] Set up beta checks for policyExpenseChat #7658
- QA
- Accessibility
-
Fix cursor issue in room name input #7661
- QA
- Accessibility
-
[CP Stg] Fix CORS errors in desktop application #7665
- QA
- Accessibility
-
- QA
- Accessibility
-
Make sure we round properly wallet transfer fee and balance for display #7674
- QA
- Accessibility
-
Fix: reset the wallet balance when transfer is successful #7681
- QA
- Accessibility
-
[No QA] Simplify electron-builder configs #7684
- QA
- Accessibility
-
[CP Stg] Fix electron build #7685
- QA
- Accessibility
-
remove notification Subheader #7692
- QA
- Accessibility
-
[No QA] Fix desktop CORS issue when using web proxy #7693
- QA
- Accessibility
-
Include
GITHUB_TOKENinconfirmPassingBuildsteps #7695- QA
- Accessibility
-
Use
OS_BOTIFY_TOKENinstead ofGITHUB_TOKEN#7696- QA
- Accessibility
-
[NO QA]Add GitHub Action linting #7697
- QA
- Accessibility
-
Do not skip test and lint for workflow_dispatch #7698
- QA
- Accessibility
-
[No QA] Upgrade expensify-common #7700
- QA
- Accessibility
-
Fix #7609 - Long names were cut off on mWeb in Chat headers #7705
- QA
- Accessibility
-
Hide transfer balance option when balance is zero #7713
- QA
- Accessibility
-
Remove extra white space on attachment modal [iPad] #7716
- QA
- Accessibility
-
Workspace track distance part translated to Spanish #7718
- QA
- Accessibility
-
[No QA] Fix desktop for developers without .env file #7719
- QA
- Accessibility
-
show current user in members #7720
- QA
- Accessibility
-
Security -> Change password menu icon updated to key #7740
- QA
- Accessibility
-
Remove default payment method for paypal #7741
- QA
- Accessibility
-
[NO QA] Fix desktop for web-proxy (again) #7743
- QA
- Accessibility
-
- QA
- Accessibility
-
[No QA] Update getInputIDPropTypes docs #7754
- QA
- Accessibility
-
fix: crash when value is
undefined#7782- QA
- Accessibility
Internal QA:
- Comment on deploy checklist when a pull request is CP'd #7802 - @luacmartins @roryabraham
- [InternalQA] Make sure the first PR comment shows only for external contributors #7672 - @mountiny
Deploy Blockers:
- Payment - Setting a default payment method throws an JS error #7769
- Web - Offline message - The offline message is disappearing when Wifi is turned back #7772
- Web - VBA - Unable to enter date in company info and personal info page using date picker or manually #7774
- mWeb - Connect bank - Error page loaded after select any field on the Company Information page #7775
- Desktop - IOU - Requestor user does not appear in LHN When login to settle IOU #7776
- Changing or Adding firstName or lastName in profile page removes the profile photo - reported by @sobitneupane #7784
- Desktop - App is crashing when select Priority mode #7811
cc @Expensify/applauseleads
Activity
OSBotify commentedon Feb 15, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.39-1 🚀
roryabraham commentedon Feb 15, 2022
Verified #7614 internally, checking it off.
mountiny commentedon Feb 15, 2022
Checking #7672 off since it is a procedural PR. It seems like it is still some issue but it is not blocking anything so it can be checked off.
NikkiWines commentedon Feb 15, 2022
Checking QA for #7681 off since I was able to test and confirm it works as anticipated
roryabraham commentedon Feb 17, 2022
Whoa, lots of deploy blockers 😬
roryabraham commentedon Feb 17, 2022
I was not able to reproduce #7776 on any platform. Can we please retest?
mvtglobally commentedon Feb 17, 2022
@roryabraham Will check and confirm
roryabraham commentedon Feb 17, 2022
roryabraham commentedon Feb 17, 2022
roryabraham commentedon Feb 17, 2022
mvtglobally commentedon Feb 17, 2022
Regression is completed
#7577 is failing #7763
#7776 is still reproduced by the team
Deploy Blockers still open
#7774
#7775
#7776
Other Issues logged
#7786
#7781
#7780
#7779
#7777
#7773
#7770
#7768
#7764
#7763
mvtglobally commentedon Feb 18, 2022
Just added 1 more deploy blocker. #7811
15 remaining items
mvtglobally commentedon Feb 23, 2022
@timszot @roryabraham
Can you discuss internally, if we don't think we can get a new deploy today, let's consider removing Lock label and adding more PRs to the pool? And maybe running another regression on the same 1.1.39-x build?
Last deploy was more than a week ago and I really don't want the Pr list to pile up and testers waiting. Let me know what you think.
parasharrajat commentedon Feb 23, 2022
#7769 is fixed by #7782.
To test #7782, the app should not crash.
#7868 was present on main since the past few versions and I don't think it is a deploy blocker. Also, I think this is behind beta.
roryabraham commentedon Feb 23, 2022
@mvtglobally We discussed internally and we don't want to open the floodgates to more pull requests, as that will likely only increase the time until the next deploy. We want to get the deploy out ASAP as all the contributors with PR's in this checklist are waiting for their work to be deployed to production so they can be compensated.
timszot commentedon Feb 23, 2022
Alright, tested the default payment option on iOS 1.1.39-3 and it worked
timszot commentedon Feb 23, 2022
We should be all clear!
OSBotify commentedon Feb 23, 2022
This issue either has unchecked QA steps or has not yet been marked with the
:shipit:emoji of approval.Reopening!
michaelhaxhiu commentedon Feb 23, 2022
Just to be 100% sure I'm following, we have no remaining deploy blockers?
timszot commentedon Feb 23, 2022
Correct, the last blocker was #7769 which was fixed by #7782
timszot commentedon Feb 23, 2022
michaelhaxhiu commentedon Feb 23, 2022
Stutikuls commentedon Mar 7, 2022
Checked all PRs and added comments on all PRs where accessibility issue were found.
The non-applicable PRs are - #7318 #7614 #7632 #7658 #7673 #7684
Impossibility to verify (After client confirmation) #7681 #7684
SumitDiyora commentedon Mar 8, 2022
Checked all PRs and added comments to all PRs where accessibility issues were found.
The non-applicable PRs are - #7692 #7693 #7695 #7696 #7698 #7700 #7705 #7716 #7719 #7743 #7747 #7754
Impossibility to verify (After client confirmation) #7713