Skip to content

Deploy Checklist: New Expensify 2022-03-10 #8074

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2022-03-10#8074
Assignees
applausebot
Labels
MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@OSBotify
OSBotify
opened on Mar 10, 2022

Release Version: 1.1.42-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

cc @Expensify/applauseleads

Activity

  1. OSBotify
    added
    StagingDeployCash
    on Mar 10, 2022
  2. OSBotify
    assigned
    applausebot
    on Mar 10, 2022

  3. thienlnam commented on Mar 10, 2022

    @thienlnam
    thienlnam
    on Mar 10, 2022
    Contributor

    Checked off #7873, statements don't work on staging so will need to be tested on prod. This isn't used yet

  4. mvtglobally
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Mar 11, 2022

  5. OSBotify commented on Mar 11, 2022

    @OSBotify
    OSBotify
    on Mar 11, 2022
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.42-3 🚀

  6. OSBotify commented on Mar 11, 2022

    @OSBotify
    OSBotify
    on Mar 11, 2022
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.42-4 🚀

  7. OSBotify commented on Mar 11, 2022

    @OSBotify
    OSBotify
    on Mar 11, 2022
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.42-4 has been deployed to staging 🎉

  8. mvtglobally commented on Mar 14, 2022

    @mvtglobally
    mvtglobally
    on Mar 14, 2022

    Deploy Blockers
    #8113
    #8097
    #8094
    #8092

    Comments
    #7660 (comment) is failing
    #7850 is partially blocked by #7768 on IOS, but overall PR pass, checking off
    #7937 is Blocked by #8040 We will retest
    #7929 is failing #7929 (comment)
    #7949 (comment) - Internal QA
    #8025 is blocked by #8097

    Issues
    #8108 discovered while testing #8017
    #8107 discovered while testing #8041
    #8116
    #8115
    #8110
    #8109

  9. chiragsalian commented on Mar 14, 2022

    @chiragsalian
    chiragsalian
    on Mar 14, 2022
    Contributor

    Checking off

    1. Use more user friendly errors when choosing default fund for Wallet #7929 - The delete part of the issue is not a blocker as it happens on production as well. its currently tracked here and here
    2. make payment method preview non interactive #8025 - The basic issue of the PR has been resolved. The delete paypal part is another issue mentioned in my previous point and will be handled separately.

  10. mvtglobally commented on Mar 14, 2022

    @mvtglobally
    mvtglobally
    on Mar 14, 2022

    #8049 - checking off, I missed to checkmark
    checking off #8098 & 8113 as closed
    #8058 - is pass on all but Desktop
    1.1.42-4 is not yet available on Desktop.

  11. MelvinBot
    added
    MonthlyKSv2
    on Mar 14, 2022

  12. chiragsalian commented on Mar 14, 2022

    @chiragsalian
    chiragsalian
    on Mar 14, 2022
    Contributor

    Checking off #7949 since it was internally tested.

  13. mvtglobally commented on Mar 15, 2022

    @mvtglobally
    mvtglobally
    on Mar 15, 2022

    #8106 is pass checking off #8094
    Checking off #8097 & #8115 as its no longer a blocker

    Only outstanding
    #8092 - we didn't get CP yet
    #7660 (comment) - Should we checkoff since original issue is in prod and no fully fixed?

  14. chiragsalian commented on Mar 15, 2022

    @chiragsalian
    chiragsalian
    on Mar 15, 2022
    Contributor

    Alright so let's check out where we stand,

    1. Fix : Android - Picture looks smaller in Preview page #7660 - Is the issue on both prod and staging? If so then can you check the item and create a follow up issue so that it can be investigated later as it doesn't need to hold off deploy. If its only on staging let me know and i'll revert the PR and check it off the checklist so that the author can work
    2. Merge TextInputWithPrefix into TextInput #7937 - i noticed this is still unchecked. There is a comment thats its blocked on #8040 but that issue was closed a couple of days back. We were unable to reproduce issue from our end so can you retest and check it off?
    3. Set up Avatars for Workspace Chats  #7852 - i've pinged some people to test.
    4. Workspace - Manage members - All the avatar icons are looking same in search screen to invite new members #8092 Looks like there is a fix in place but its not on staging. I just started CP-ing the code to staging so it should be available in all devices in about 45-60mins. I'll repost once this is ready to test.

  15. TomatoToaster commented on Mar 15, 2022

    @TomatoToaster
    TomatoToaster
    on Mar 15, 2022
    Contributor

    Did the internalQA and can check off #7852 as per this comment:
    #7852 (comment)

  16. mvtglobally commented on Mar 15, 2022

    @mvtglobally
    mvtglobally
    on Mar 15, 2022

    @chiragsalian

    1. Will check Fix : Android - Picture looks smaller in Preview page #7660 in PROD and update in few min.
    2. Can you check off Merge TextInputWithPrefix into TextInput #7937. I checked it off few times already, I have no idea why its not saving it. It is pass. no blockers
      Screen Shot 2022-03-15 at 2 04 29 PM
    3. Will wait for CP to validate and update

  17. chiragsalian commented on Mar 15, 2022

    @chiragsalian
    chiragsalian
    on Mar 15, 2022
    Contributor

    #8092 - Code is live on staging on version 1.1.42-6.

  18. chiragsalian commented on Mar 15, 2022

    @chiragsalian
    chiragsalian
    on Mar 15, 2022
    Contributor

    Can you check off #7937. I checked it off few times already, I have no idea why its not saving it. It is pass. no blockers

    Oh hah, my edits are not saving as well. Okay i'll just consider it as a pass.
    Edit: nvm, looks like it got updated so its checked now.

  19. mvtglobally commented on Mar 15, 2022

    @mvtglobally
    mvtglobally
    on Mar 15, 2022

    @chiragsalian this ship is ready

    1. Fix : Android - Picture looks smaller in Preview page #7660 repro in PROD. checking off
    2. CP is pass Workspace - Manage members - All the avatar icons are looking same in search screen to invite new members #8092 checking off

  20. chiragsalian commented on Mar 15, 2022

    @chiragsalian
    chiragsalian
    on Mar 15, 2022
    Contributor

    :shipit:

  21. chiragsalian
    closed this as completedon Mar 15, 2022

  22. Stutikuls commented on Apr 6, 2022

    @Stutikuls
    Stutikuls
    on Apr 6, 2022

    Checked all PRs and creating accessibility issues for all PRs where accessibility issue was found.
    The non-applicable PRs are - #7750, #7825, #7847, #7897, #7897, #7995, #7958, #7955, #7958, #7981, #7989, #7992, #7995, #7996, #8000
    Logged Issues - #8428, #8429, #8430, #8463, #8464, #8478, #8479, #8480, #8484. #8485, #8522, #8523, #8481, #8524, #8525, #8552, #8553, #8557, #8388, #8554, #8387, #8558, #8559, #8529, #8530, #8385, #8555, #8556, #8560, #8527 , #8388, #8428, #8528

  23. SumitDiyora commented on Apr 9, 2022

    @SumitDiyora
    SumitDiyora
    on Apr 9, 2022

    Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
    The non-applicable PRs are - #8000, #8010, #8016, #8024, #8026, #8027, #8028, #8037, #8043, #8049, #8054, #8059, #8064, #8067, #8069, #8078, #8081
    Logged Issues - #8465, #8392, #8418, #8506, #8509, #8546, #8392, #8465, #8395, #8393, #8400, #8578, #8579, #8402, #8580, #8465, #8392, #8398, #8432, #8392, #8575, #8408, #8577, #8393, #8395, #8435, #8432, #8419, #8384, #8383, #8385, #8392, #8408
    Impossibility to verify (After client confirmation) - #8009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions