You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-18] [$250] Nested table rows no longer highlight on hover or open expense in RHP on click #88729
Nested table rows in the report view no longer highlight on hover, and clicking the row no longer opens the expense in the RHP. Users must now click the > chevron tap area exactly to open the expense.
This is a regression likely introduced by the compact table styles update (#86283).
On large screens, nested transaction rows inside expanded expense reports are not interactive — no hover highlight and no click-to-open.
Solution
The root cause is in TransactionGroupListExpanded.tsx:263-285. The PressableWithFeedback wrapper that provides both the onPress handler (to open the expense in RHP via handleOnPress) and the hoverStyle is only applied when !isLargeScreenWidth:
{!isLargeScreenWidth ? (<PressableWithFeedbackonPress={()=>handleOnPress(transaction)}hoverStyle={[!transaction.isDisabled&&styles.hoveredComponentBG]}...>{transactionRow}</PressableWithFeedback>) : (transactionRow// ← bare row, no press handler, no hover style)}
On large screens, transactionRow is rendered without any pressable wrapper. The only clickable element is the tiny ArrowRight chevron icon inside TransactionItemRow/index.tsx:895-912.
Fix: Remove the !isLargeScreenWidth conditional and wrap transactionRow in PressableWithFeedback on all screen sizes (lines 263-285). The same onPress, onLongPress, and hoverStyle props should apply regardless of viewport width.
Supporting evidence
Parent report rows work correctly because they render through BaseListItem, which always wraps content in PressableWithFeedback — see ExpenseReportListItem.tsx:257.
The handleOnPress function at line 186 calls openReportInRHP(transaction) which is the expected behavior for clicking a nested row — but this code path is unreachable on large screens.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Please re-state the problem that we are trying to solve in this issue.
In search results grouped by report (or card/tag), when a group is expanded on wide desktop layouts, the nested transaction rows no longer react to hover (no background highlight) and clicking on the row body no longer opens the expense in the RHP. The only area that still works is the narrow > chevron tap target at the end of the row.
What is the root cause of that problem?
The nested rows for an expanded group are rendered by TransactionGroupListExpanded in the expense list. The row is wrapped in a pressable only in the narrow-layout branch; the wide-layout branch returns the bare TransactionItemRow with no outer pressable:
Because transactionRow itself (the inner TransactionItemRow) only ships a dedicated PressableWithFeedback around the right-arrow icon on wide screens, there is no element left to capture row-level press or hover on desktop:
The chevron is the only surviving interactive target, which is exactly the symptom reported. Hover styling is similarly missing because hoverStyle={styles.hoveredComponentBG} only lives on the narrow-branch PressableWithFeedback, so nothing paints the hover background when the row is mounted under the wide-layout branch.
For comparison, the single-report MoneyRequestReportView path wraps its whole row in a PressableWithFeedback for every layout, which is why clicking and hovering work there:
So the wide-layout branch in TransactionGroupListExpanded is the outlier; it was left without a press/hover surface and the chevron ended up carrying the whole interaction.
What changes do you think we should make in order to solve the problem?
In src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx, stop gating the PressableWithFeedback wrapper on !isLargeScreenWidth and always render the row inside it. The pressable should keep its existing onPress={() => handleOnPress(transaction)}, onLongPress, hoverStyle={[!transaction.isDisabled && styles.hoveredComponentBG]}, accessibilityRole, accessibilityLabel, isNested, onMouseDown, dataSet, id, and sentryLabel props — those are the same values used today in the narrow branch and are what restore both the hover highlight and the row-level click-to-open-RHP behavior on desktop.
Because inline cell editing is enabled on the wide layout, we also need to make sure the row-level press does not fire when the user taps a cell that is currently being edited. We can pull in the same pattern already used in MoneyRequestReportTransactionItem: read useEditingCellState at the top of the row, capture its value on onPressIn into a ref, and bail out of handleOnPress when that ref is set. This keeps inline edit save/cancel interactions intact while making the rest of the row a proper press target again.
No other components need to change. The chevron pressable inside TransactionItemRow stays as-is so keyboard focus and hit targets remain the same on narrow layouts, and the isHover prop that already flows into TransactionItemRow from the outer pressable will finally receive a meaningful value on wide screens, which also restores the arrow icon's existing hover opacity toggle.
What alternative solutions did you explore? (Optional)
Wrapping the row at the TransactionItemRow level instead of at the call site was considered, but that component is reused by MoneyRequestReportTransactionItem, TransactionListItem, and other callers that already manage their own outer pressable. Adding a wrapper inside TransactionItemRow would create double-nested pressables in those places and complicate their existing editing-cell logic. Keeping the fix local to TransactionGroupListExpanded avoids touching any of those call sites.
changed the title [-]Nested table rows no longer highlight on hover or open expense in RHP on click[/-][+][$250] Nested table rows no longer highlight on hover or open expense in RHP on click[/+]on Apr 24, 2026
Activity
luacmartins commentedon Apr 24, 2026
@MelvinBot find the root cause of the issue
MelvinBot commentedon Apr 24, 2026
Proposal
Problem
On large screens, nested transaction rows inside expanded expense reports are not interactive — no hover highlight and no click-to-open.
Solution
The root cause is in
TransactionGroupListExpanded.tsx:263-285. ThePressableWithFeedbackwrapper that provides both theonPresshandler (to open the expense in RHP viahandleOnPress) and thehoverStyleis only applied when!isLargeScreenWidth:On large screens,
transactionRowis rendered without any pressable wrapper. The only clickable element is the tinyArrowRightchevron icon insideTransactionItemRow/index.tsx:895-912.Fix: Remove the
!isLargeScreenWidthconditional and wraptransactionRowinPressableWithFeedbackon all screen sizes (lines 263-285). The sameonPress,onLongPress, andhoverStyleprops should apply regardless of viewport width.Supporting evidence
BaseListItem, which always wraps content inPressableWithFeedback— seeExpenseReportListItem.tsx:257.handleOnPressfunction at line 186 callsopenReportInRHP(transaction)which is the expected behavior for clicking a nested row — but this code path is unreachable on large screens.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Apr 24, 2026
Current assignee @Krishna2323 is eligible for the External assigner, not assigning anyone new.
wildan-m commentedon Apr 24, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
In search results grouped by report (or card/tag), when a group is expanded on wide desktop layouts, the nested transaction rows no longer react to hover (no background highlight) and clicking on the row body no longer opens the expense in the RHP. The only area that still works is the narrow
>chevron tap target at the end of the row.What is the root cause of that problem?
The nested rows for an expanded group are rendered by
TransactionGroupListExpandedin the expense list. The row is wrapped in a pressable only in the narrow-layout branch; the wide-layout branch returns the bareTransactionItemRowwith no outer pressable:App/src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx
Lines 268 to 286 in 50270ae
Because
transactionRowitself (the innerTransactionItemRow) only ships a dedicatedPressableWithFeedbackaround the right-arrow icon on wide screens, there is no element left to capture row-level press or hover on desktop:App/src/components/TransactionItemRow/index.tsx
Lines 895 to 915 in 50270ae
The chevron is the only surviving interactive target, which is exactly the symptom reported. Hover styling is similarly missing because
hoverStyle={styles.hoveredComponentBG}only lives on the narrow-branchPressableWithFeedback, so nothing paints the hover background when the row is mounted under the wide-layout branch.For comparison, the single-report
MoneyRequestReportViewpath wraps its whole row in aPressableWithFeedbackfor every layout, which is why clicking and hovering work there:App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx
Lines 141 to 215 in 50270ae
So the wide-layout branch in
TransactionGroupListExpandedis the outlier; it was left without a press/hover surface and the chevron ended up carrying the whole interaction.What changes do you think we should make in order to solve the problem?
In
src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx, stop gating thePressableWithFeedbackwrapper on!isLargeScreenWidthand always render the row inside it. The pressable should keep its existingonPress={() => handleOnPress(transaction)},onLongPress,hoverStyle={[!transaction.isDisabled && styles.hoveredComponentBG]},accessibilityRole,accessibilityLabel,isNested,onMouseDown,dataSet,id, andsentryLabelprops — those are the same values used today in the narrow branch and are what restore both the hover highlight and the row-level click-to-open-RHP behavior on desktop.Because inline cell editing is enabled on the wide layout, we also need to make sure the row-level press does not fire when the user taps a cell that is currently being edited. We can pull in the same pattern already used in
MoneyRequestReportTransactionItem: readuseEditingCellStateat the top of the row, capture its value ononPressIninto a ref, and bail out ofhandleOnPresswhen that ref is set. This keeps inline edit save/cancel interactions intact while making the rest of the row a proper press target again.No other components need to change. The chevron pressable inside
TransactionItemRowstays as-is so keyboard focus and hit targets remain the same on narrow layouts, and theisHoverprop that already flows intoTransactionItemRowfrom the outer pressable will finally receive a meaningful value on wide screens, which also restores the arrow icon's existing hover opacity toggle.Compare branch: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/88729-nested-row-hover-click?expand=1
What alternative solutions did you explore? (Optional)
Wrapping the row at the
TransactionItemRowlevel instead of at the call site was considered, but that component is reused byMoneyRequestReportTransactionItem,TransactionListItem, and other callers that already manage their own outer pressable. Adding a wrapper insideTransactionItemRowwould create double-nested pressables in those places and complicate their existing editing-cell logic. Keeping the fix local toTransactionGroupListExpandedavoids touching any of those call sites.melvin-bot commentedon Apr 24, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022047750625313147857
[-]Nested table rows no longer highlight on hover or open expense in RHP on click[/-][+][$250] Nested table rows no longer highlight on hover or open expense in RHP on click[/+]39 remaining items
Krishna2323 commentedon May 14, 2026
One regression from this PR, so payment should be $125.
melvin-bot commentedon May 17, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon May 18, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
Krishna2323 commentedon May 19, 2026
Checklist isn't required here.
mallenexpensify commentedon May 19, 2026
Payment Summary
Contributor+: @Krishna2323 due $125 via NewDot
laurenreidexpensify commentedon Jun 29, 2026
$125 approved for @Krishna2323