You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-20] [Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view #90048
Version Number: 9.3.69-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89364 Email or phone of affected tester (no customers):josdjnosdjionjsdonjisod@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone 15 Pro Max / iOS 26.4.2 App Component: Search
Action Performed:
Launch Expensify app.
Go to workspace chat.
Create an expense and delete it.
Go to Spend > Expenses.
Type group-by:from status:deleted on the search field and search.
Expand the row.
Long tap on the deleted expense.
Expected Result:
Select option will show up when long tapping on the deleted expense row.
Actual Result:
Select option does not show up when long tapping on the deleted expense row.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #89364 - "Fix nested row hover and click in grouped search results" by @MelvinBot (High confidence) Related Issues: #88729
Recommendation: REVERT
PR #89364 introduced a regression where long-pressing a deleted expense row in the group-by view no longer triggers selection mode. The fix is straightforward and the PR can be cleanly reverted.
Assigned: @MelvinBot (PR author), @JS00001 (approving reviewer), @Krishna2323 (approving reviewer), @trjExpensify (approving reviewer) from highest-confidence causing PR only Labels: DeployBlockerCash kept (frontend App PR is the cause). DeployBlocker is not present and was not added.
Detailed Analysis
Evidence
The issue reports that long-tapping a deleted expense in the group-by (group-by:from status:deleted) view does not show the "Select" option on Android and iOS native apps.
The disabled prop on PressableWithFeedback propagates to GenericPressable / BaseGenericPressable, where onLongPressHandler guards with if (isDisabled) { return; } at line 93.
Root Cause
PR #89364 added disabled={isDeletedOrPendingDelete && !transaction.isSelected} to the PressableWithFeedback wrapping each transaction row in the expanded group view. For a deleted transaction that has not yet been selected (transaction.isSelected === false), this evaluates to true, making the entire pressable disabled. React Native's Pressable (and the GenericPressable wrapper) block all gestures — including onLongPress — when disabled is true. This prevents the user from initiating selection mode via long press on deleted expense rows. The fix should avoid using the disabled prop to block navigation; instead, the onPress handler already handles this case by checking isDeletedOrPendingDelete && !canSelectMultiple and setting onPress={undefined} when appropriate, which is the correct pattern for allowing long press while blocking tap navigation.
In TransactionGroupListExpanded.tsx:277, the disabled prop on the PressableWithFeedback is set to isDeletedOrPendingDelete && !transaction.isSelected. For any deleted expense that hasn't been selected yet, this evaluates to true.
When disabled is true, BaseGenericPressable.tsx:182 suppresses onLongPress entirely (onLongPress={!isDisabled && onLongPress ? onLongPressHandler : undefined}), so the user can never long-press to select deleted rows.
The non-grouped TransactionListItem.tsx:206 does not have this problem because it uses disabled={isDisabled && !item.isSelected} — it relies on the parent isDisabled prop rather than deriving disabled state from the deletion status.
What changes do you think we should make in order to solve the problem?
Change the disabled prop in TransactionGroupListExpanded.tsx from:
The onPress handler on line 276 already correctly blocks navigation for deleted rows by being set to undefined when isDeletedOrPendingDelete && !canSelectMultiple. The visual cursor style is separately handled by wrapperStyle on line 284. So the disabled prop is redundant for blocking taps and harmful for blocking long-press.
What alternative solutions did you explore? (Optional)
We could match TransactionListItem's exact pattern (disabled={isDisabled && !transaction.isSelected}) but since the parent isDisabled is not currently used in this context, both approaches are equivalent. The key insight is that disabled must not be derived from isDeletedOrPendingDelete because it blocks onLongPress.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@MelvinBot The fix should change the disabled prop to only cover pending-delete items, not trashed ones. TransactionListItem uses disabled={isDisabled && !item.isSelected} where isDisabled is pendingAction === 'delete' (from SearchList/index.tsx). It never includes trashed items (isDeletedTransaction) in the disabled check — those are handled separately via onPress={undefined}.
isTransactionPendingDelete is already imported and used in the file. The other isDeletedOrPendingDelete usages (onPress, wrapperStyle, onArrowRightPress) are correct and should stay as-is. Please verify this matches TransactionListItem behavior and implement this.
Changed the disabled prop from isDeletedOrPendingDelete && !transaction.isSelected to isTransactionPendingDelete(transaction) && !transaction.isSelected, matching TransactionListItem behavior where only pending-delete items are disabled (trashed items are handled via onPress={undefined}).
Please mark it as "Ready for review" when it is ready for review.
changed the title [-][$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view[/-][+][Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view[/+]on May 11, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.69-18 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view[/-][+][Due for payment 2026-05-20] [Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 8, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89364
melvin-bot commentedon May 8, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 8, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 8, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #89364 - "Fix nested row hover and click in grouped search results" by @MelvinBot (High confidence)
Related Issues: #88729
Recommendation: REVERT
PR #89364 introduced a regression where long-pressing a deleted expense row in the group-by view no longer triggers selection mode. The fix is straightforward and the PR can be cleanly reverted.
Assigned: @MelvinBot (PR author), @JS00001 (approving reviewer), @Krishna2323 (approving reviewer), @trjExpensify (approving reviewer) from highest-confidence causing PR only
Labels:
DeployBlockerCashkept (frontend App PR is the cause).DeployBlockeris not present and was not added.Detailed Analysis
Evidence
group-by:from status:deleted) view does not show the "Select" option on Android and iOS native apps.src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsxto wrap all transaction rows (including deleted ones) inPressableWithFeedbackon all screen sizes.disabled={isDeletedOrPendingDelete && !transaction.isSelected}to thePressableWithFeedback.disabledprop also suppressesonLongPress.BaseGenericPressable.tsx(line 92-95),onLongPressHandlerreturns early whenisDisabledis true — meaningonLongPressnever fires.PressableWithFeedbackthat did NOT have adisabledprop, so long press worked correctly.Verification
src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsxdisabledprop onPressableWithFeedbackpropagates toGenericPressable/BaseGenericPressable, whereonLongPressHandlerguards withif (isDisabled) { return; }at line 93.Root Cause
PR #89364 added
disabled={isDeletedOrPendingDelete && !transaction.isSelected}to thePressableWithFeedbackwrapping each transaction row in the expanded group view. For a deleted transaction that has not yet been selected (transaction.isSelected === false), this evaluates totrue, making the entire pressable disabled. React Native'sPressable(and theGenericPressablewrapper) block all gestures — includingonLongPress— whendisabledistrue. This prevents the user from initiating selection mode via long press on deleted expense rows. The fix should avoid using thedisabledprop to block navigation; instead, theonPresshandler already handles this case by checkingisDeletedOrPendingDelete && !canSelectMultipleand settingonPress={undefined}when appropriate, which is the correct pattern for allowing long press while blocking tap navigation.MelvinBot commentedon May 8, 2026
Proposal
What is the root cause of that problem?
In
TransactionGroupListExpanded.tsx:277, thedisabledprop on thePressableWithFeedbackis set toisDeletedOrPendingDelete && !transaction.isSelected. For any deleted expense that hasn't been selected yet, this evaluates totrue.When
disabledistrue,BaseGenericPressable.tsx:182suppressesonLongPressentirely (onLongPress={!isDisabled && onLongPress ? onLongPressHandler : undefined}), so the user can never long-press to select deleted rows.The non-grouped
TransactionListItem.tsx:206does not have this problem because it usesdisabled={isDisabled && !item.isSelected}— it relies on the parentisDisabledprop rather than deriving disabled state from the deletion status.What changes do you think we should make in order to solve the problem?
Change the
disabledprop inTransactionGroupListExpanded.tsxfrom:disabled={isDeletedOrPendingDelete && !transaction.isSelected}to:
disabled={false}The
onPresshandler on line 276 already correctly blocks navigation for deleted rows by being set toundefinedwhenisDeletedOrPendingDelete && !canSelectMultiple. The visual cursor style is separately handled bywrapperStyleon line 284. So thedisabledprop is redundant for blocking taps and harmful for blocking long-press.What alternative solutions did you explore? (Optional)
We could match
TransactionListItem's exact pattern (disabled={isDisabled && !transaction.isSelected}) but since the parentisDisabledis not currently used in this context, both approaches are equivalent. The key insight is thatdisabledmust not be derived fromisDeletedOrPendingDeletebecause it blocksonLongPress.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.Krishna2323 commentedon May 9, 2026
@MelvinBot The fix should change the
disabledprop to only cover pending-delete items, not trashed ones.TransactionListItemusesdisabled={isDisabled && !item.isSelected}whereisDisabledispendingAction === 'delete'(fromSearchList/index.tsx). It never includes trashed items (isDeletedTransaction) in thedisabledcheck — those are handled separately viaonPress={undefined}.So the fix should be:
isTransactionPendingDeleteis already imported and used in the file. The otherisDeletedOrPendingDeleteusages (onPress,wrapperStyle,onArrowRightPress) are correct and should stay as-is. Please verify this matchesTransactionListItembehavior and implement this.MelvinBot commentedon May 9, 2026
🤖 Draft PR created: #90108
Changed the
disabledprop fromisDeletedOrPendingDelete && !transaction.isSelectedtoisTransactionPendingDelete(transaction) && !transaction.isSelected, matchingTransactionListItembehavior where only pending-delete items are disabled (trashed items are handled viaonPress={undefined}).Please mark it as "Ready for review" when it is ready for review.
4 remaining items
JS00001 commentedon May 11, 2026
merged the fix, requestred a cp
IuliiaHerets commentedon May 11, 2026
Galaxy A55/ Android 16
v.9.3.69-9
Not Repro
Repro.90048.mp4
[-][$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view[/-][+][Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view[/+]melvin-bot commentedon May 11, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 11, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.69-18 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 11, 2026
@Krishna2323 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view[/-][+][Due for payment 2026-05-20] [Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view[/+]melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@Krishna2323 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]