Repository navigation
Fix nested row hover and click in grouped search results - #89364
Conversation
Remove the !isLargeScreenWidth conditional that prevented PressableWithFeedback from wrapping nested transaction rows on large screens, and convert to render-prop pattern so isHover flows to TransactionItemRow for chevron opacity toggle. Also disable parent group row hover highlight when expanded so only the individual child row highlights on hover (per design). Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
@MelvinBot complete the checklist |
|
Done! I've updated the PR body with:
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
Feels good to me, cc @Expensify/design @JmillsExpensify @trjExpensify 4 viz |
|
Looking pretty good to me as well! I'm getting this issue with the modal sliding in though, is that from this PR? 2026-05-01_10-54-16.mp4 |
|
Hmm no idea - thoughts @Krishna2323? |
Are you referring to the laggy transition or the content shown during the transition? If so, it’s definitely not related to this PR. |
|
Yep, I was! |
|
@MelvinBot mark this ready for review |
|
🤖 I attempted to mark this PR as ready for review, but I don't have permission to do so in this environment. You can mark it ready yourself by clicking Ready for review at the bottom of the PR, or by running: |
|
@codex review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hybrid.mp4Android: mWeb Chromeandroid_mWeb.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b34e346d3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| transactionRow | ||
| )} | ||
| <PressableWithFeedback | ||
| onPress={() => handleOnPress(transaction)} |
There was a problem hiding this comment.
Block row navigation for deleted expanded transactions
This makes every expanded child row navigable, including deleted entries (action === UNDELETE), so on large screens clicking a deleted row now calls openReportInRHP() instead of limiting interaction to the undelete control. That is a behavior regression from the non-grouped transaction list, which explicitly disables row navigation for deleted transactions, and it can send users into a transaction thread flow for items that should only expose restore actions.
Useful? React with 👍 / 👎.
|
@Expensify/design @trjExpensify currently, pending-delete items in expanded transaction groups don't show a disabled cursor and still have press feedback. I'd like to disable all press feedback and show a disabled cursor for these items. Just wanted to confirm this is the expected behavior before making the change. issue_pending_delete.mp4 |
|
That makes sense to me 👍 |
|
@MelvinBot add handling for deleted/pending-delete child rows in
You can reference how |
…ctionGroupListExpanded - Compute isDisabled from isDeletedTransaction/isTransactionPendingDelete per row - Disable press and navigation for deleted/pending-delete rows - Show disabled cursor on those rows - Pass isDisabled to TransactionItemRow (disables arrow button and checkbox) - Allow deselection of already-selected disabled rows (matching TransactionListItem) Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
|
Added handling for deleted/pending-delete child rows in
|
| isNested | ||
| onMouseDown={(e) => e.preventDefault()} | ||
| hoverStyle={[!transaction.isDisabled && styles.hoveredComponentBG]} | ||
| style={[isDeletedOrPendingDelete && styles.cursorDefault]} |
There was a problem hiding this comment.
@MelvinBot style={[isDeletedOrPendingDelete && styles.cursorDefault]} should be wrapperStyle={isDeletedOrPendingDelete ? styles.cursorDisabled : undefined} — the parent group's wrapper has cursor: pointer which overrides style via CSS inheritance. Using wrapperStyle ensures the disabled cursor is visible. Also cursorDisabled (not-allowed) is more appropriate than cursorDefault here.
There was a problem hiding this comment.
Done — switched to wrapperStyle={isDeletedOrPendingDelete ? styles.cursorDisabled : undefined} so the disabled cursor overrides the parent wrapper's cursor: pointer.
| accessibilityLabel={transaction.text ?? ''} | ||
| isNested | ||
| onMouseDown={(e) => e.preventDefault()} | ||
| hoverStyle={[!transaction.isDisabled && styles.hoveredComponentBG]} |
There was a problem hiding this comment.
@MelvinBot Missing transaction.isSelected && styles.activeComponentBG in hoverStyle — should be hoverStyle={[!transaction.isDisabled && styles.hoveredComponentBG, transaction.isSelected && styles.activeComponentBG]} to match TransactionListItem.
There was a problem hiding this comment.
Done — added transaction.isSelected && styles.activeComponentBG to hoverStyle to match TransactionListItem.
|
MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR. Next steps: A human should review the recent commits and resolve the conflicting CI errors manually. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00315b0fbd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| transaction.policy, | ||
| )} | ||
| isSelected={!!transaction.isSelected} | ||
| isDisabled={isRowDisabled} |
There was a problem hiding this comment.
Keep undelete action enabled for deleted child rows
Marking deleted/pending-delete child rows as isDisabled here disables their ActionCell button (UNDELETE), because TransactionItemRow forwards isDisabled to shouldDisablePointerEvents and the button becomes non-interactive. In an expanded expense-report group, this prevents users from restoring deleted transactions from the row where the only intended action is undelete, which is a regression from the previous behavior and from non-grouped transaction rows.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Great catch! @MelvinBot this is a valid concern, investigate and see how TransactionListItem handles this case.
There was a problem hiding this comment.
The concern is valid. TransactionListItem does not pass isDisabled=true for already-deleted transactions — only for pending-delete ones. Here's why:
isDisabled on the transaction data is set to isTransactionPendingDelete(transaction) only. Already-deleted transactions (isDeletedTransaction) get press/navigation disabled separately, but isDisabled stays false — so the UNDELETE ActionCell button remains clickable (line 95 only disables when shouldDisablePointerEvents is true).
Our current code passes isDisabled={isDeletedOrPendingDelete} which incorrectly disables the UNDELETE button on deleted rows.
Fix: Split the logic — use isDeletedOrPendingDelete for press/cursor/navigation disabling, but only pass isTransactionPendingDelete(transaction) as isDisabled to TransactionItemRow:
- isDisabled={isDeletedOrPendingDelete}
+ isDisabled={isTransactionPendingDelete(transaction)}This matches how TransactionListItem receives isDisabled from the selection list infrastructure.
I'll push this fix now.
Already-deleted transactions need the UNDELETE ActionCell button to remain clickable. TransactionListItem only sets isDisabled for isTransactionPendingDelete, not isDeletedTransaction — match that behavior here so the undelete button stays enabled on deleted rows while still disabling press/cursor/navigation. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
|
#89364 (comment) makes sense to me too. 👍 |
|
@MelvinBot resolve conflicts |
Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
|
Resolved merge conflicts by merging |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Krishna2323
left a comment
There was a problem hiding this comment.
LGTM! @JS00001 ready for final review.
|
The author checklist is not filled yet |
trjExpensify
left a comment
There was a problem hiding this comment.
Restoring functionality we had before 👍
|
@JS00001 who will fill out the author checklist? I’m not sure how that’s handled since the PR was created by MelvinBot. |
|
@Krishna2323 could you fill it out please? Validating each entry? |
|
@JS00001 I can’t edit Melvin’s comment. I think you can just check all the boxes since I’ve already completed the testing on all platforms. |
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.69-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a UI bug fix that restores hover highlighting and click-to-open behavior on nested transaction rows in expanded search result groups on large screens. No user-facing features, workflows, terminology, or settings were added or changed — the existing help site articles remain accurate. |
|
Deploy Blocker #90048 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀
|
Explanation of Change
On large screens, nested transaction rows inside expanded expense report groups were missing hover highlight and click-to-open behavior. This was caused by a
!isLargeScreenWidthconditional inTransactionGroupListExpandedthat only wrapped rows inPressableWithFeedbackon narrow layouts.This PR:
PressableWithFeedbackwraps child rows on all screen sizes, restoringonPress/onLongPress/hoverStyle.{({hovered}) => ...}soisHoverflows intoTransactionItemRowfor correct chevron opacity on hover (matchingMoneyRequestReportTransactionItem).hoverStylewhen expanded so only the individual child row highlights on hover (per design confirmation).Fixed Issues
$ #88729
PROPOSAL: #88729 (comment)
Tests
Offline tests
N/A — This change is UI-only (hover styles and press handlers) and does not involve network requests or Onyx data.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
AI Tests
npm run typecheck(tsc)npm run typecheck-tsgonpx eslint(changed files)npx prettier(changed files)npm test(Search/TransactionGroup/TransactionItem)npm run react-compiler-compliance-check check-changed