Skip to content

Fix nested row hover and click in grouped search results - #89364

Merged
JS00001 merged 7 commits into
mainfrom
claude-nestedRowHoverAndClick
May 7, 2026
Merged

JS00001 merged 7 commits into
mainfrom
claude-nestedRowHoverAndClick

Conversation

@MelvinBot

@MelvinBot MelvinBot commented May 1, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

On large screens, nested transaction rows inside expanded expense report groups were missing hover highlight and click-to-open behavior. This was caused by a !isLargeScreenWidth conditional in TransactionGroupListExpanded that only wrapped rows in PressableWithFeedback on narrow layouts.

This PR:

  1. Removes the conditional so PressableWithFeedback wraps child rows on all screen sizes, restoring onPress/onLongPress/hoverStyle.
  2. Converts the child to a render-prop {({hovered}) => ...} so isHover flows into TransactionItemRow for correct chevron opacity on hover (matching MoneyRequestReportTransactionItem).
  3. Disables the parent group row's hoverStyle when expanded so only the individual child row highlights on hover (per design confirmation).

Fixed Issues

$ #88729
PROPOSAL: #88729 (comment)

Tests

  1. Log in on a wide-screen device (desktop web or tablet landscape)
  2. Navigate to Search and find an expense report group that contains multiple transactions (an expandable row)
  3. Click to expand the group row
  4. Hover over individual child transaction rows inside the expanded group
  5. Verify each child row highlights on hover
  6. Verify the chevron (arrow icon) appears/changes opacity on hover for each child row
  7. Click on a child transaction row
  8. Verify it opens the transaction detail (RHP or report view)
  9. Verify the parent group row does NOT highlight on hover while expanded
  10. Collapse the group and verify the parent row highlights on hover again
  11. Repeat steps 2-10 on a narrow-screen layout (mobile web or narrow browser window) to confirm no regression
  • Verify that no errors appear in the JS console

Offline tests

N/A — This change is UI-only (hover styles and press handlers) and does not involve network requests or Onyx data.

QA Steps

  1. Log in on a wide-screen web browser
  2. Navigate to Search and find an expense report group with multiple transactions
  3. Expand the group row
  4. Hover over individual child rows — verify hover highlight appears
  5. Click a child row — verify it opens correctly
  6. Verify the parent group row does NOT show hover highlight while expanded
  7. Collapse and verify parent row hover works again
  8. Repeat on a narrow browser window to confirm no regression
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

AI Tests

Test Result
npm run typecheck (tsc) Pass
npm run typecheck-tsgo Pass
npx eslint (changed files) Pass
npx prettier (changed files) Pass (unchanged)
npm test (Search/TransactionGroup/TransactionItem) Pass (36 suites, 987 tests)
npm run react-compiler-compliance-check check-changed Skipped (CI env missing origin/main ref)

Remove the !isLargeScreenWidth conditional that prevented
PressableWithFeedback from wrapping nested transaction rows on
large screens, and convert to render-prop pattern so isHover
flows to TransactionItemRow for chevron opacity toggle.

Also disable parent group row hover highlight when expanded so
only the individual child row highlights on hover (per design).

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team May 1, 2026 08:59
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-nestedRowHoverAndClick
git checkout -b claude-nestedRowHoverAndClick upstream/claude-nestedRowHoverAndClick
git push -u origin claude-nestedRowHoverAndClick

Then you can close this PR and open a new one from your fork.

@Krishna2323

Copy link
Copy Markdown
Contributor

@MelvinBot complete the checklist

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done! I've updated the PR body with:

  • Tests section: Added detailed steps for verifying hover highlight and click behavior on both wide and narrow screens
  • Offline tests: Marked N/A since this is a UI-only change (hover styles and press handlers)
  • QA Steps: Added steps covering the key behaviors to verify
  • Author Checklist: Checked off applicable items — left unchecked the items that require manual platform testing, screenshots, and offline testing (those need to be done by the human co-author)

@codecov

codecov Bot commented May 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...h/SearchList/ListItem/TransactionGroupListItem.tsx 72.72% <100.00%> (ø)
...archList/ListItem/TransactionGroupListExpanded.tsx 66.31% <76.92%> (+3.95%) ⬆️
... and 9 files with indirect coverage changes

@Krishna2323

Copy link
Copy Markdown
Contributor

@codex review

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@shawnborton

Copy link
Copy Markdown
Contributor

Feels good to me, cc @Expensify/design @JmillsExpensify @trjExpensify 4 viz

@trjExpensify

Copy link
Copy Markdown
Contributor

Looking pretty good to me as well! I'm getting this issue with the modal sliding in though, is that from this PR?

2026-05-01_10-54-16.mp4

@trjExpensify
trjExpensify self-requested a review May 1, 2026 09:55
@shawnborton

Copy link
Copy Markdown
Contributor

Hmm no idea - thoughts @Krishna2323?

@Krishna2323

Copy link
Copy Markdown
Contributor

is that from this PR?

Are you referring to the laggy transition or the content shown during the transition? If so, it’s definitely not related to this PR.

@trjExpensify

Copy link
Copy Markdown
Contributor

Yep, I was!

@Krishna2323

Copy link
Copy Markdown
Contributor

@MelvinBot mark this ready for review

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I attempted to mark this PR as ready for review, but I don't have permission to do so in this environment. You can mark it ready yourself by clicking Ready for review at the bottom of the PR, or by running:

gh pr ready 89364 --repo Expensify/App

@Krishna2323

Copy link
Copy Markdown
Contributor

@codex review

@Krishna2323

Krishna2323 commented May 2, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: HybridApp
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b34e346d3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

transactionRow
)}
<PressableWithFeedback
onPress={() => handleOnPress(transaction)}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Block row navigation for deleted expanded transactions

This makes every expanded child row navigable, including deleted entries (action === UNDELETE), so on large screens clicking a deleted row now calls openReportInRHP() instead of limiting interaction to the undelete control. That is a behavior regression from the non-grouped transaction list, which explicitly disables row navigation for deleted transactions, and it can send users into a transaction thread flow for items that should only expose restore actions.

Useful? React with 👍 / 👎.

@Krishna2323

Copy link
Copy Markdown
Contributor

@Expensify/design @trjExpensify currently, pending-delete items in expanded transaction groups don't show a disabled cursor and still have press feedback. I'd like to disable all press feedback and show a disabled cursor for these items. Just wanted to confirm this is the expected behavior before making the change.

issue_pending_delete.mp4

@shawnborton

Copy link
Copy Markdown
Contributor

That makes sense to me 👍

@Krishna2323

Copy link
Copy Markdown
Contributor

@MelvinBot add handling for deleted/pending-delete child rows in TransactionGroupListExpanded. Specifically:

  • Disable press and navigation for rows where isDeletedTransaction(transaction) || isTransactionPendingDelete(transaction) is true
  • Show a disabled cursor on those rows
  • Disable the arrow button and checkbox
  • Pass isDisabled to TransactionItemRow

You can reference how TransactionListItem handles this — it uses disabled={isDisabled && !item.isSelected} to still allow deselection if the row was selected before deletion.

…ctionGroupListExpanded

- Compute isDisabled from isDeletedTransaction/isTransactionPendingDelete per row
- Disable press and navigation for deleted/pending-delete rows
- Show disabled cursor on those rows
- Pass isDisabled to TransactionItemRow (disables arrow button and checkbox)
- Allow deselection of already-selected disabled rows (matching TransactionListItem)

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Added handling for deleted/pending-delete child rows in TransactionGroupListExpanded, matching the pattern from TransactionListItem:

  • Rows where isDeletedTransaction(transaction) || isTransactionPendingDelete(transaction) is true now have:
    • Press and navigation disabled (but still allow deselection if already selected, via disabled={isRowDisabled && !transaction.isSelected})
    • cursorDefault style applied
    • Arrow button disabled (onArrowRightPress set to undefined)
    • Checkbox and arrow disabled via isDisabled prop passed to TransactionItemRow

isNested
onMouseDown={(e) => e.preventDefault()}
hoverStyle={[!transaction.isDisabled && styles.hoveredComponentBG]}
style={[isDeletedOrPendingDelete && styles.cursorDefault]}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot style={[isDeletedOrPendingDelete && styles.cursorDefault]} should be wrapperStyle={isDeletedOrPendingDelete ? styles.cursorDisabled : undefined} — the parent group's wrapper has cursor: pointer which overrides style via CSS inheritance. Using wrapperStyle ensures the disabled cursor is visible. Also cursorDisabled (not-allowed) is more appropriate than cursorDefault here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — switched to wrapperStyle={isDeletedOrPendingDelete ? styles.cursorDisabled : undefined} so the disabled cursor overrides the parent wrapper's cursor: pointer.

accessibilityLabel={transaction.text ?? ''}
isNested
onMouseDown={(e) => e.preventDefault()}
hoverStyle={[!transaction.isDisabled && styles.hoveredComponentBG]}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot Missing transaction.isSelected && styles.activeComponentBG in hoverStyle — should be hoverStyle={[!transaction.isDisabled && styles.hoveredComponentBG, transaction.isSelected && styles.activeComponentBG]} to match TransactionListItem.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — added transaction.isSelected && styles.activeComponentBG to hoverStyle to match TransactionListItem.

@Krishna2323

Copy link
Copy Markdown
Contributor

@melvin-bot
melvin-bot Bot removed the request for review from a team May 4, 2026 12:44
@melvin-bot

melvin-bot Bot commented May 4, 2026

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00315b0fbd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

transaction.policy,
)}
isSelected={!!transaction.isSelected}
isDisabled={isRowDisabled}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep undelete action enabled for deleted child rows

Marking deleted/pending-delete child rows as isDisabled here disables their ActionCell button (UNDELETE), because TransactionItemRow forwards isDisabled to shouldDisablePointerEvents and the button becomes non-interactive. In an expanded expense-report group, this prevents users from restoring deleted transactions from the row where the only intended action is undelete, which is a regression from the previous behavior and from non-grouped transaction rows.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! @MelvinBot this is a valid concern, investigate and see how TransactionListItem handles this case.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concern is valid. TransactionListItem does not pass isDisabled=true for already-deleted transactions — only for pending-delete ones. Here's why:

isDisabled on the transaction data is set to isTransactionPendingDelete(transaction) only. Already-deleted transactions (isDeletedTransaction) get press/navigation disabled separately, but isDisabled stays false — so the UNDELETE ActionCell button remains clickable (line 95 only disables when shouldDisablePointerEvents is true).

Our current code passes isDisabled={isDeletedOrPendingDelete} which incorrectly disables the UNDELETE button on deleted rows.

Fix: Split the logic — use isDeletedOrPendingDelete for press/cursor/navigation disabling, but only pass isTransactionPendingDelete(transaction) as isDisabled to TransactionItemRow:

- isDisabled={isDeletedOrPendingDelete}
+ isDisabled={isTransactionPendingDelete(transaction)}

This matches how TransactionListItem receives isDisabled from the selection list infrastructure.

I'll push this fix now.

Already-deleted transactions need the UNDELETE ActionCell button to remain
clickable. TransactionListItem only sets isDisabled for isTransactionPendingDelete,
not isDeletedTransaction — match that behavior here so the undelete button
stays enabled on deleted rows while still disabling press/cursor/navigation.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@trjExpensify

Copy link
Copy Markdown
Contributor

#89364 (comment) makes sense to me too. 👍

@Krishna2323

Copy link
Copy Markdown
Contributor

@MelvinBot resolve conflicts

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Resolved merge conflicts by merging main into the PR branch. The conflict was in TransactionGroupListExpanded.tsx where main added a standalone transactionRow variable while this PR inlines TransactionItemRow directly inside PressableWithFeedback with a render-prop pattern. Kept the PR's approach and incorporated main's changes.

@Krishna2323

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @JS00001 ready for final review.

@Gonals

Gonals commented May 6, 2026

Copy link
Copy Markdown
Contributor

The author checklist is not filled yet

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restoring functionality we had before 👍

@Krishna2323

Copy link
Copy Markdown
Contributor

@JS00001 who will fill out the author checklist? I’m not sure how that’s handled since the PR was created by MelvinBot.

@JS00001

JS00001 commented May 7, 2026

Copy link
Copy Markdown
Contributor

@Krishna2323 could you fill it out please? Validating each entry?

@Krishna2323

Copy link
Copy Markdown
Contributor

@JS00001 I can’t edit Melvin’s comment. I think you can just check all the boxes since I’ve already completed the testing on all platforms.

@JS00001
JS00001 merged commit 2f1e0f6 into main May 7, 2026
52 of 54 checks passed
@JS00001
JS00001 deleted the claude-nestedRowHoverAndClick branch May 7, 2026 13:34
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented May 7, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented May 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.69-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site changes are required for this PR.

This is a UI bug fix that restores hover highlighting and click-to-open behavior on nested transaction rows in expanded search result groups on large screens. No user-facing features, workflows, terminology, or settings were added or changed — the existing help site articles remain accurate.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #90048 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants