You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-21] mweb - AI promo modal - Background is black when AI promo modal is opened #93969
Version Number: 9.4.15-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92007 Email or phone of affected tester (no customers):sdjnoisdjdosijsonssjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Other
Action Performed:
Go to staging.new.expensify.com
Log in with a new account.
Complete onboarding.
Expected Result:
Background will not be blank when AI promo modal is opened.
Actual Result:
Background is blank when AI promo modal is opened.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause: This is a regression from #92007 (merged today), which introduced a brand-new carousel render path in FeatureTrainingModal. On mWeb the carousel renders nothing until its onLayout reports a non-zero width, and the carousel container is only given an explicit width on medium-or-larger screens (FeatureTrainingModalCarouselBody.tsx:177). On a narrow (mWeb) viewport the body is rendered inside a BOTTOM_DOCKED modal whose container is height: 'fit-content'. When the width measurement resolves to 0 / doesn't settle, the entire carousel body collapses, the docked sheet collapses with it, and all that remains visible is the modal's full-screen black backdrop — i.e. the reported "blank/black background."
Why mWeb only: The AI promo modal is the first and only consumer of the new carousel branch (it passes pages). The single-page consumers of the exact same modal + transparent navigator (TestDrive, MigratedUserWelcomeModal) render correctly on mWeb, which isolates the regression to the new isCarousel branch and its carouselViewportWidth > 0 render gate (index.tsx:335-363, FeatureTrainingModalCarouselBody.tsx:181-219). On medium+ screens the width is set explicitly, so the carousel always has a width and renders — which is why it passed in the PR's desktop/native testing.
Recommended Fix: Give the carousel container a deterministic size on narrow screens so it cannot collapse to a bare backdrop while the width measurement settles:
In FeatureTrainingModalCarouselBody.tsx:175-188, ensure the outer View stretches to the parent width on narrow screens (e.g. add styles.w100/flex so it isn't dependent solely on an async onLayout measurement before anything paints), and/or seed carouselViewportWidth from windowWidth/width so the first render is never empty.
Verify the fix on an Android mWeb Chrome viewport (the bug is device/timing-sensitive — it did not reproduce in the PR author's own mWeb recording).
Because this is a deploy blocker, the fastest safe resolution is to revert #92007 (or feature-gate the AI promo modal off) and re-land once the narrow-screen carousel layout is fixed and verified on mWeb.
Investigation details & evidence
The modal is shown as a transparent navigation route (AIFeaturesPromoGuard → Navigation.navigate(ROUTES.AI_FEATURES_PROMO_MODAL)), mounted with rootNavigatorScreenOptions.basicModalNavigator — presentation: TRANSPARENT_MODAL, cardStyle.backgroundColor: 'transparent' (useRootNavigatorScreenOptions.ts:56-69). The transparent options are correct and identical to the working sibling modals — so transparency itself is not the bug.
The only dimming layer is the in-component <Modal> backdrop (styles.modalBackdrop = solid black at overlay opacity, styles/index.ts, applied via BaseModal.tsx:368-372). When the carousel body collapses, this backdrop is all that remains — the "black background."
Narrow mWeb uses BOTTOM_DOCKED with height: 'fit-content' and maxHeight: windowHeight (ModalStyleUtils.ts:221-240) — a fit-content sheet whose height depends on children that, in turn, refuse to render until a width is measured. This chicken-and-egg layout is the classic source of an empty/collapsed mWeb sheet.
Carousel render gate: nothing renders unless carouselViewportWidth > 0 (set only from onLayout), and the outer container only receives an explicit width via getWidthStyle(width) when onboardingIsMediumOrLargerScreenWidth is true (FeatureTrainingModalCarouselBody.tsx:177, 181-189, 219).
Alternative considered: a post-onboarding timing race where the transparent modal opens before any screen is painted behind it. This is plausible but less likely to be the primary cause, because other auto/transparent modals using the same navigator do not exhibit this on mWeb — the carousel branch is the variable that changed. A visual mWeb repro would confirm which mechanism dominates.
Confidence: Medium — the regression is conclusively isolated to the new carousel branch (single-page siblings on the same navigator/modal work on mWeb) and the exact black element is identified, but the precise pixel mechanism (width collapse vs. height collapse) should be confirmed with an Android mWeb Chrome repro before landing the fix.
Next Steps: Reply with @MelvinBot implement this to create a draft PR with the narrow-screen carousel fix, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-]mweb - AI promo modal - Background is black when AI promo modal is opened[/-][+][Due for payment 2026-07-21] mweb - AI promo modal - Background is black when AI promo modal is opened[/+]on Jul 14, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.33-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 18, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/faa32b5957200cd3029c85850c49d07cfd6eff38ec2552dc536bc180cc6f8eed
melvin-bot commentedon Jun 18, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92007
melvin-bot commentedon Jun 18, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 18, 2026
Issue Analysis
Root Cause: This is a regression from #92007 (merged today), which introduced a brand-new carousel render path in
FeatureTrainingModal. On mWeb the carousel renders nothing until itsonLayoutreports a non-zero width, and the carousel container is only given an explicit width on medium-or-larger screens (FeatureTrainingModalCarouselBody.tsx:177). On a narrow (mWeb) viewport the body is rendered inside aBOTTOM_DOCKEDmodal whose container isheight: 'fit-content'. When the width measurement resolves to 0 / doesn't settle, the entire carousel body collapses, the docked sheet collapses with it, and all that remains visible is the modal's full-screen black backdrop — i.e. the reported "blank/black background."Why mWeb only: The AI promo modal is the first and only consumer of the new carousel branch (it passes
pages). The single-page consumers of the exact same modal + transparent navigator (TestDrive,MigratedUserWelcomeModal) render correctly on mWeb, which isolates the regression to the newisCarouselbranch and itscarouselViewportWidth > 0render gate (index.tsx:335-363,FeatureTrainingModalCarouselBody.tsx:181-219). On medium+ screens the width is set explicitly, so the carousel always has a width and renders — which is why it passed in the PR's desktop/native testing.Recommended Fix: Give the carousel container a deterministic size on narrow screens so it cannot collapse to a bare backdrop while the width measurement settles:
FeatureTrainingModalCarouselBody.tsx:175-188, ensure the outerViewstretches to the parent width on narrow screens (e.g. addstyles.w100/flexso it isn't dependent solely on an asynconLayoutmeasurement before anything paints), and/or seedcarouselViewportWidthfromwindowWidth/widthso the first render is never empty.Because this is a deploy blocker, the fastest safe resolution is to revert #92007 (or feature-gate the AI promo modal off) and re-land once the narrow-screen carousel layout is fixed and verified on mWeb.
Investigation details & evidence
AIFeaturesPromoGuard→Navigation.navigate(ROUTES.AI_FEATURES_PROMO_MODAL)), mounted withrootNavigatorScreenOptions.basicModalNavigator—presentation: TRANSPARENT_MODAL,cardStyle.backgroundColor: 'transparent'(useRootNavigatorScreenOptions.ts:56-69). The transparent options are correct and identical to the working sibling modals — so transparency itself is not the bug.<Modal>backdrop (styles.modalBackdrop= solid black at overlay opacity,styles/index.ts, applied viaBaseModal.tsx:368-372). When the carousel body collapses, this backdrop is all that remains — the "black background."BOTTOM_DOCKEDwithheight: 'fit-content'andmaxHeight: windowHeight(ModalStyleUtils.ts:221-240) — a fit-content sheet whose height depends on children that, in turn, refuse to render until a width is measured. This chicken-and-egg layout is the classic source of an empty/collapsed mWeb sheet.carouselViewportWidth > 0(set only fromonLayout), and the outer container only receives an explicit width viagetWidthStyle(width)whenonboardingIsMediumOrLargerScreenWidthis true (FeatureTrainingModalCarouselBody.tsx:177,181-189,219).Alternative considered: a post-onboarding timing race where the transparent modal opens before any screen is painted behind it. This is plausible but less likely to be the primary cause, because other auto/transparent modals using the same navigator do not exhibit this on mWeb — the carousel branch is the variable that changed. A visual mWeb repro would confirm which mechanism dominates.
Confidence: Medium — the regression is conclusively isolated to the new carousel branch (single-page siblings on the same navigator/modal work on mWeb) and the exact black element is identified, but the precise pixel mechanism (width collapse vs. height collapse) should be confirmed with an Android mWeb Chrome repro before landing the fix.
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR with the narrow-screen carousel fix, or@MelvinBot <your feedback>to refine this analysis.IuliiaHerets commentedon Jun 18, 2026
Android 12 / Chrome
No AI modal after onboarding
Screenrecorder-2026-06-19-00-34-35-698.1.mp4
Fix AI promo carousel rendering blank on mWeb
melvin-bot commentedon Jul 10, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon Jul 10, 2026
Deploy Blocker #95856 was identified to be related to the PR #94012 that attempted to fix this issue.
melvin-bot commentedon Jul 10, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]mweb - AI promo modal - Background is black when AI promo modal is opened[/-][+][Due for payment 2026-07-21] mweb - AI promo modal - Background is black when AI promo modal is opened[/+]melvin-bot commentedon Jul 14, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 14, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.33-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-21. 🎊
melvin-bot commentedon Jul 14, 2026
@mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]