You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-21] mweb - AI promo modal - Middle page can be skipped easily when swiping through the carousel #93970
Version Number: 9.4.15-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92007 Email or phone of affected tester (no customers):sdjnoisdjdosijsonssjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Other
Action Performed:
Go to staging.new.expensify.com
Log in with a new account.
Complete onboarding.
Swipe through the carousel.
Expected Result:
The middle page will not skip when swiping through the carousel.
Actual Result:
The middle page can be skipped easily when swiping through the carousel.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
On web, pagingEnabled on the carousel's FlatList is not real per-page paging — react-native-web implements it purely as CSS scroll-snap, and the snap points end up on the wrong element, so a fast fling coasts straight past the middle page.
Specifically:
react-native-web maps pagingEnabled to scroll-snap-type: x mandatory on the scroller and scroll-snap-align: start on the scroller's direct children only.
For a FlatList, the only direct child of the underlying ScrollView is the single VirtualizedList content container — so the snap-align lands on that one wrapper, not on each page View (FeatureTrainingModalCarouselBody.tsx:234).
With effectively one snap point, mandatory snapping can't arrest the browser's native fling momentum page-by-page, so a quick swipe lands on the last page. The native-only props that would fix this (disableIntervalMomentum, snapToInterval, decelerationRate) are no-ops in react-native-web.
This matches the reported platforms — mWeb Chrome and desktop Chrome/Safari (web), not native App.
node_modules/react-native-web/dist/exports/ScrollView/index.js:558-567 — scroll-snap-align is wrapped around the ScrollView's direct React children only; a FlatList's direct child is the VirtualizedList content container, so per-page Views are not snap points.
Grep of that file shows zero handling of disableIntervalMomentum / snapToInterval / decelerationRate — they don't affect web.
No patches/react-native-web override touches this behavior.
What changes do you think we should make in order to solve the problem?
Make each page a real CSS snap point on web by applying scroll-snap-align: start to the per-item wrapper View at FeatureTrainingModalCarouselBody.tsx:234 (CSS scroll-snap recognizes any descendant of the scroll container as a snap point, not just direct children). This is a web-only style (scrollSnapAlign), added via a platform-specific style helper since it isn't in RN's style types.
For native (iOS/Android) parity — defense in depth even though native paging already works — also add disableIntervalMomentum and snapToInterval={carouselViewportWidth} to the FlatList; these are ignored on web.
What alternative solutions did you explore? (Optional)
Rendering the pages as direct children of the scroll container (so RNW's built-in scroll-snap-align applies) would also work, but is a larger refactor than tagging each page with the snap-align style. There is no existing carousel in the repo that proves a cleaner web anti-skip technique — the only other horizontal carousel (MoneyRequestReportPreviewContent.tsx) relies on snapToOffsets/decelerationRate, which are native-only.
Next Steps for Contributor+ team: To accept:@MelvinBot implement this to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]mweb - AI promo modal - Middle page can be skipped easily when swiping through the carousel[/-][+][Due for payment 2026-07-21] mweb - AI promo modal - Middle page can be skipped easily when swiping through the carousel[/+]on Jul 14, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.33-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 18, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/9f117412c46ac8861a1fc504932b28c594a7fb96f56001ef680ab9c8a664f225
melvin-bot commentedon Jun 18, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92007
melvin-bot commentedon Jun 18, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 18, 2026
Proposal
What is the root cause of that problem?
On web,
pagingEnabledon the carousel'sFlatListis not real per-page paging — react-native-web implements it purely as CSS scroll-snap, and the snap points end up on the wrong element, so a fast fling coasts straight past the middle page.Specifically:
pagingEnabledtoscroll-snap-type: x mandatoryon the scroller andscroll-snap-align: starton the scroller's direct children only.FlatList, the only direct child of the underlying ScrollView is the singleVirtualizedListcontent container — so the snap-align lands on that one wrapper, not on each page View (FeatureTrainingModalCarouselBody.tsx:234).disableIntervalMomentum,snapToInterval,decelerationRate) are no-ops in react-native-web.This matches the reported platforms — mWeb Chrome and desktop Chrome/Safari (web), not native App.
Evidence
node_modules/react-native-web/dist/exports/ScrollView/index.js:641-649—pagingEnabledHorizontal: {scrollSnapType: 'x mandatory'},pagingEnabledChild: {scrollSnapAlign: 'start'}.node_modules/react-native-web/dist/exports/ScrollView/index.js:558-567—scroll-snap-alignis wrapped around the ScrollView's direct React children only; a FlatList's direct child is the VirtualizedList content container, so per-page Views are not snap points.disableIntervalMomentum/snapToInterval/decelerationRate— they don't affect web.patches/react-native-weboverride touches this behavior.FeatureTrainingModalCarouselBody.tsx:222-247.What changes do you think we should make in order to solve the problem?
Make each page a real CSS snap point on web by applying
scroll-snap-align: startto the per-item wrapper View atFeatureTrainingModalCarouselBody.tsx:234(CSS scroll-snap recognizes any descendant of the scroll container as a snap point, not just direct children). This is a web-only style (scrollSnapAlign), added via a platform-specific style helper since it isn't in RN's style types.For native (iOS/Android) parity — defense in depth even though native paging already works — also add
disableIntervalMomentumandsnapToInterval={carouselViewportWidth}to the FlatList; these are ignored on web.What alternative solutions did you explore? (Optional)
Rendering the pages as direct children of the scroll container (so RNW's built-in
scroll-snap-alignapplies) would also work, but is a larger refactor than tagging each page with the snap-align style. There is no existing carousel in the repo that proves a cleaner web anti-skip technique — the only other horizontal carousel (MoneyRequestReportPreviewContent.tsx) relies onsnapToOffsets/decelerationRate, which are native-only.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement thisto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
IuliiaHerets commentedon Jun 18, 2026
Android 12 / Chrome
No AI modal after onboarding
Screenrecorder-2026-06-19-00-34-35-698.mp4
fix Expensify#93970
Fix AI promo carousel skipping middle page on fast swipe
melvin-bot commentedon Jul 10, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon Jul 10, 2026
Deploy Blocker #95856 was identified to be related to the PR #94012 that attempted to fix this issue.
melvin-bot commentedon Jul 10, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]mweb - AI promo modal - Middle page can be skipped easily when swiping through the carousel[/-][+][Due for payment 2026-07-21] mweb - AI promo modal - Middle page can be skipped easily when swiping through the carousel[/+]melvin-bot commentedon Jul 14, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 14, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.33-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-21. 🎊
melvin-bot commentedon Jul 14, 2026
@mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]