Skip to content

[Due for payment 2026-07-21] Android & iOS - Native share - Share page does not open when AI promo modal is opened #93976

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.15-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92007
Email or phone of affected tester (no customers): sdjnoisdjdosijsonssjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.5
App Component: Other

Action Performed:

  1. Launch Expensify app.
  2. Create a new Gmail account.
  3. Complete onboarding.
  4. Kill and reopen app.
  5. When AI promo modal opens, background app.
  6. Open device gallery and share a photo to Expensify app.

Expected Result:

Share page will open.

Actual Result:

Share page does not open. AI promo modal persists.

This issue also happens when user opens report link from external app when AI promo modal is opened. The report cannot be opened when AI promo modal is opened.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7184897_1781808904111.ScreenRecording_06-19-2026_02-51-16_1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7184897

Activity

  1. applause-bot commented on Jun 18, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/5d18bb2826620fab8b45e9356aea28b89d6c9635add91e5095c3ce33b42913c5

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 18, 2026
  3. melvin-bot commented on Jun 18, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #92007

  4. melvin-bot commented on Jun 18, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 18, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 18, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The AI Features Promo Modal added in #92007 installs a navigation guard that blocks every navigation action while the modal is on top of the stack — including the deep‑link/share‑intent navigation that opens the share page or a report from an external app.

    In AIFeaturesPromoGuard.shouldBlockWhileModalActive the only allowed actions are DISMISS_MODAL and GO_BACK. A native share or an external report link is dispatched as a NAVIGATE/PUSH/RESET action, none of which are allow‑listed, so the guard returns BLOCK and the navigation is silently dropped — the share page never opens and the modal persists.

    Because nothing in the background/deep‑link path dismisses the modal, the block never clears until the user manually closes the modal. This is purely an Expensify/App issue — the guard lives entirely in the App repo, so it can be fixed here.

    Evidence chain (high confidence)
    1. Every navigation action is routed through evaluateGuards before routing, in RootStackRouter.getStateForAction. A BLOCK result returns the unchanged state (no navigation).
    2. evaluateGuards short‑circuits on the first BLOCK, and AIFeaturesPromoGuard is registered: guards/index.ts:78-88,107-109.
    3. The share page (SHARE_MODAL_NAVIGATOR → SHARE.ROOT, path ROUTES.SHARE_ROOT) and report links are root‑stack routes reached via deep‑link / Navigation.navigate → linkTo → dispatch, all of which hit the router above. So the blocked action is exactly what stops the share page / report from opening.
    4. The guard only sets hasRedirectedToAIFeaturesPromoModal = false when the product training is marked dismissed (the NVP_DISMISSED_PRODUCT_TRAINING callback). Backgrounding the app or an incoming share/deep‑link does not dismiss it, so the block stays active. Dismissal only happens on an explicit user close (AIFeaturesPromoModal/index.tsx:64-73).

    Alternative considered: MigratedUserWelcomeModalGuard has byte‑identical block logic, so it carries the same latent bug — but its onClose actively navigates to Search, which masks the symptom in normal use. The AI promo guard has no such escape, which is why this surfaces now on the new feature.

    What changes do you think we should make in order to solve the problem?

    Stop the guard from blocking externally‑triggered navigation. When the modal is active, the guard should allow (or dismiss the modal in favor of) navigation that targets the share modal navigator or a report deep‑link, instead of blocking all non‑DISMISS_MODAL/GO_BACK actions.

    Concretely, in shouldBlockWhileModalActive, broaden the allow‑list so deep‑link / share‑intent navigation is permitted (e.g. allow actions whose target is SHARE_MODAL_NAVIGATOR or a report route, or detect that the action originates from an external URL). The intent of the block is only to stop the user from swiping/navigating away inside the app — it should not swallow new top‑level intents from outside the app.

    What alternative solutions did you explore? (Optional)

    • Auto‑dismiss the modal when an external deep‑link/share intent arrives (mark the product training dismissed + allow the navigation), so the block clears and the user lands where the link points.
    • Revert Concierge AI Feature Promo Modal #92007 — since this is a deploy blocker on a brand‑new feature, reverting is the fastest way to unblock the deploy if a targeted fix can't land quickly. The same fix would also want to be applied to MigratedUserWelcomeModalGuard, which shares the identical block logic.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93976) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. IuliiaHerets commented on Jun 18, 2026

    @IuliiaHerets

    Xiaomi Redmi Note 10 / Android 12
    App 9.4.15-2
    No AI modal

    Screenrecorder-2026-06-19-00-50-24-534.mp4
  8. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. lanitochka17 commented on Jul 10, 2026

    @lanitochka17

    Deploy Blocker #95856 was identified to be related to the PR #94012 that attempted to fix this issue.

  10. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. changed the title [-]Android & iOS - Native share - Share page does not open when AI promo modal is opened[/-] [+][Due for payment 2026-07-21] Android & iOS - Native share - Share page does not open when AI promo modal is opened[/+] on Jul 14, 2026
  13. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.33-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-21. 🎊

  14. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    @mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions