[CP Staging] Revert "Use fallback user avatar in cases where the user is unknown to us" by mountiny · Pull Request #41087 · Expensify/App

mountiny · 2024-04-26T11:17:35Z

Reverts #39229

Fixed Issues

$ #41014
$ #40989
$ #40996
PROPOSAL:

Tests

fix for #41014

Open a chat
Press @ and check Concierge
Avatar should be displayed on Concierge in mention list

#40989

Go to staging.new.expensify.com
Go to Account settings > Workspaces > any workspace
Go to Members section
Go offline
Invite a new user
Click on the new user in member list
Click Profile
Verify the page loads fine

Screen.Recording.2024-04-26.at.13.59.04.mp4

#40996

Go to staging.new.expensify.com
Submit a request to a user you haven't chatted with before
Click on 'FAB'
Refresh the page
Verify the avatar for the QAB action is same as the avatar of the new account you started chat with

Screen.Recording.2024-04-26.at.14.00.48.mp4

After the refresh

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…o us"

github-actions · 2024-04-26T11:50:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41087/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41087/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41087/NewExpensify.dmg	https://41087.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2024-04-26T12:07:59Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pecanoro · 2024-04-26T12:10:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…fallback-avatar [CP Staging] Revert "Use fallback user avatar in cases where the user is unknown to us" (cherry picked from commit 7885af4)

OSBotify · 2024-04-26T12:39:57Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.66-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-26T13:18:56Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.66-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-26T22:58:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Revert "Use fallback user avatar in cases where the user is unknown t…

fa29a35

…o us"

mountiny added the Ready To Build label Apr 26, 2024

mountiny self-assigned this Apr 26, 2024

mountiny changed the title ~~Revert "Use fallback user avatar in cases where the user is unknown to us"~~ [CP Staging] Revert "Use fallback user avatar in cases where the user is unknown to us" Apr 26, 2024

mountiny marked this pull request as ready for review April 26, 2024 12:07

mountiny requested a review from a team as a code owner April 26, 2024 12:07

melvin-bot Bot requested review from thesahindia and removed request for a team April 26, 2024 12:07

mountiny removed the request for review from thesahindia April 26, 2024 12:09

pecanoro approved these changes Apr 26, 2024

View reviewed changes

mountiny mentioned this pull request Apr 26, 2024

[HOLD] [CP Staging] Fix concierge avatar in mention suggestion #41034

Closed

48 of 50 tasks

pecanoro merged commit 7885af4 into main Apr 26, 2024

pecanoro deleted the revert-39229-kicu/38743-use-fallback-avatar branch April 26, 2024 12:13

github-actions Bot mentioned this pull request Apr 26, 2024

Deploy Checklist: New Expensify 2024-04-25 #40981

Closed

53 tasks done

melvin-bot Bot mentioned this pull request Apr 26, 2024

[Payment Request] [$250] Mention - Avatar is not displaying on Concierge in mention list #41014

Closed

4 of 6 tasks

gijoe0295 mentioned this pull request Apr 27, 2024

[HOLD for payment 2024-05-08] [$250] App Crashes When Exiting and Re-entering Thread in Offline #41130

Closed

4 of 6 tasks

MelvinBot mentioned this pull request Mar 18, 2026

[Due for payment 2026-05-15] [$250] Invited member to expense report sees the chat with fallback avatar on LHN #85240

Closed

2 of 7 tasks

Navigation Menu

Repository navigation

[CP Staging] Revert "Use fallback user avatar in cases where the user is unknown to us" - #41087

[CP Staging] Revert "Use fallback user avatar in cases where the user is unknown to us"#41087
pecanoro merged 1 commit into
mainfrom
revert-39229-kicu/38743-use-fallback-avatar

mountiny commented Apr 26, 2024 •

edited by pecanoro

Loading

Uh oh!

github-actions Bot commented Apr 26, 2024

Uh oh!

melvin-bot Bot commented Apr 26, 2024

Uh oh!

pecanoro commented Apr 26, 2024 •

edited

Loading

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mountiny commented Apr 26, 2024 • edited by pecanoro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed Issues

Tests

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Apr 26, 2024

Uh oh!

melvin-bot Bot commented Apr 26, 2024

Uh oh!

pecanoro commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mountiny commented Apr 26, 2024 •

edited by pecanoro

Loading

pecanoro commented Apr 26, 2024 •

edited

Loading