Skip to content

Deploy Checklist: New Expensify 2024-04-25 #40981

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2024-04-25#40981
Assignees
mountinyapplausebot
Labels
DailyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@github-actions
github-actions
bot
opened on Apr 25, 2024

Release Version: 1.4.66-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. github-actions
    added
    StagingDeployCash
    on Apr 25, 2024
  2. github-actions
    assigned
    applausebot
    on Apr 25, 2024
  3. kavimuru
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Apr 25, 2024
  4. mountiny
    added
    DailyKSv2
    on Apr 25, 2024
  5. mountiny
    self-assigned this
    on Apr 25, 2024

  6. rlinoz commented on Apr 25, 2024

    @rlinoz
    rlinoz
    on Apr 25, 2024
    Contributor

    Demoted #40991

  7. roryabraham commented on Apr 25, 2024

    @roryabraham
    roryabraham
    on Apr 25, 2024
    Contributor

    Demoted #41017

  8. francoisl commented on Apr 26, 2024

    @francoisl
    francoisl
    on Apr 26, 2024
    Contributor

    Demoted #41031 as can't repro

  9. mountiny commented on Apr 26, 2024

    @mountiny
    mountiny
    on Apr 26, 2024
    Contributor

    demoted #41000

  10. kavimuru commented on Apr 26, 2024

    @kavimuru
    kavimuru
    on Apr 26, 2024

    Regression is 2% left in the TR
    #40718 failing with #40914 and #40978
    #40676 failing with #40911 reproduced in production checking it off
    #40532 Validation pending in mweb
    #41047 - validation pending

  11. mountiny commented on Apr 26, 2024

    @mountiny
    mountiny
    on Apr 26, 2024
    Contributor

    demoted #41065

  12. mountiny commented on Apr 26, 2024

    @mountiny
    mountiny
    on Apr 26, 2024
    Contributor

    Demoted #40993 - minor UX issue

  13. mountiny commented on Apr 26, 2024

    @mountiny
    mountiny
    on Apr 26, 2024
    Contributor

    demoted #41011 - its very specific issue for limited number of devices too

  14. mountiny commented on Apr 26, 2024

    @mountiny
    mountiny
    on Apr 26, 2024
    Contributor

    checking #41014, #40989 and #40996 off as they have been fixed by a revert

  15. kavimuru commented on Apr 26, 2024

    @kavimuru
    kavimuru
    on Apr 26, 2024

    Regression is completed

  16. thienlnam commented on Apr 26, 2024

    @thienlnam
    thienlnam
    on Apr 26, 2024
    Contributor

    There's a fresh crash

    CameraDeviceDetails.getFormats

    Fatal Exception: java.lang.IllegalArgumentException
lower must be less than or equal to upper
android.util.Range.<init> (Range.java:59)
com.mrousavy.camera.core.CameraDeviceDetails.getFormats (CameraDeviceDetails.java:125)
com.mrousavy.camera.core.CameraDeviceDetails.toMap (CameraDeviceDetails.java:79)
com.mrousavy.camera.CameraDevicesManager.getDevicesJson (CameraDevicesManager.kt:87)
com.mrousavy.camera.CameraDevicesManager.sendAvailableDevicesChangedEvent (CameraDevicesManager.kt:94)
com.mrousavy.camera.CameraDevicesManager$initialize$1.invokeSuspend (CameraDevicesManager.kt:71)
kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)

    Looks related to vision camera - going to bring up in expensify-margelo 1.4.61-8 (1001046108)

  17. mountiny commented on Apr 26, 2024

    @mountiny
    mountiny
    on Apr 26, 2024
    Contributor

    Graphs looking alright and new crash has been reported by Jack above and shared with Margelo

  18. mountiny commented on Apr 26, 2024

    @mountiny
    mountiny
    on Apr 26, 2024
    Contributor

    :shipit:

  19. mountiny
    closed this as completedon Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DailyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions