Repository navigation
[HOLD for payment 2024-06-06] [HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] Quick action - Fallback avatar is displayed on quick action after user avatar loads #40996
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause - Internal Team
Issue found when executing PR #39229
Action Performed:
- Go to staging.new.expensify.com
- Submit a request to a user you haven't chatted with before
- Click on 'FAB'
Expected Result:
Avatar on quick action should be similar to the one loaded on report and LHN of the new user
Actual Result:
Avatar on quick action remained to be a fallback avatar
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Apr 25, 2024
Triggered auto assignment to @flodnv (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 25, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 25, 2024
@flodnv FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
ZhenjaHorbach commentedon Apr 25, 2024
I think it's dupe
#40536
Because they have the same root cause
mountiny commentedon Apr 26, 2024
I am looking if reverting #39229 will fix this
mountiny commentedon Apr 26, 2024
Making a revert here #41087
grgia commentedon Apr 26, 2024
cc @Kicu
mountiny commentedon Apr 26, 2024
This was not fully fixed with the revert, however, after refresh I have got the correct avatar there.
Screen.Recording.2024-04-26.at.14.00.48.mp4
@Kicu would you be able to include this flow in your testing steps for the second PR?
mountiny commentedon Apr 26, 2024
Can you please comment on this issue so I can assign you and @grgia so you can then address this avatar logic, please? Thanks!
41 remaining items
melvin-bot commentedon May 29, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Kicu commentedon May 29, 2024
FYI a PR that implements similar functionality that the original PR was merged. If by any chance the bug would come back please ping me. But I believe it should be fixed.
[-][HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] Quick action - Fallback avatar is displayed on quick action after user avatar loads[/-][+][HOLD for payment 2024-06-06] [HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] Quick action - Fallback avatar is displayed on quick action after user avatar loads[/+]melvin-bot commentedon May 30, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 30, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-06. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 30, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: