Skip to content

fix: keep modal content mounted during close animation to prevent content flash - #90511

Closed
abzokhattab wants to merge 1 commit into
Expensify:mainfrom
abzokhattab:fix/90510-reanimated-modal-content-flash-on-close
Closed

abzokhattab wants to merge 1 commit into
Expensify:mainfrom
abzokhattab:fix/90510-reanimated-modal-content-flash-on-close

Conversation

@abzokhattab

@abzokhattab abzokhattab commented May 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When PR #90358 refactored ReanimatedModal, it replaced isVisibleState (a one-render-lagged state mirror of the isVisible prop) with direct references to isVisible. This introduced a timing gap during the close animation:

  1. isVisible prop becomes false (parent signals close)
  2. isContainerOpen is still true (exit animation hasn't completed yet)
  3. isTransitioning = isVisible !== isContainerOpen = true → modalVisibility = true — the RN <Modal> wrapper stays mounted correctly
  4. But {isVisible && containerView} renders nothing — content vanishes immediately while the transparent modal wrapper is still open, making the chat list visible through it as a flash

Fix: Replace {isVisible && containerView} with {modalVisibility && containerView} in both the avoidKeyboard and FocusTrapForModal branches. modalVisibility is already isVisible || isTransitioning, so content stays mounted for the full duration of the exit animation and unmounts cleanly once onCloseCallBack fires.

Fixed Issues

$ #90510
$ #90438
$ #90463
$ #90442

Tests

  1. Open the Search RHP (click the search icon from Inbox)
  2. Close it by clicking outside or pressing ESC
  3. Verify no content flash / chats briefly appearing where the RHP was

Offline tests

Not applicable — modal open/close behavior is not network-dependent.

QA Steps

  1. Open staging.new.expensify.com
  2. Navigate to Inbox
  3. Click the search icon (top right) to open the Search RHP
  4. Close it by clicking outside the panel or pressing ESC
  5. Verify the RHP dismisses cleanly with no brief flash of chats on top of the screen

#90438 — Distance RHP animates correctly after changing distance rate:
6. Go to Workspace Settings > Distance Rates
7. Tap Settings > Unit and select a different rate
8. Verify the RHP animates in and out correctly (no freeze or missing animation)

#90442 — Delete actions work immediately after closing a modal (Android):
9. Open any expense report and tap More > Delete > Delete
10. Verify the delete confirmation modal appears without delay and the expense is removed
11. Repeat for other delete flows: saved search, category, tag, distance rate — all should respond immediately

#90463 — Import spreadsheet modal appears after dismissing an upgrade modal (Android):
12. Go to Workspace Settings > Tags, enable tags, add one
13. Tap More > Import spreadsheet > Multi-level of tags > Upgrade > Got it Thanks
14. Tap Switch Tag Levels
15. Verify the Import spreadsheet modal appears correctly with a Choose file button

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@abzokhattab
abzokhattab requested review from a team as code owners May 13, 2026 13:38
@melvin-bot
melvin-bot Bot requested review from Pujan92 and heyjennahay and removed request for a team May 13, 2026 13:38
@melvin-bot

melvin-bot Bot commented May 13, 2026

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from a team, mkhutornyi and roryabraham and removed request for a team May 13, 2026 13:38
@melvin-bot

melvin-bot Bot commented May 13, 2026

Copy link
Copy Markdown

@mkhutornyi @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…tent flash

When isVisible becomes false, isTransitioning is true until the exit animation
completes. Rendering containerView with modalVisibility (isVisible || isTransitioning)
instead of isVisible alone ensures the content stays mounted through the full
fade-out, matching the previous isVisibleState behavior that was removed in Expensify#90358.

Fixes Expensify#90510
@abzokhattab
abzokhattab force-pushed the fix/90510-reanimated-modal-content-flash-on-close branch from 50633d1 to 2d3f9ec Compare May 13, 2026 13:40

@mkhutornyi mkhutornyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix all linked blockers #90510 #90463 #90465 #90442 #90438?

@abzokhattab

Copy link
Copy Markdown
Contributor Author

let me verify all others i fixed most of them

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

@Pujan92

Pujan92 commented May 13, 2026

Copy link
Copy Markdown
Contributor

Do I need to review as I got assigned first here?

@abzokhattab

Copy link
Copy Markdown
Contributor Author

i am not sure if we need c+ review, as these are regressions for a PR we worked on

@mkhutornyi

Copy link
Copy Markdown
Contributor

I think better to revert since offending PR is just a refactor.

I can confirm all linked blockers are not reproducible in revert.

@mkhutornyi

Copy link
Copy Markdown
Contributor

#90438 is still reproducible on this branch. App freezes this time, even worse.

Screen.Recording.2026-05-13.at.3.10.15.PM.mov

@abzokhattab

Copy link
Copy Markdown
Contributor Author

I think better to revert since offending PR is just a refactor.
I can confirm all linked blockers are not reproducible in #90514.

agree yes i think it didnt fix all of them

@abzokhattab

Copy link
Copy Markdown
Contributor Author

created a revert here #90522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants