Repository navigation
Approved injection - #4
Merged
Merged
Conversation
estebanmino
added a commit
that referenced
this pull request
Apr 22, 2021
* Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com>
sethkfman
added a commit
that referenced
this pull request
Apr 22, 2021
* scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com>
sethkfman
added a commit
that referenced
this pull request
Jun 2, 2021
* updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
sethkfman
added a commit
that referenced
this pull request
Jun 17, 2021
* Add missing required prop in tests (#2727) * Add resolution for ws to address security vuln (#2737) * Add iconUrls to allowed list of keys (#2728) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> * Feature/use same media player (#2711) * Use same media player * Remove unused react-native-video-controls * Remove SVG and image toggle * Add onBack * Update snapshot * only change one heading * Use scaling * Feature/bitrise circle ci hybrid (#2713) * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> * Bugfix/fix ws resolution (#2742) * Revert "Add resolution for ws to address security vuln (#2737)" This reverts commit e2226ca. * Use improved-yarn-audit and exclude 1748 * Convert token id to hexadecimal for collectible transfer (#2703) * Convert token id to hexadecimal for transfer * Add test for toHexadecimal Co-authored-by: Ricky Miller <ricky.miller@gmail.com> * make null conversionrate safe (#2706) Co-authored-by: ricky <ricky.miller@gmail.com> * @metamask/mobile-provider@2.1.0 (#2626) * @metamask/mobile-provider@2.1.0 * yarn * bugfix/notifications reducer (#2741) * Feature/simplify custom gas (#2738) * Use single method for fast/average/slow * Use newly added constants * Educate gas fees (#2611) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> * On-Ramp: Refactor and Wyre countries (#2617) Co-authored-by: Esteban Miño <efmino@uc.cl> * Swaps: Allow every token on user wallet to be swapped (#2701) * Swaps: Update Market price unavailable and Price impact text (#2702) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> * @metamask/controllers@10.1.0 (#2749) * bump * bump * yarn * bugfix/notification visibility (#2746) * isvisible * onfinished * removeonappstate * Circleci fix (#2757) * reintallpods * min9.0 * order * circleci * 12.5 * branch * v2.5.0 (#2748) * Bump * Update CHANGELOG.md * add heading back * bump to 748 * bump date as well * Use MediaPlayer (#2759) * Use MediaPlayer * height -> HEIGHT * Add isInteraction: false (#2777) * Fix: empty state when using fiat on non-mainnet transactions (#2776) * Add mainnet condition * Implement secondary values * Design adjustments * Fix boldness * Update test Co-authored-by: ricky <ricky.miller@gmail.com> * update CHANGELOG.md (#2796) * update changelog * update * bump version code * Updated config.yml * Optional chaining dollarBalance (#2809) * bumped version and updated changelog (#2810) * bumped version and updated changelog * removed config.yml update * removed changelog Co-authored-by: ricky <ricky.miller@gmail.com> Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com> Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
sethkfman
added a commit
that referenced
this pull request
Jul 23, 2021
* VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * updated bitrise config * updated conflicts * removed conflicts * yarn.lock update * test deploy build * e2e updates * updated for e2e testing * updated android e2e step * android e2e test prep * added updates to ios e2e * build min update for e2e test * updated ios e2e * switched to debug e2e tests * updated debug e2e scripts * updated detox commands * updated ios e2e steps * build release * removed kill-start server * added the restart server adb * shifted iOS to debug build for e2e * update release script * ios release build * updated sentry script * updated sentry script path * updated sentry paths and install * test release * triggered tests * updated ios e2e for Detox Utils * break out build & test * split fix syntax issue * fix syntax issue * updated e2e tests * updated e2e * ios e2e update * test ios e2e * updated timeout * updated ios to use yarn * added cache e2e ios * added cache e2e ios * run both e2e tests * removed fastlane, updated version bump to use a variable * updated script print out and workflow * test release * removed console.log, cleaned up comments, fix regex on bump * updated target version * setup final workflow state * updated bitrise.yml formatting uncommented deploy to store and uncommented bump * reset the min sdk version * removed duplicate detox install * version number update * reformatted yml Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
sethkfman
added a commit
that referenced
this pull request
Aug 5, 2021
* Add missing required prop in tests (#2727) * Add resolution for ws to address security vuln (#2737) * Add iconUrls to allowed list of keys (#2728) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> * Feature/use same media player (#2711) * Use same media player * Remove unused react-native-video-controls * Remove SVG and image toggle * Add onBack * Update snapshot * only change one heading * Use scaling * Feature/bitrise circle ci hybrid (#2713) * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> * Bugfix/fix ws resolution (#2742) * Revert "Add resolution for ws to address security vuln (#2737)" This reverts commit e2226ca. * Use improved-yarn-audit and exclude 1748 * Convert token id to hexadecimal for collectible transfer (#2703) * Convert token id to hexadecimal for transfer * Add test for toHexadecimal Co-authored-by: Ricky Miller <ricky.miller@gmail.com> * make null conversionrate safe (#2706) Co-authored-by: ricky <ricky.miller@gmail.com> * @metamask/mobile-provider@2.1.0 (#2626) * @metamask/mobile-provider@2.1.0 * yarn * bugfix/notifications reducer (#2741) * Feature/simplify custom gas (#2738) * Use single method for fast/average/slow * Use newly added constants * Educate gas fees (#2611) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> * On-Ramp: Refactor and Wyre countries (#2617) Co-authored-by: Esteban Miño <efmino@uc.cl> * Swaps: Allow every token on user wallet to be swapped (#2701) * Swaps: Update Market price unavailable and Price impact text (#2702) Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> * @metamask/controllers@10.1.0 (#2749) * bump * bump * yarn * bugfix/notification visibility (#2746) * isvisible * onfinished * removeonappstate * Circleci fix (#2757) * reintallpods * min9.0 * order * circleci * 12.5 * branch * v2.5.0 (#2748) * Bump * Update CHANGELOG.md * add heading back * bump to 748 * bump date as well * Use MediaPlayer (#2759) * Use MediaPlayer * height -> HEIGHT * Add isInteraction: false (#2777) * Fix: empty state when using fiat on non-mainnet transactions (#2776) * Add mainnet condition * Implement secondary values * Design adjustments * Fix boldness * Update test Co-authored-by: ricky <ricky.miller@gmail.com> * update CHANGELOG.md (#2796) * update changelog * update * bump version code * Updated config.yml * Optional chaining dollarBalance (#2809) * bumped version and updated changelog (#2810) * bumped version and updated changelog * removed config.yml update * removed changelog * Lionbridge latest translations for secret recovery phrase and subtitle files (#2743) * updated translation files with latest translations for secret recovery phrase * added subtitles to secret phrase videos * added english subtitles * added urls for translations and updated video players to show subtitles * updated subtitle location * updated translation files with latest secret recovery text * removed subtitle logic from player * update translations * Review Translations (#2806) * Lionbridge * Lionbridge * Client Update * Lionbridge Co-authored-by: Brennan <Mark.Brennan@lionbridge.com> Co-authored-by: !corpitSVCUFC <!corpitSVCUFC@corpnet.liox.org> * bumped version and updated changelog * Update subtitles-en.vtt removed formatting * Optional chaining dollarBalance (#2809) * bumped version and updated changelog * moved files into folder * removed duplicate swaps section * updated video and subtitle location Co-authored-by: Brennan <Mark.Brennan@lionbridge.com> Co-authored-by: !corpitSVCUFC <!corpitSVCUFC@corpnet.liox.org> Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com> * bumped version (#2843) * Don't render swap router address in recents (#2823) * Don't render swap router address in recents, fixes: #2822 * Use getSwapsContractAddress * rename toLowerCaseCompare to toLowerCaseEquals * Update test * Rename * Remove Picker deprecation warning (#2709) Use @react-native-community/picker * Improvement/react navigation upgrade 5 (#2731) * Move to new dependencies * move navigation.getparam to route.params * add navigationOptions * Fix dismiss and drawer working * Fix remaining route params * Fix switch navigator and fiat on ramp nav * Fix routename and pop * Remove screen props * Fix deeplink navigation * Fix navigation for inner screens * Ignore navigation warning * Fix get route * Fix showing protect wallet modal * Add route to proptypes * Add more missing proptypes * Update tests * Fix some more navigations * Update collectibles navigatoin * Use useNavigation * Use optional chaining on `dangerouslyGetParent()` * Removing ?? null and ?? undefined * Reorganize nav imports in App/index * Update findRouteNameFromNavigatorState * Remove noop functions * Adding testing for navigation * Add more navigation tests * Add comment explaining the test files * Remove unnecessary boolean casting * Remove unnecessary variable * Remove unnecessary boolean casting * Fixes navigation issues * Fix navigation issues * Fix QR scanner * fixed enroll navigation reset issue * Fix going to wallet view * updated test cases * Fix simple notification * Fix going to onboarding * added snapshots to test * fixed what new modal test * added picker to package.json * yarn clean * yarn update command * snapshot update * removed the dive method on the wrapper * snapshot update * update yarn unit test * commented out cache in build step * Bug/fix nft gesture experience (#2862) * Fix collections modal * Make eslint happy * Clean up modal code TODO: Converting components into hooks will save us from re-renders and from doing things like waiting to focus on inputs * Remove in-house safe area from reusable modal for now * Fix scroll interaction in collectible modal action sheet * Use color from overlay * Add test snap files * Update snapshots and make tests pass * uncommented cache for bitrise Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: Cal Leung <cleun007@gmail.com> * Swaps: Fix isZero undefined error (#2883) * Fix time formatting on transactions (#2854) * [Optimism] Feature/custom network gas estimates (#2865) * Move to new dependencies * move navigation.getparam to route.params * add navigationOptions * Fix dismiss and drawer working * Fix remaining route params * Fix switch navigator and fiat on ramp nav * Fix routename and pop * Remove screen props * Fix deeplink navigation * Fix navigation for inner screens * Ignore navigation warning * Fix get route * Fix showing protect wallet modal * Add route to proptypes * Add more missing proptypes * Update tests * Fix some more navigations * Update collectibles navigatoin * Use useNavigation * Use optional chaining on `dangerouslyGetParent()` * Removing ?? null and ?? undefined * Reorganize nav imports in App/index * Update findRouteNameFromNavigatorState * Remove noop functions * Adding testing for navigation * Add more navigation tests * Add comment explaining the test files * Remove unnecessary boolean casting * Remove unnecessary variable * Remove unnecessary boolean casting * Fixes navigation issues * Fix navigation issues * Fix QR scanner * fixed enroll navigation reset issue * Fix going to wallet view * updated test cases * Fix simple notification * Fix going to onboarding * added snapshots to test * fixed what new modal test * added picker to package.json * yarn clean * yarn update command * snapshot update * removed the dive method on the wrapper * snapshot update * update yarn unit test * added logic for gas calculations on custom networks identified by the network controller * added test controller * updated path for temp controller * updated for local file ref * update lock for local dep * updated dep * disable cache * updated dep * updated dep * added stub for getTokenListState * removed cache comments * removed console.log * updated spacing * update token list get and added todo * added undefined check * updated the logic for contractMap:wq * updated logic for token list * updated getTokensList * updated lock file * cache commented on bitrise * updated yarn * added resolutions for pbkdf * updated package * added resolutions * updated controllers and engine code * updated snapshots * refactor conditional * Remove hard coded upper limit to gas limit (#2884) * updated controller version * updated yarn lock Co-authored-by: andrepimenta <andrepimenta7@gmail.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Dan J Miller <danjm.com@gmail.com> Co-authored-by: ricky <ricky.miller@gmail.com> * RC - v2.6.0 * RC v2.6.0 - yarn lock update & version code bump (#2888) * fixed yarn lock file, deleted local contrller, updated package * updated lock * updated lock * version code bump * Remove broken optional native dependency (#2882) All native dependencies that fail to compile when installing have been removed from the project. The only remaining example of this was a transitive dependency of `dnode`, which was an unused direct dependency. It has been removed. It was not imported anywhere, but it was referenced as a variable name in one unused module. This module has also been removed. * Fix prop type warning (#2821) * fix prop type warning * update snapshot * RC 2.6.0 - SWAPS fix (#2900) * added optional to pop call and bumped version code * trigger rc 2.6.0 build * remove RC build trigger * moved changelogs Co-authored-by: ricky <ricky.miller@gmail.com> Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com> Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Alex Donesky <alex.donesky@consensys.net> Co-authored-by: Brennan <Mark.Brennan@lionbridge.com> Co-authored-by: !corpitSVCUFC <!corpitSVCUFC@corpnet.liox.org> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Dan J Miller <danjm.com@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
sethkfman
pushed a commit
that referenced
this pull request
Sep 3, 2021
* Add jest test template * Add watch command * Small feedback fixes * Update package.json Co-authored-by: Thomas Huang <tmashuang@users.noreply.github.com> * Update README.md * Use esm module syntax * Update jest.config.js Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com> Co-authored-by: Thomas Huang <tmashuang@users.noreply.github.com>
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * disabled circle CI and added back slack bot announcement * commented all CI related tasks * revert bitrise specific scripting * commented out bitrise release triggers * removed ci commneted code * reverted script changes * minor syntax tweaks to scripts * updated the bitrise version to match package Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* VERSION_NAME * e2e testing * modified build script to generate debug app for testing * added pod file install into code prep * moved pod install to e2e workflow * update e2e * updated e2e * updated e2e script * added back envs * updated e2e * updated e2e * updated code_setup & e2e * updated detox script * added test deploy * commented out steps for testing * updated build announce to use bitrise script * added bitrise announcement script * refactored bitrise scripts to reflect the notion workflows * added new yarn step to audit dependencies * removing scripts and using yarn e2e test * moved the trigger * updated yarn audit command * updated e2e * updated e2e * updated build scripts to generate release and added dependency for android test release * test-android-build * generic-file-storage * file-downloader * Revert "file-downloader" This reverts commit db69ef5. * Download keystore * moved keystore download up in the workflow * updated keystore pull script * updated keystore pull script * added file downloader * added file downloader * uploaded keystore file android test * updated android release * updated release build to pull keystore from bitrise * update android bitrise deploy * added android e2e workflow and updated release signing config * commented out e2e * uncommented e2e setup * uncommented e2e * updated file format * uncommented e2e * comment e2e * uncommented e2e * formatting bitrise file * updated build scripts to use release * swaped password for release * test ios release * updated yarn steps * update slack bot script * added group test release * run android test release * updated announce script * update triggers and typos * update to test ios build * updated build type for pre-release * ios app generation * ios app generation * updated iOS builds * use bitrise xcode deploy * update ios release steps * added deploy to itunes connect * formatting * updated node version * udpated node version * Bitrise yml bump version (#2535) * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch * Release/testing minor (#2563) * Bitrise yml bump version (#1) * added new bitrise yml file * updated unit test yml * updated yml * added code coverage * added code coverage install * segment out code setup and validation from test cases * updating yml audit * updated yml * updated yml * updated yml audits * updated yml audits * updated yml audits * updated yml audits * updated yml install * updated yml audit * updated yml audit * updated yml segmented code_setup * updated yml segmented code_setup * updated yml segmented set to not always run * updated yml segmented code cov * updated yml triggers * updated yml triggers * updated yml triggers * updated yml codecov * switched to ci * switched to ci * test deploy * test deploy ios * format * imported env variables * added env variables * added env variables * reconfigured build triggers * reconfigured build triggers * reconfigured build triggers * removed fastlane from build scripts and added commnets to bitrise scripts * testing android artifact upload * commented out code that is not needed * added android deploy paths * test * Revert "test" This reverts commit 77ef282. * updated android deploy paths * bitrise-yml-bump-version * bump_version_minor * workflow * PROJECT_LOCATION * bump_version_minor * new_version_name * space * Revert "space" This reverts commit e0eb5ad. * 2.1.1 * new_version_name * torevert * Revert "torevert" This reverts commit a315582. * d * revert * env * ios * test android build * bump_version_minor * temporarily creating debug android build for testing * VERSION_NAME * scriptsworking * scripts * scripts * working * newscript * works * pre-merge-hook * 1.0.0 (#2560) * dah * actions? * branchasinput * update * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> * changename (#2) * Changetorun (#3) * changename * run * release/test-minor (#4) * rm-condition (#5) * Filelocation (#6) * rm-condition * file * Checkout step (#7) * rm-condition * file * checkout-step * Try (#8) * a * Revert "a" This reverts commit 5df3682. * Logs (#9) * a * Revert "a" This reverts commit 5df3682. * logs * Branch (#10) * a * Revert "a" This reverts commit 5df3682. * logs * branch * Var (#11) * a * Revert "a" This reverts commit 5df3682. * logs * branch * correct * echo (#12) * echo * rm * pull-request (#13) * Pull request 2 (#14) * pull-request * ref * GITHUB_REF * parse * with-branch (#15) * Origin branch (#16) * with-branch * origin-branch * base_ref (#17) * push * rmrnv * gh * action * event_name * base_ref * location * location * ls * find * file * file * GITHUB_TOKEN * persist * with * uses * bitrise * sed * commit * diff * release/fake-major * add-and-commit * with * author * path-to-th-repo * checkout@v1 * v2 * Bump version name * useref (#18) * change * ref * something (#19) * Branch 3 (#20) * something * onmerge * fix * Branch 4 (#21) * something * onmerge * fix * GITHUB_REF * GITHUB_CONTEXT * GITHUB_CONTEXT * BASE_REF * HEAD_REF * nobump * something (#22) * s (#23) * s * Bump version name * types (#24) * create-pr * something (#25) * Release/ww patch (#26) * something * opened * Bump version name * othercommit * Release/nohead patch (#36) * ghactions * something * fix * nopush * head * pull * nohead * nopull * nohead * update * gitpush * force * Bump version name * opened Co-authored-by: github-actions <github-actions@github.com> * rmonpush * Bump version name * startsWith * main * rmstartwith * line Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * newscript * release/testbump-patch (#2570) * space * branch * notopenend * diff * Bump version name Co-authored-by: github-actions <github-actions@github.com> * addbranch * version * ifrelease * add * lasttest * ifcontains * branch Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: github-actions <github-actions@github.com> * iOS build update * iOS build update * added android and ios in a single release build * added android and ios in a single release build * updated iOS release * updated iOS release * updated iOS release * updated iOS release * added android to test_release * test iOS build with export options * test iOS build with export options * setup android release build * fix action condition (#2576) * updated export options to include provisioning profile and added deploy to bitrise steps to ios * bump_version * start_release_builds * androidthenios * cachepull * before_run * deploy-to-itunesconnect * onefirsttheother * iosfirst * comments * updated slack announce script * uncommented deploy and slack announce * testing full release (#2582) * testing full release * Bump version name Co-authored-by: github-actions <github-actions@github.com> * update ios deploy step * removed test comment (#2584) * removed test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * testing android google play staging * increased versionCode & PROJECT VERSION * added iOS build * added test comment (#2585) * added test comment * Bump version name Co-authored-by: github-actions <github-actions@github.com> * run android only deploy * run ios only deploy * run ios only deploy * run ios only deploy * Release/testbuild patch (#2589) * Swaps: BSC Support (#2468) * Swaps: Add cache thresholds configuration (#2514) * removed test comments * Bump version name Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: github-actions <github-actions@github.com> * removed fastlane files and minor tweaks to scripts * updated e2e tests * updated e2e tests * updated yarn steps e2e * updated android scripts * updated build scrips and yml * updated e2e builds * remove CircleCi yml * added circleci script back * added emulator print out command * updated ios e2e test steps * removed devices * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * added creation of emulator to script * removed starting emulators * updated emulator name * avd list * avd creation * updated bitrise to tigger for v2.3.0 release build test * updated bundler version * updated build script * updated build script * updated change log with hide zero balance change (#2623) * updated version name * updated android emulator name * added build comments and verbose logging for tests * added build comments and refactored test inits * testing parallel deploys * added comments * formatting * moved code snipets * modified build triggers * modified build triggers * added deploy steps for parallel deploy * updated triggers * updated trigger * updated change log * stop caching * update build triggers * update build triggers * update audit script * testing parallel deployment * testing parallel deployment * testing parallel deployment * disable release in circleCI * testing parallel deployment * updated deploy directory * updated deploy step * deploy apk * updated changelog (#2648) * updated deploy scripts * remove code coverage * updated provisioning profile name * updated provisioning profile name * updated version for test 2.3.1 * updated provisioning profile * update provisioning profile * added fastlane and gemfiles back * updated bitrise config * updated conflicts * removed conflicts * yarn.lock update * test deploy build * e2e updates * updated for e2e testing * updated android e2e step * android e2e test prep * added updates to ios e2e * build min update for e2e test * updated ios e2e * switched to debug e2e tests * updated debug e2e scripts * updated detox commands * updated ios e2e steps * build release * removed kill-start server * added the restart server adb * shifted iOS to debug build for e2e * update release script * ios release build * updated sentry script * updated sentry script path * updated sentry paths and install * test release * triggered tests * updated ios e2e for Detox Utils * break out build & test * split fix syntax issue * fix syntax issue * updated e2e tests * updated e2e * ios e2e update * test ios e2e * updated timeout * updated ios to use yarn * added cache e2e ios * added cache e2e ios * run both e2e tests * removed fastlane, updated version bump to use a variable * updated script print out and workflow * test release * removed console.log, cleaned up comments, fix regex on bump * updated target version * setup final workflow state * updated bitrise.yml formatting uncommented deploy to store and uncommented bump * reset the min sdk version * removed duplicate detox install * version number update * reformatted yml Co-authored-by: Esteban Mino <efmino@uc.cl> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
3 tasks
13 tasks
seaona
added a commit
that referenced
this pull request
Dec 4, 2023
## **Description** In this PR we are flagging all the Confirmations tests as Smoke test. This includes the following spec files: - advanced-gas (the only one that was previously flagged as Smoke) - approve-default-erc - eth-sign - personal-sign - send-erc20 - send-erc721 - send-eth - typed-sign - typed-sign-v3 - typed-sign-v4 Notice the amount of time added on the runs is not significant compared to the amount of scenarios we add, giving everyone more confidence on making changes in the Wallet. See numbers below. Notice the tests are stable, being 100% Successful after several ci runs. This was achieved thanks to [this fix](#7802) by @vinistevam ### Recent examples how Confirmations tests captured an error on `main` - [Here](https://consensys.slack.com/archives/C02U025CVU4/p1699963068242849?thread_ts=1699950726.232009&cid=C02U025CVU4) is an example of how running all the Confirmations tests, would have captured and prevent an error in `main`. Luckily we were running them locally and could spot the error and connect the dots with the slack thread. - [Here](#7920) Signatures flow broken in main, that would have been captured by Confirmations tests if run as Smoke https://app.bitrise.io/build/fa65a941-6cd6-4b0c-9ece-151e76cdbb0d ### Test Runs Data #### Run #1 - Detox Build & Test - ios: 16m 31s - android: 36m 09s - bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10633145-b793-4ac3-8d9b-316ca24586f8 #### Run #2 - Detox Build & Test - ios: 18m 15s - android: 34m 15s - bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aad945da-60b3-49f2-ae89-18a6a59efe35 #### Run #3 - Detox Build & Test - ios: 17m 30s - android: 36m 12s - bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a9bd1bd3-a23f-4535-9b21-8475ca790980 #### Run #4 - Detox Build & Test - ios: 18m 47s - android: 35m 58s - bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3109490d-0355-4eb3-bbed-bedd644f26d9 #### Run #5 - Detox Build & Test - ios: 16m 57s - android: 32m 02s - bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/69a433eb-0bb0-4b67-95b2-c58145cc8963 ## **Related issues** Fixes: # ## **Manual testing steps** Trigger ci test runs from Bitrise and see that all tests are passing. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Vinicius Stevam <45455812+vinistevam@users.noreply.github.com>
Contributor
|
Bitrise build passed! |
Contributor
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 0 out of 1 committers have signed the CLA. |
7 tasks
abretonc7s
added a commit
that referenced
this pull request
Nov 24, 2025
…nce implementation) This is a complete reference implementation containing two major features that will be split into separate PRs for easier review. Features included: - Margin Adjustment: Add/remove margin from positions with unified view - Flip Position: Reverse position direction with confirmation sheet - Market Integration: Refactored market details view to support both features - UI Polish: Order type selector and various improvements Reference branch for creating 4 separate PRs: 1. PR #1: Adjust Margin Feature 2. PR #2: Flip Position Feature 3. PR #3: Market Integration 4. PR #4: UI Polish See PERPS_PR_ROADMAP.md for detailed breakdown.
This was referenced Jan 16, 2026
This was referenced Jan 16, 2026
matallui
added a commit
that referenced
this pull request
Jan 16, 2026
- Fix TypeScript error: PredictGamePeriod type now used consistently in PolymarketApiEvent, PolymarketApiGameEvent, and GameUpdate types - Fix Bugbot #1: Remove redundant '|| isOvertime' from possession check - Fix Bugbot #2 & #4: Add case-insensitive period detection and 'ongoing' status fallback for null period - Fix Bugbot #3: Rename misleading test description for Q1 elapsed time - Update WebSocketManager to cast period string to PredictGamePeriod
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
#26542) ## **Description** The deeplink connection flow (`metamask://connect/mwp?p=<payload>&c=1`) checks payload size only on the compressed, base64-encoded input (1 MB limit) but not on the decompressed output. A crafted compressed payload within this limit can expand to hundreds of megabytes during decompression, exhausting heap memory and crashing the app. This was identified as a finding in the Cyfrin security audit: [Cyfrin audit issue #4](https://github.com/Cyfrin/audit-2026-02-metamask-connect/issues/4) The fix switches from pako's one-shot `inflate()` to the streaming `Inflate` class, wrapping the default `onData` handler with a size guard that tracks cumulative output bytes and throws as soon as output exceeds 5 MB. This aborts decompression early without ever allocating the full bomb payload in memory. The 5 MB limit is generous (real connection request payloads are well under 10 KB) and the existing 1 MB pre-decompression check remains in place as a first line of defense. ## **Changelog** CHANGELOG entry: Fixed a potential decompression bomb vulnerability in the deeplink connection flow by adding streaming output size limits ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-1131 Refs: https://github.com/Cyfrin/audit-2026-02-metamask-connect/issues/4 ## **Manual testing steps** Not applicable. ## **Screenshots/Recordings** Not applicable. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
tylerc-consensys
added a commit
that referenced
this pull request
Mar 25, 2026
…error details and missing events Address findings from the end-to-end analytics audit of seedless/social login flows: - Add screen view and CTA tracking for SocialLoginIosUser iOS interstitial (P0 #1) - Set user traits (login_method, social_provider) via metrics.identify for seedless users (P1 #4) - Add attempt/success tracking for newGlobalPasswordLogin path in OAuthRehydration (P1 #5) - Add login_type to LOGIN_SCREEN_VIEWED to distinguish SRP vs seedless rehydration (P2 #8) - Fix hardcoded wallet_setup_type: 'import' in ChoosePassword (P2 #9) - Add WALLET_CREATION_ERROR_SUPPORT_CLICKED tracking to SRPErrorScreen (P3 #16) - Fix ONBOARDING_TOUR_STEP_REVISITED duplicate event name string (P3 #14) - Enrich SOCIAL_LOGIN_FAILED and REHYDRATION_PASSWORD_FAILED with error_origin, seedless_error_type - Add loginFailureAnalytics helper for consistent error-to-analytics mapping - Use ErrorOrigin enum and LoginMethod enum for type-safe analytics properties Made-with: Cursor
Closed
5 of 7 tasks
saustrie-consensys
added a commit
that referenced
this pull request
Jun 15, 2026
- #1 DRY: extract the duplicated headless ramp-prop derivation from the 6 NativeFlow screens (EnterEmail, OtpCode, VerifyIdentity, BasicInfo, EnterAddress, KycProcessing) into a shared useHeadlessRampProps hook. Behavior is identical: HEADLESS + seeded surface when a headless session drives the screen, otherwise the original UNIFIED_BUY_2 / DEPOSIT literal. - #2 camelCase: rename the internal HeadlessBuyParams field ramp_surface to rampSurface, updating the seed sites (useFiatConfirm, HeadlessPlayground) and all read sites (useTransakRouting, Checkout, the shared hook). The emitted analytics property stays ramp_surface; only the param field changed. - #4: traced the global FiatOrders order observer. Headless orders are added via RampsController.addOrder (useTransakRouting -> useRampsOrders) and never enter the redux fiatOrders store that the observer polls, so RAMPS_TRANSACTION_COMPLETED/FAILED do not fire on the headless path. No code change; documented the DEPOSIT-only scope on getDepositAnalyticsPayload. Headless terminal success/failure remain covered by useTransakRouting's RAMPS_TRANSACTION_CONFIRMED / RAMPS_ORDER_FAILED.
8 of 10 tasks
10 tasks done
5 of 10 tasks
8 of 10 tasks
8 of 10 tasks
kikaE2B
pushed a commit
to kikaE2B/metamask-mobile
that referenced
this pull request
Aug 8, 2026
…etaMask#33572) ## **Description** This PR adds a reusable **Lite ⇄ Pro** mode toggle across the Perps entry points and the mode-switch experience that goes with it (TAT-3551). The whole surface is behind the `selectPerpsProModeEnabledFlag` feature flag (off by default). **What changed and why:** - **Reusable `PerpsModeToggle` component** (`app/components/UI/Perps/components/PerpsModeToggle/`) — one component powers every entry point so the toggle is not duplicated (AC MetaMask#1). Built on the design-system `SegmentedControl` / `FilterButton` / `ButtonBase`, with two variants: - `variant="toggle"` (default): interactive two-segment "Lite"/"Pro" pill (Trade menu, Perps home header). - `variant="active"`: single pill showing only the active mode for the Market header (AC MetaMask#6.3); pressing it flips the mode. - Emits a `PERPS_UI_INTERACTION` analytics event carrying `mode` and the originating `source` (AC MetaMask#7, per-interaction). - **Entry points wired (AC MetaMask#6):** the toggle now renders in the **Trade wallet actions** sheet (Perps row), the **Perps home header** (centered), and the **Market Details header** (right side, active-mode pill next to the watchlist star). - **Shared mode state (AC MetaMask#3):** `usePerpsMode` reads `selectPerpsMode` (wrapping the `@metamask/perps-controller` selector, bumped to `9.3.0`) and persists changes via `PerpsController.setPerpsMode`, so all entry points stay in sync. - **`PerpsModeTransition` interstitial + route (AC MetaMask#4):** switching mode shows a full-screen "Pro Mode" / "Lite Mode" screen in the Figma accent palette, then redirects. Registered as a Perps stack screen (`PerpsModeTransitionView`). - **Figma accent styling:** the "Pro" branding uses `accent/02` purple — the active pill is an outlined transparent pill with purple text, and in the two-option toggle the Pro segment is always purple with an accent-tinted fill when selected. Lite keeps the default segmented-control styling. - **`selectPerpsProModeEnabledFlag`** feature-flag selector (version-gated pattern), registry entry, and mock (AC MetaMask#2), plus `perps.mode.*` i18n strings and new test-ID selector groups. - **Unit tests** for the toggle, transition screen, transition view, `usePerpsMode`, and both selectors, plus entry-point coverage in the Trade menu, Perps home, and Market Details view tests. **Known follow-ups (out of scope here):** Pro landing on the BTC market screen when not already on a market page — both directions currently return to Perps home (AC MetaMask#4 nuance); the first-session promotion callout (AC MetaMask#5); and attaching `mode` as a global Mixpanel property beyond the toggle interaction (AC MetaMask#7). ## **Changelog** CHANGELOG entry: null <!-- Not end-user-facing: the entire surface is behind the `perpsProModeEnabled` feature flag, which is disabled by default. --> ## **Related issues** Refs: https://consensyssoftware.atlassian.net/browse/TAT-3551 ## **Manual testing steps** Enable the flag locally (e.g. `MM_PERPS_PRO_MODE_ENABLED=true`) or via the remote-flag mock, then: ```gherkin Feature: Perps Lite/Pro mode toggle Scenario: Switch mode from the Perps home header Given the Pro mode feature flag is enabled And the user is on the Perps home screen When the user taps the "Pro" segment in the header toggle Then the shared mode is set to "pro" And the mode-transition screen is shown And the user is returned to the Perps home screen Scenario: Switch mode from the Trade menu Given the Pro mode feature flag is enabled When the user opens the Trade sheet and switches the Perps-row toggle Then the sheet is dismissed and the mode-transition screen is shown Scenario: Market header active-mode pill Given the Pro mode feature flag is enabled And the user is on a Market Details screen Then only the current mode is shown as a pill next to the watchlist star When the user taps the pill Then the mode flips and the mode-transition screen is shown Scenario: Toggle hidden when the flag is off Given the Pro mode feature flag is disabled Then no mode toggle is rendered in any entry point ``` Unit tests: ``` yarn jest app/components/UI/Perps/components/PerpsModeToggle \ app/components/UI/Perps/components/PerpsModeTransition \ app/components/UI/Perps/Views/PerpsModeTransitionView \ app/components/UI/Perps/hooks/usePerpsMode.test.ts \ app/components/UI/Perps/selectors/featureFlags/index.test.ts \ app/components/UI/Perps/selectors/perpsController/index.test.ts ``` ## **Screenshots/Recordings** ### **Before** N/A — new feature-flagged UI. ### **After** https://github.com/user-attachments/assets/48cbcec1-1e31-4ce9-92df-0b1f34e03500 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches Perps navigation and market routing across multiple entry points and upgrades perps-controller state shape; behavior is gated by a remote flag but mode persistence affects which market layout renders. > > **Overview** > Adds **Perps Lite ⇄ Pro** behind `perpsProModeEnabled` (off by default), wired through `@metamask/perps-controller` **9.3.0** with persisted `mode` / `proLayoutPreferences` and `usePerpsMode` + `selectPerpsMode`. > > Introduces reusable **`PerpsModeToggle`** (full segmented control vs market-header **active** pill), **`PerpsModeFlashContainer`** at the Perps stack root, and a small `perpsModeFlash` store so any entry point can show a brief “Lite Mode” / “Pro Mode” overlay. Toggle taps emit **`PERPS_UI_INTERACTION`** with `mode` and `source`. > > **Entry points:** Trade sheet Perps row (`endAccessory`), Perps home header (centered toggle when the flag is on), and market details (watchlist star + active pill). **`usePerpsProModeEnabled`** now returns true only when the flag is on **and** mode is Pro (replacing the always-false placeholder). > > **Routing:** persisting mode; first-time users go to **tutorial** (no flash). Otherwise Pro from home/Trade navigates to default **BTC** `MARKET_DETAILS`; market screen flips mode **in place** with flash only. i18n, test IDs, flag selector/registry, and unit tests cover the new pieces. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 3d8334f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Matt D. <85914066+geositta@users.noreply.github.com>
8 of 10 tasks
runway-github Bot
added a commit
that referenced
this pull request
Sep 10, 2026
…hake cp-8.11.0 (#35600) ## **Description** Android hard-crashes (SIGABRT) during Perps navigation when live price feeds are torn down: ``` ops-ws.c:975: lws_close_reason(...): assertion "lwsi_role_ws(wsi)" failed ``` `lws_close_reason()` requires the connection to already hold the WebSocket role. That role is only assigned once the handshake completes. This is a libwebsockets bug, [warmcat/libwebsockets#1335](warmcat/libwebsockets#1335), open since 2018. `react-native-nitro-websockets@1.0.3` hits it because `connect()` publishes `_wsi` as soon as `lws_client_connect_via_info()` returns, while the role only arrives later in `handleEstablished()`. In between, `_wsi` is non-null on a connection that still has the HTTP role. The old `close()` checked only for null, so closing a socket mid-handshake aborted the process. This backports the fix from `react-native-nitro-websockets@1.3.1` ([margelo/react-native-nitro-fetch](https://github.com/margelo/react-native-nitro-fetch)) onto the 1.0.3 we pin: - `_state` becomes `std::atomic<State>`, and `close()` claims the CLOSING transition with a compare-exchange loop, keeping the state it moved away from. A plain read-then-write races a handshake that completes in the same `lws_service` tick. - If that prior state was `CONNECTING`, the socket still has the HTTP role, so the scheduled lambda drops it with `lws_set_timeout(PENDING_TIMEOUT_USER_OK, LWS_TO_KILL_ASYNC)` rather than calling `lws_close_reason()`. It ships as a yarn patch because of the version pin. > ### Follow-up: bump the package > > 1.3.1 already contains this fix, so bumping beats carrying a native patch we own. The pin is stale anyway: `react-native-nitro-fetch` is on 1.3.3 while websockets sits at 1.0.3, and the two ship together. > > It is not a drop-in swap. 1.0.3 to 1.3.1 adds `_selfRef` lifetime handling, `fireClose`, and peer-vs-local close codes, so it needs its own PR and testing pass instead of riding along here. <details> <summary>Why it looks intermittent, and why release builds are worse</summary> The close has to land inside a window of roughly one network round trip, so this is a real race. Slow connections widen the window. Fast navigation is what closes a socket before its feed finishes connecting. Perps opens several feeds per screen, so every transition rolls the dice again. The same build crashes for one user and never for another. Release builds are worse than debug. `-DNDEBUG` compiles the assertion out, and `lws_close_reason()` then writes through `&wsi->ws->ping_payload_buf[...]` on a connection whose `ws` struct was never allocated. A clean abort becomes a null-derived write. I only reproduced against `prodDebug`; I read the release path from source rather than observing it. #32472 (2026-07-06) introduced this when it replaced the global `WebSocket` unconditionally. Nobody caught it because `NitroWebSocketSetup.test.ts` mocks the native module, and a native abort produces no JS error and no Sentry event. </details> ## **Changelog** CHANGELOG entry: Fixed a crash on Android when navigating between Perps screens ## **Related issues** Fixes: [TAT-3908](https://consensyssoftware.atlassian.net/browse/TAT-3908) ## **Manual testing steps** Needs a physical Android device or emulator. Reproduced on a Pixel 6a (Android 17). **1. Build and install.** Do this on `main` to see the crash, then on this branch to see it fixed. ```bash cd android && ./gradlew :app:assembleProdDebug -PreactNativeArchitectures=arm64-v8a && cd .. adb install -r android/app/build/outputs/apk/prod/debug/app-prod-debug.apk ``` **2. Watch for the crash** in a second terminal. ```bash adb logcat -c && adb logcat | grep -E "Fatal signal 6|lwsi_role_ws" ``` **3. Trigger it.** Unlock the wallet, open Perps, then navigate Perps, wallet home, Perps three times in quick succession. Speed is what matters here. You are trying to leave a screen while its feeds are still connecting. On `main` the app dies and logcat shows the `lwsi_role_ws` abort. On this branch navigation stays clean and logcat stays silent. It is a race, so a fast network may take a couple of attempts. A slower connection reproduces it more reliably. | Build | Perps enter/leave cycles | SIGABRT | |---|---|---| | Before fix | 3 | **1** | | After fix | 15 (5 runs × 3) | **0** | The pre-fix backtrace put frame `#4` at `LwsContext::loop()`. That is the libwebsockets thread draining its scheduled work queue, which is exactly where `close()` defers its lambda. I only built `arm64-v8a` locally and never built the release variant. CI covers the full ABI matrix. ## **Screenshots/Recordings** N/A. This is a native crash fix with no UI change. The evidence is the logcat signature and its absence, per the steps above. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [TAT-3908]: https://consensyssoftware.atlassian.net/browse/TAT-3908?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches native WebSocket teardown on Android under concurrency; scope is limited to the patched dependency and targets a known crash path. > > **Overview** > Fixes an **Android SIGABRT** when live WebSocket feeds are closed while still handshaking (e.g. fast Perps navigation), by patching `react-native-nitro-websockets@1.0.3` via Yarn instead of bumping the package. > > The native change makes connection `_state` **`std::atomic`** and has `close()` claim **CLOSING** with a compare-exchange so JS and libwebsockets threads cannot race the same `lws_service` tick. The scheduled close lambda remembers the prior state: if it was **`CONNECTING`**, it **async-kills** the socket with `lws_set_timeout` instead of calling **`lws_close_reason()`**, which asserts the WebSocket role and crashes mid-handshake. > > `package.json` and `yarn.lock` now resolve `react-native-nitro-websockets` to this patch entry. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e3c3f48. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github Bot
added a commit
that referenced
this pull request
Sep 10, 2026
…hake cp-8.11.0 (#35600) ## **Description** Android hard-crashes (SIGABRT) during Perps navigation when live price feeds are torn down: ``` ops-ws.c:975: lws_close_reason(...): assertion "lwsi_role_ws(wsi)" failed ``` `lws_close_reason()` requires the connection to already hold the WebSocket role. That role is only assigned once the handshake completes. This is a libwebsockets bug, [warmcat/libwebsockets#1335](warmcat/libwebsockets#1335), open since 2018. `react-native-nitro-websockets@1.0.3` hits it because `connect()` publishes `_wsi` as soon as `lws_client_connect_via_info()` returns, while the role only arrives later in `handleEstablished()`. In between, `_wsi` is non-null on a connection that still has the HTTP role. The old `close()` checked only for null, so closing a socket mid-handshake aborted the process. This backports the fix from `react-native-nitro-websockets@1.3.1` ([margelo/react-native-nitro-fetch](https://github.com/margelo/react-native-nitro-fetch)) onto the 1.0.3 we pin: - `_state` becomes `std::atomic<State>`, and `close()` claims the CLOSING transition with a compare-exchange loop, keeping the state it moved away from. A plain read-then-write races a handshake that completes in the same `lws_service` tick. - If that prior state was `CONNECTING`, the socket still has the HTTP role, so the scheduled lambda drops it with `lws_set_timeout(PENDING_TIMEOUT_USER_OK, LWS_TO_KILL_ASYNC)` rather than calling `lws_close_reason()`. It ships as a yarn patch because of the version pin. > ### Follow-up: bump the package > > 1.3.1 already contains this fix, so bumping beats carrying a native patch we own. The pin is stale anyway: `react-native-nitro-fetch` is on 1.3.3 while websockets sits at 1.0.3, and the two ship together. > > It is not a drop-in swap. 1.0.3 to 1.3.1 adds `_selfRef` lifetime handling, `fireClose`, and peer-vs-local close codes, so it needs its own PR and testing pass instead of riding along here. <details> <summary>Why it looks intermittent, and why release builds are worse</summary> The close has to land inside a window of roughly one network round trip, so this is a real race. Slow connections widen the window. Fast navigation is what closes a socket before its feed finishes connecting. Perps opens several feeds per screen, so every transition rolls the dice again. The same build crashes for one user and never for another. Release builds are worse than debug. `-DNDEBUG` compiles the assertion out, and `lws_close_reason()` then writes through `&wsi->ws->ping_payload_buf[...]` on a connection whose `ws` struct was never allocated. A clean abort becomes a null-derived write. I only reproduced against `prodDebug`; I read the release path from source rather than observing it. #32472 (2026-07-06) introduced this when it replaced the global `WebSocket` unconditionally. Nobody caught it because `NitroWebSocketSetup.test.ts` mocks the native module, and a native abort produces no JS error and no Sentry event. </details> ## **Changelog** CHANGELOG entry: Fixed a crash on Android when navigating between Perps screens ## **Related issues** Fixes: [TAT-3908](https://consensyssoftware.atlassian.net/browse/TAT-3908) ## **Manual testing steps** Needs a physical Android device or emulator. Reproduced on a Pixel 6a (Android 17). **1. Build and install.** Do this on `main` to see the crash, then on this branch to see it fixed. ```bash cd android && ./gradlew :app:assembleProdDebug -PreactNativeArchitectures=arm64-v8a && cd .. adb install -r android/app/build/outputs/apk/prod/debug/app-prod-debug.apk ``` **2. Watch for the crash** in a second terminal. ```bash adb logcat -c && adb logcat | grep -E "Fatal signal 6|lwsi_role_ws" ``` **3. Trigger it.** Unlock the wallet, open Perps, then navigate Perps, wallet home, Perps three times in quick succession. Speed is what matters here. You are trying to leave a screen while its feeds are still connecting. On `main` the app dies and logcat shows the `lwsi_role_ws` abort. On this branch navigation stays clean and logcat stays silent. It is a race, so a fast network may take a couple of attempts. A slower connection reproduces it more reliably. | Build | Perps enter/leave cycles | SIGABRT | |---|---|---| | Before fix | 3 | **1** | | After fix | 15 (5 runs × 3) | **0** | The pre-fix backtrace put frame `#4` at `LwsContext::loop()`. That is the libwebsockets thread draining its scheduled work queue, which is exactly where `close()` defers its lambda. I only built `arm64-v8a` locally and never built the release variant. CI covers the full ABI matrix. ## **Screenshots/Recordings** N/A. This is a native crash fix with no UI change. The evidence is the logcat signature and its absence, per the steps above. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [TAT-3908]: https://consensyssoftware.atlassian.net/browse/TAT-3908?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches native WebSocket teardown on Android under concurrency; scope is limited to the patched dependency and targets a known crash path. > > **Overview** > Fixes an **Android SIGABRT** when live WebSocket feeds are closed while still handshaking (e.g. fast Perps navigation), by patching `react-native-nitro-websockets@1.0.3` via Yarn instead of bumping the package. > > The native change makes connection `_state` **`std::atomic`** and has `close()` claim **CLOSING** with a compare-exchange so JS and libwebsockets threads cannot race the same `lws_service` tick. The scheduled close lambda remembers the prior state: if it was **`CONNECTING`**, it **async-kills** the socket with `lws_set_timeout` instead of calling **`lws_close_reason()`**, which asserts the WebSocket role and crashes mid-handshake. > > `package.json` and `yarn.lock` now resolve `react-native-nitro-websockets` to this patch entry. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e3c3f48. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
…cp-8.11.0 (#35600) ## **Description** Android hard-crashes (SIGABRT) during Perps navigation when live price feeds are torn down: ``` ops-ws.c:975: lws_close_reason(...): assertion "lwsi_role_ws(wsi)" failed ``` `lws_close_reason()` requires the connection to already hold the WebSocket role. That role is only assigned once the handshake completes. This is a libwebsockets bug, [warmcat/libwebsockets#1335](warmcat/libwebsockets#1335), open since 2018. `react-native-nitro-websockets@1.0.3` hits it because `connect()` publishes `_wsi` as soon as `lws_client_connect_via_info()` returns, while the role only arrives later in `handleEstablished()`. In between, `_wsi` is non-null on a connection that still has the HTTP role. The old `close()` checked only for null, so closing a socket mid-handshake aborted the process. This backports the fix from `react-native-nitro-websockets@1.3.1` ([margelo/react-native-nitro-fetch](https://github.com/margelo/react-native-nitro-fetch)) onto the 1.0.3 we pin: - `_state` becomes `std::atomic<State>`, and `close()` claims the CLOSING transition with a compare-exchange loop, keeping the state it moved away from. A plain read-then-write races a handshake that completes in the same `lws_service` tick. - If that prior state was `CONNECTING`, the socket still has the HTTP role, so the scheduled lambda drops it with `lws_set_timeout(PENDING_TIMEOUT_USER_OK, LWS_TO_KILL_ASYNC)` rather than calling `lws_close_reason()`. It ships as a yarn patch because of the version pin. > ### Follow-up: bump the package > > 1.3.1 already contains this fix, so bumping beats carrying a native patch we own. The pin is stale anyway: `react-native-nitro-fetch` is on 1.3.3 while websockets sits at 1.0.3, and the two ship together. > > It is not a drop-in swap. 1.0.3 to 1.3.1 adds `_selfRef` lifetime handling, `fireClose`, and peer-vs-local close codes, so it needs its own PR and testing pass instead of riding along here. <details> <summary>Why it looks intermittent, and why release builds are worse</summary> The close has to land inside a window of roughly one network round trip, so this is a real race. Slow connections widen the window. Fast navigation is what closes a socket before its feed finishes connecting. Perps opens several feeds per screen, so every transition rolls the dice again. The same build crashes for one user and never for another. Release builds are worse than debug. `-DNDEBUG` compiles the assertion out, and `lws_close_reason()` then writes through `&wsi->ws->ping_payload_buf[...]` on a connection whose `ws` struct was never allocated. A clean abort becomes a null-derived write. I only reproduced against `prodDebug`; I read the release path from source rather than observing it. #32472 (2026-07-06) introduced this when it replaced the global `WebSocket` unconditionally. Nobody caught it because `NitroWebSocketSetup.test.ts` mocks the native module, and a native abort produces no JS error and no Sentry event. </details> ## **Changelog** CHANGELOG entry: Fixed a crash on Android when navigating between Perps screens ## **Related issues** Fixes: [TAT-3908](https://consensyssoftware.atlassian.net/browse/TAT-3908) ## **Manual testing steps** Needs a physical Android device or emulator. Reproduced on a Pixel 6a (Android 17). **1. Build and install.** Do this on `main` to see the crash, then on this branch to see it fixed. ```bash cd android && ./gradlew :app:assembleProdDebug -PreactNativeArchitectures=arm64-v8a && cd .. adb install -r android/app/build/outputs/apk/prod/debug/app-prod-debug.apk ``` **2. Watch for the crash** in a second terminal. ```bash adb logcat -c && adb logcat | grep -E "Fatal signal 6|lwsi_role_ws" ``` **3. Trigger it.** Unlock the wallet, open Perps, then navigate Perps, wallet home, Perps three times in quick succession. Speed is what matters here. You are trying to leave a screen while its feeds are still connecting. On `main` the app dies and logcat shows the `lwsi_role_ws` abort. On this branch navigation stays clean and logcat stays silent. It is a race, so a fast network may take a couple of attempts. A slower connection reproduces it more reliably. | Build | Perps enter/leave cycles | SIGABRT | |---|---|---| | Before fix | 3 | **1** | | After fix | 15 (5 runs × 3) | **0** | The pre-fix backtrace put frame `#4` at `LwsContext::loop()`. That is the libwebsockets thread draining its scheduled work queue, which is exactly where `close()` defers its lambda. I only built `arm64-v8a` locally and never built the release variant. CI covers the full ABI matrix. ## **Screenshots/Recordings** N/A. This is a native crash fix with no UI change. The evidence is the logcat signature and its absence, per the steps above. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [TAT-3908]: https://consensyssoftware.atlassian.net/browse/TAT-3908?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches native WebSocket teardown on Android under concurrency; scope is limited to the patched dependency and targets a known crash path. > > **Overview** > Fixes an **Android SIGABRT** when live WebSocket feeds are closed while still handshaking (e.g. fast Perps navigation), by patching `react-native-nitro-websockets@1.0.3` via Yarn instead of bumping the package. > > The native change makes connection `_state` **`std::atomic`** and has `close()` claim **CLOSING** with a compare-exchange so JS and libwebsockets threads cannot race the same `lws_service` tick. The scheduled close lambda remembers the prior state: if it was **`CONNECTING`**, it **async-kills** the socket with `lws_set_timeout` instead of calling **`lws_close_reason()`**, which asserts the WebSocket role and crashes mid-handshake. > > `package.json` and `yarn.lock` now resolve `react-native-nitro-websockets` to this patch entry. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e3c3f48. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
sleepytanya
pushed a commit
that referenced
this pull request
Sep 10, 2026
) - fix(android): stop nitro-websockets crash when closing mid-handshake cp-8.11.0 (#35600) ## **Description** Android hard-crashes (SIGABRT) during Perps navigation when live price feeds are torn down: ``` ops-ws.c:975: lws_close_reason(...): assertion "lwsi_role_ws(wsi)" failed ``` `lws_close_reason()` requires the connection to already hold the WebSocket role. That role is only assigned once the handshake completes. This is a libwebsockets bug, [warmcat/libwebsockets#1335](warmcat/libwebsockets#1335), open since 2018. `react-native-nitro-websockets@1.0.3` hits it because `connect()` publishes `_wsi` as soon as `lws_client_connect_via_info()` returns, while the role only arrives later in `handleEstablished()`. In between, `_wsi` is non-null on a connection that still has the HTTP role. The old `close()` checked only for null, so closing a socket mid-handshake aborted the process. This backports the fix from `react-native-nitro-websockets@1.3.1` ([margelo/react-native-nitro-fetch](https://github.com/margelo/react-native-nitro-fetch)) onto the 1.0.3 we pin: - `_state` becomes `std::atomic<State>`, and `close()` claims the CLOSING transition with a compare-exchange loop, keeping the state it moved away from. A plain read-then-write races a handshake that completes in the same `lws_service` tick. - If that prior state was `CONNECTING`, the socket still has the HTTP role, so the scheduled lambda drops it with `lws_set_timeout(PENDING_TIMEOUT_USER_OK, LWS_TO_KILL_ASYNC)` rather than calling `lws_close_reason()`. It ships as a yarn patch because of the version pin. > ### Follow-up: bump the package > > 1.3.1 already contains this fix, so bumping beats carrying a native patch we own. The pin is stale anyway: `react-native-nitro-fetch` is on 1.3.3 while websockets sits at 1.0.3, and the two ship together. > > It is not a drop-in swap. 1.0.3 to 1.3.1 adds `_selfRef` lifetime handling, `fireClose`, and peer-vs-local close codes, so it needs its own PR and testing pass instead of riding along here. <details> <summary>Why it looks intermittent, and why release builds are worse</summary> The close has to land inside a window of roughly one network round trip, so this is a real race. Slow connections widen the window. Fast navigation is what closes a socket before its feed finishes connecting. Perps opens several feeds per screen, so every transition rolls the dice again. The same build crashes for one user and never for another. Release builds are worse than debug. `-DNDEBUG` compiles the assertion out, and `lws_close_reason()` then writes through `&wsi->ws->ping_payload_buf[...]` on a connection whose `ws` struct was never allocated. A clean abort becomes a null-derived write. I only reproduced against `prodDebug`; I read the release path from source rather than observing it. #32472 (2026-07-06) introduced this when it replaced the global `WebSocket` unconditionally. Nobody caught it because `NitroWebSocketSetup.test.ts` mocks the native module, and a native abort produces no JS error and no Sentry event. </details> ## **Changelog** CHANGELOG entry: Fixed a crash on Android when navigating between Perps screens ## **Related issues** Fixes: [TAT-3908](https://consensyssoftware.atlassian.net/browse/TAT-3908) ## **Manual testing steps** Needs a physical Android device or emulator. Reproduced on a Pixel 6a (Android 17). **1. Build and install.** Do this on `main` to see the crash, then on this branch to see it fixed. ```bash cd android && ./gradlew :app:assembleProdDebug -PreactNativeArchitectures=arm64-v8a && cd .. adb install -r android/app/build/outputs/apk/prod/debug/app-prod-debug.apk ``` **2. Watch for the crash** in a second terminal. ```bash adb logcat -c && adb logcat | grep -E "Fatal signal 6|lwsi_role_ws" ``` **3. Trigger it.** Unlock the wallet, open Perps, then navigate Perps, wallet home, Perps three times in quick succession. Speed is what matters here. You are trying to leave a screen while its feeds are still connecting. On `main` the app dies and logcat shows the `lwsi_role_ws` abort. On this branch navigation stays clean and logcat stays silent. It is a race, so a fast network may take a couple of attempts. A slower connection reproduces it more reliably. | Build | Perps enter/leave cycles | SIGABRT | |---|---|---| | Before fix | 3 | **1** | | After fix | 15 (5 runs × 3) | **0** | The pre-fix backtrace put frame `#4` at `LwsContext::loop()`. That is the libwebsockets thread draining its scheduled work queue, which is exactly where `close()` defers its lambda. I only built `arm64-v8a` locally and never built the release variant. CI covers the full ABI matrix. ## **Screenshots/Recordings** N/A. This is a native crash fix with no UI change. The evidence is the logcat signature and its absence, per the steps above. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [TAT-3908]: https://consensyssoftware.atlassian.net/browse/TAT-3908?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches native WebSocket teardown on Android under concurrency; scope is limited to the patched dependency and targets a known crash path. > > **Overview** > Fixes an **Android SIGABRT** when live WebSocket feeds are closed while still handshaking (e.g. fast Perps navigation), by patching `react-native-nitro-websockets@1.0.3` via Yarn instead of bumping the package. > > The native change makes connection `_state` **`std::atomic`** and has `close()` claim **CLOSING** with a compare-exchange so JS and libwebsockets threads cannot race the same `lws_service` tick. The scheduled close lambda remembers the prior state: if it was **`CONNECTING`**, it **async-kills** the socket with `lws_set_timeout` instead of calling **`lws_close_reason()`**, which asserts the WebSocket role and crashes mid-handshake. > > `package.json` and `yarn.lock` now resolve `react-native-nitro-websockets` to this patch entry. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e3c3f48. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> [46db28b](46db28b) [TAT-3908]: https://consensyssoftware.atlassian.net/browse/TAT-3908?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Poovarasan-Sandhanam
pushed a commit
to Poovarasan-Sandhanam/metamask-mobile
that referenced
this pull request
Sep 11, 2026
…cp-8.11.0 (MetaMask#35600) ## **Description** Android hard-crashes (SIGABRT) during Perps navigation when live price feeds are torn down: ``` ops-ws.c:975: lws_close_reason(...): assertion "lwsi_role_ws(wsi)" failed ``` `lws_close_reason()` requires the connection to already hold the WebSocket role. That role is only assigned once the handshake completes. This is a libwebsockets bug, [warmcat/libwebsockets#1335](warmcat/libwebsockets#1335), open since 2018. `react-native-nitro-websockets@1.0.3` hits it because `connect()` publishes `_wsi` as soon as `lws_client_connect_via_info()` returns, while the role only arrives later in `handleEstablished()`. In between, `_wsi` is non-null on a connection that still has the HTTP role. The old `close()` checked only for null, so closing a socket mid-handshake aborted the process. This backports the fix from `react-native-nitro-websockets@1.3.1` ([margelo/react-native-nitro-fetch](https://github.com/margelo/react-native-nitro-fetch)) onto the 1.0.3 we pin: - `_state` becomes `std::atomic<State>`, and `close()` claims the CLOSING transition with a compare-exchange loop, keeping the state it moved away from. A plain read-then-write races a handshake that completes in the same `lws_service` tick. - If that prior state was `CONNECTING`, the socket still has the HTTP role, so the scheduled lambda drops it with `lws_set_timeout(PENDING_TIMEOUT_USER_OK, LWS_TO_KILL_ASYNC)` rather than calling `lws_close_reason()`. It ships as a yarn patch because of the version pin. > ### Follow-up: bump the package > > 1.3.1 already contains this fix, so bumping beats carrying a native patch we own. The pin is stale anyway: `react-native-nitro-fetch` is on 1.3.3 while websockets sits at 1.0.3, and the two ship together. > > It is not a drop-in swap. 1.0.3 to 1.3.1 adds `_selfRef` lifetime handling, `fireClose`, and peer-vs-local close codes, so it needs its own PR and testing pass instead of riding along here. <details> <summary>Why it looks intermittent, and why release builds are worse</summary> The close has to land inside a window of roughly one network round trip, so this is a real race. Slow connections widen the window. Fast navigation is what closes a socket before its feed finishes connecting. Perps opens several feeds per screen, so every transition rolls the dice again. The same build crashes for one user and never for another. Release builds are worse than debug. `-DNDEBUG` compiles the assertion out, and `lws_close_reason()` then writes through `&wsi->ws->ping_payload_buf[...]` on a connection whose `ws` struct was never allocated. A clean abort becomes a null-derived write. I only reproduced against `prodDebug`; I read the release path from source rather than observing it. MetaMask#32472 (2026-07-06) introduced this when it replaced the global `WebSocket` unconditionally. Nobody caught it because `NitroWebSocketSetup.test.ts` mocks the native module, and a native abort produces no JS error and no Sentry event. </details> ## **Changelog** CHANGELOG entry: Fixed a crash on Android when navigating between Perps screens ## **Related issues** Fixes: [TAT-3908](https://consensyssoftware.atlassian.net/browse/TAT-3908) ## **Manual testing steps** Needs a physical Android device or emulator. Reproduced on a Pixel 6a (Android 17). **1. Build and install.** Do this on `main` to see the crash, then on this branch to see it fixed. ```bash cd android && ./gradlew :app:assembleProdDebug -PreactNativeArchitectures=arm64-v8a && cd .. adb install -r android/app/build/outputs/apk/prod/debug/app-prod-debug.apk ``` **2. Watch for the crash** in a second terminal. ```bash adb logcat -c && adb logcat | grep -E "Fatal signal 6|lwsi_role_ws" ``` **3. Trigger it.** Unlock the wallet, open Perps, then navigate Perps, wallet home, Perps three times in quick succession. Speed is what matters here. You are trying to leave a screen while its feeds are still connecting. On `main` the app dies and logcat shows the `lwsi_role_ws` abort. On this branch navigation stays clean and logcat stays silent. It is a race, so a fast network may take a couple of attempts. A slower connection reproduces it more reliably. | Build | Perps enter/leave cycles | SIGABRT | |---|---|---| | Before fix | 3 | **1** | | After fix | 15 (5 runs × 3) | **0** | The pre-fix backtrace put frame `MetaMask#4` at `LwsContext::loop()`. That is the libwebsockets thread draining its scheduled work queue, which is exactly where `close()` defers its lambda. I only built `arm64-v8a` locally and never built the release variant. CI covers the full ABI matrix. ## **Screenshots/Recordings** N/A. This is a native crash fix with no UI change. The evidence is the logcat signature and its absence, per the steps above. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [TAT-3908]: https://consensyssoftware.atlassian.net/browse/TAT-3908?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches native WebSocket teardown on Android under concurrency; scope is limited to the patched dependency and targets a known crash path. > > **Overview** > Fixes an **Android SIGABRT** when live WebSocket feeds are closed while still handshaking (e.g. fast Perps navigation), by patching `react-native-nitro-websockets@1.0.3` via Yarn instead of bumping the package. > > The native change makes connection `_state` **`std::atomic`** and has `close()` claim **CLOSING** with a compare-exchange so JS and libwebsockets threads cannot race the same `lws_service` tick. The scheduled close lambda remembers the prior state: if it was **`CONNECTING`**, it **async-kills** the socket with `lws_set_timeout` instead of calling **`lws_close_reason()`**, which asserts the WebSocket role and crashes mid-handshake. > > `package.json` and `yarn.lock` now resolve `react-native-nitro-websockets` to this patch entry. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e3c3f48. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Poovarasan-Sandhanam
pushed a commit
to Poovarasan-Sandhanam/metamask-mobile
that referenced
this pull request
Oct 19, 2026
…k#35846) ## **Description** Stacked on top of MetaMask#4. `musdConversionTransaction`, `useEnsureMusdTokenRegistered`, the Earn lending deposit/withdrawal confirmation views, and the Tron balance refresh were the last feature-domain code still reading tokens or balances from the legacy controllers. This moves them onto `AssetsController` as well, so Earn no longer depends on anything scheduled for removal. ## **Changelog** CHANGELOG entry: null ## **Related issues** Refs: https://consensyssoftware.atlassian.net/browse/ASSETS-3957 ## **Manual testing steps** N/A - this is an internal refactor with no user-facing behavior change, covered by existing unit tests. ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - [x] I've tested with a power user scenario - [x] I've instrumented key operations with Sentry traces for production performance metrics ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches post-confirmation token registration, mUSD pay flows, and balance refresh after Tron staking—wrong CAIP/account scoping could miss tokens or show stale balances, though failures are mostly non-blocking and covered by tests. > > **Overview** > Earn and related confirmation flows stop using **TokensController** / legacy token selectors and register tokens through **AssetsController** unified assets state instead. > > **Lending deposit/withdraw confirmation** now call a shared **`registerLendingOutputToken`** helper (CAIP asset id + checksummed address) with the selected account id after a confirmed tx when the output token isn’t already known—replacing inline `TokensController.addToken` + `networkClientId` lookups. > > **mUSD “max” conversion prep** (`ensureMusdTokenRegistered`, `useEnsureMusdTokenRegistered`) takes **`accountId`** instead of `networkClientId`, skips work when no EVM account is selected, and dedupes via per-account **`customAssets`** on `AssetsController` rather than Redux `allTokens`. > > **Tron stake/unstake success** refreshes balances via **`AssetsController.getAssets`** (forced update, bypass server cache) instead of **`MultichainBalancesController.updateBalance`**. > > **Pay-with modal** for zero-balance withdraw tokens drops the redundant **`TokensController.addTokens`** path and relies only on **`ensurePayToken`**. > > Tests and mocks are updated across these paths; behavior is intended to stay the same for users. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1228c61. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
5 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds user-approved injection of an entry script. For now, that script just throws up a
window.alert.Checklist
Issue
Resolves #???