Skip to content

fix(frontend): ignore stale account grants - #2691

Merged
openai0229 merged 199 commits into
OtterMind:mainfrom
HandSonic:fix/account-grants-latest-request
Sep 3, 2026
Merged

openai0229 merged 199 commits into
OtterMind:mainfrom
HandSonic:fix/account-grants-latest-request

Conversation

@HandSonic

Copy link
Copy Markdown
Contributor

Summary

  • Ignore stale database-account grants requests when switching accounts.
  • Keep the loading state owned by the latest request and invalidate callbacks on unmount.

Validation

  • Account grants race regression scenarios
  • ESLint and Stylelint
  • Community production build

Aias00 and others added 11 commits August 3, 2026 20:13
…#2511)

persistToDisk wrote directly via objectMapper.writeValue(storagePath.toFile(),
data) — Jackson truncates then streams; a crash/disk-full mid-write left the
file empty/corrupt, permanently losing all encrypted API keys. Write to a
temp file then Files.move (atomic rename, with fallback), same pattern as
SmallDataStorage.saveDataList().

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: liuhy <liuhongyu@apache.org>
…erMind#2541)

The unmount cleanup called setCurrentFrame(0), triggering a React state
update on an unmounted component. The reset is unnecessary since the
component is about to disappear. Remove it; keep clearInterval and
isPlaying.current = false.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: liuhy <liuhongyu@apache.org>
…tension-points

# Conflicts:
#	chat2db-community-client/src/edition-ui/types.ts
@HandSonic
HandSonic requested a review from openai0229 as a code owner August 12, 2026 02:14
@openai0229 openai0229 moved this to In Review in Chat2DB Community Aug 12, 2026
@HandSonic
HandSonic force-pushed the fix/account-grants-latest-request branch from 02ec4bd to 5046a13 Compare August 12, 2026 16:48
openai0229 and others added 15 commits August 17, 2026 23:40
…tension-points

# Conflicts:
#	chat2db-community-client/src/blocks/RedisAllData/index.tsx
…tension-points

# Conflicts:
#	chat2db-community-client/package.json
#	chat2db-community-client/scripts/i18n-source-hashes.json
#	chat2db-community-client/src/blocks/AI/index.tsx
#	chat2db-community-client/src/blocks/NewTree/components/TreeDropdown/index.tsx
#	chat2db-community-client/src/blocks/NewTree/hooks/useCreateRightClickMenu.tsx
#	chat2db-community-client/src/blocks/NewTree/menuConfig.tsx
#	chat2db-community-client/src/components/SQLEditor/editor/SQLEditorWithOperation/index.tsx
#	chat2db-community-client/src/components/SelectBoundInfo/index.tsx
#	chat2db-community-client/src/hooks/useStreamChatAI.ts
#	chat2db-community-client/src/service/magicStick.ts
#	chat2db-community-client/src/store/tree/index.tsx
Constraint: Preserve existing PR behavior while refreshing the merge base
Confidence: high
Scope-risk: narrow
openai0229 and others added 22 commits September 2, 2026 15:46
…-column-2571

feat(mysql): invisible column management for MySQL 8.0.23+
…edit-actions

fix(result): stabilize sorting and edit actions
…active-transaction-2595

# Conflicts:
#	chat2db-community-client/package.json
…-theme-accent

fix(workspace): smooth panel resizing and restore theme accents
…ansaction-2595

feat(mysql): active InnoDB transaction inspection (OtterMind#2595)
…-expiration

fix(redis): persist no-expiration TTL updates
# Conflicts:
#	chat2db-community-client/package.json
#	chat2db-community-client/src/pages/main/workspace/components/WorkspaceExtend/GlobalExtendComponents/accountGrantsRequest.test.ts
#	chat2db-community-client/src/pages/main/workspace/components/WorkspaceExtend/GlobalExtendComponents/accountGrantsRequest.ts
openai0229
openai0229 previously approved these changes Sep 3, 2026

@openai0229 openai0229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修复并复测账号 grants loading 中的旧权限错配:新账号请求开始时立即清空旧 grants,同时保留旧响应过滤、最新 loading、失败和卸载保护。专项测试、ESLint/Stylelint、Community production build、后端 package 48/48 及 Playwright 真实账号延迟场景均通过。

@HandSonic
HandSonic dismissed openai0229’s stale review September 3, 2026 12:07

The merge-base changed after approval.

@openai0229
openai0229 merged commit 144a04e into OtterMind:main Sep 3, 2026
29 of 37 checks passed
@openai0229 openai0229 moved this from In Review to Done in Chat2DB Community Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants