Skip to content

Honor OTEL_PROPAGATORS when propagating trace context across Airflow - #70840

Closed
rjgoyln wants to merge 7 commits into
apache:mainfrom
rjgoyln:fix/otel-global-propagators
Closed

rjgoyln wants to merge 7 commits into
apache:mainfrom
rjgoyln:fix/otel-global-propagators

Conversation

@rjgoyln

@rjgoyln rjgoyln commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Airflow instantiated TraceContextTextMapPropagator() directly at every trace-context boundary instead of using the globally configured propagators. As a result, OTEL_PROPAGATORS had no effect inside Airflow: vendor propagators were ignored, Baggage was dropped across component boundaries, and worker-to-API-server propagation could fail when tracecontext was not configured.

This replaces the hardcoded propagators with opentelemetry.propagate, matching the Execution API middleware and allowing Airflow to honor the configured propagation strategy consistently.

Changes

  • Replaced all hardcoded TraceContextTextMapPropagator() usages with propagate.inject and propagate.extract.
  • Stopped filtering run-conf carriers to only traceparent and tracestate, allowing configured propagators to read and write their own fields.
  • Kept the bare-string airflow/dagrun_parent_trace_context shorthand pinned to the W3C propagator. The shorthand's value is defined as a W3C trace-context string, while the mapping form remains propagator-agnostic.
  • Added documentation for OTEL_PROPAGATORS and trace-context propagation.
  • Updated tests to verify baggage round-tripping and backward compatibility.
  • Added newsfragment: airflow-core/newsfragments/70840.improvement.rst.

Compatibility

No behavior changes are expected with the default OTEL_PROPAGATORS=tracecontext,baggage: carriers remain byte-identical unless baggage is present.

Existing W3C carriers continue to extract correctly, and the documented bare-string airflow/dagrun_parent_trace_context shorthand remains supported regardless of the configured propagators.

Scope

Addresses Issue 2 of #70388 only. Issues 1 and 3 remain separate.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Generated-by: Claude Code (Opus 5)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Important

🛠️ Maintainer triage note for @rjgoyln · by @potiuk · 2026-08-13 12:55 UTC

Helpful heads-up from the maintainers — please address before this PR can be reviewed:

  • ❌ Merge conflicts. See docs.

Full list of what we check: Pull Request quality criteria.

The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.

Automated triage — may be imperfect; a maintainer takes the next look.

rjgoyln and others added 3 commits August 13, 2026 22:13
Every boundary that carried trace context instantiated a W3C trace context
propagator directly, so a deployment selecting a vendor propagator had it
ignored everywhere inside Airflow, and Baggage was dropped on each hop --
silently, since nothing reports a propagator that was never consulted.

related: apache#70388
The bare-string form of airflow/dagrun_parent_trace_context is documented as a
W3C traceparent -- its value syntax, not just its key name -- so routing it
through the configured propagators made a documented input silently produce a
root trace on any deployment whose propagator set omits tracecontext.
@rjgoyln
rjgoyln force-pushed the fix/otel-global-propagators branch from 51a8c3d to abc7e28 Compare August 13, 2026 14:40
@rjgoyln
rjgoyln marked this pull request as ready for review August 13, 2026 14:41
@rjgoyln rjgoyln closed this Aug 13, 2026
@rjgoyln rjgoyln reopened this Aug 13, 2026
@potiuk potiuk added the closed because of open PR limit Closed as a one-time step of introducing the open pull request limit label Sep 25, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @rjgoyln - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk area:Triggerer closed because of open PR limit Closed as a one-time step of introducing the open pull request limit kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants