Skip to content

Drop the git provider dependency from airflow-core tests - #72041

Closed
rjgoyln wants to merge 3 commits into
apache:mainfrom
rjgoyln:core-tests-drop-git
Closed

rjgoyln wants to merge 3 commits into
apache:mainfrom
rjgoyln:core-tests-drop-git

Conversation

@rjgoyln

@rjgoyln rjgoyln commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

The fixtures in unit/api_fastapi/conftest.py reached for GitDagBundle only to give Dag versions a view URL, and that import is module level — so with the git provider uninstalled, nothing under unit/api_fastapi collects at all. That is one of the blockers to running the core suite in a scoped uv sync --project airflow-core environment.

Rendering those links needs nothing from a provider but the URL template, so the fixture now supplies one directly. The rendered URLs are byte-identical, which is why no expectation moved.

Nothing under airflow-core/tests references the git provider now; the dev-group entry stays until the other five providers go too.

Tests

unit/api_fastapi in a scoped venv without apache-airflow-providers-git: 3723 passed, 6 failed. The six are in test_plugins.py and test_hitl.py and fail identically with the provider installed.

related: #71641


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Aug 25, 2026
@rjgoyln
rjgoyln marked this pull request as ready for review August 26, 2026 14:14
airflow-core's own test suite could not even be collected without the
git provider installed: the shared API fixtures reached for GitDagBundle
just to give Dag versions a view URL, which core renders from a URL
template that any bundle can supply. Nothing else under
airflow-core/tests needs the provider now, though its dev-group entry
has to stay until the remaining five are unpicked too.

related: apache#71641
@rjgoyln
rjgoyln force-pushed the core-tests-drop-git branch from 1d3428d to a9c5abd Compare August 26, 2026 15:09
@rjgoyln rjgoyln changed the title Stop airflow-core tests from requiring the git provider Drop the git provider dependency from airflow-core tests Sep 1, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @rjgoyln - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants