Repository navigation
Conversation
The lint filters were declared as plain strings, so the membership tests in the command body compared a name against a string rather than against a list. Any name that happened to be a prefix of what the user typed slipped through: `--option auth_backends` also reported `auth_backend`, and the mirror case on `--ignore-option` silently suppressed warnings the user still wanted to see. Five such pairs exist in CONFIGS_CHANGES today. The comma-separated lists the docstring has always advertised only appeared to work because substring matching happened to accept them; the verbose output joined the same strings character by character. airflow-core already parses these four arguments with string_list_type, which was defined here but left unused.
potiuk
added
the
ready for maintainer review
potiuk
added
the
closed because of open PR limit
|
Hello @rjgoyln - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
2 participants
Summary
airflowctl config lintdeclared--section,--option,--ignore-section, and--ignore-optionas plain strings instead of lists. As a result, membership checks performed substring matching rather than exact matching, leading to false positives (for example,auth_backendmatchingauth_backends) and, more seriously, causing--ignore-optionto suppress unrelated warnings.The same root cause also meant that the documented comma-separated syntax (for example,
--section core,webserver) was never actually parsed, and verbose output printed each string character by character.Change
Use the existing
string_list_typeparser fromairflowctl/ctl/cli_config.pyfor all four options, matchingairflow-core. This restores proper list membership, enables the documented comma-separated syntax, and fixes verbose output.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines