Skip to content

Return only the latest Dag version from iter_all_latest_version_dags - #70935

Closed
Eason09053360 wants to merge 2 commits into
apache:mainfrom
Eason09053360:fix-iter-all-latest-version-dags
Closed

Eason09053360 wants to merge 2 commits into
apache:mainfrom
Eason09053360:fix-iter-all-latest-version-dags

Conversation

@Eason09053360

Copy link
Copy Markdown
Contributor

The method promised latest-version dags in its name and docstring but read every serialized_dag row, so FAB permission syncing processed each Dag once per version and could apply an outdated access_control last.

DBDagBag.iter_all_latest_version_dags promises latest-version Dags in both its
name and its docstring, but it read every serialized_dag row without filtering
by version.

Its only production caller is FAB's create_dag_specific_permissions, so DAG-level
permission syncing iterated each Dag once per version. Besides the wasted work, the
query has no ORDER BY, so when versions carry different access_control the one
applied last is undefined and an outdated policy can win.

SerializedDagModel._latest_by_version_select() already supported "all dags" via
dag_ids=None; this exposes that through the public get_latest_serialized_dags()
wrapper, which keeps the existing load_op_links hook in the loop intact. All five
existing callers pass dag_ids= explicitly, so the signature change is backwards
compatible.

The existing test mocked session.scalars, so it could not catch a wrong query.
Added a regression test that writes two real versions to the database.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The method promised latest-version dags in its name and docstring but read
every serialized_dag row, so FAB permission syncing processed each Dag once
per version and could apply an outdated access_control last.
@Eason09053360
Eason09053360 marked this pull request as ready for review August 2, 2026 08:36
@Eason09053360
Eason09053360 force-pushed the fix-iter-all-latest-version-dags branch from 3b3e4a6 to b40af4f Compare August 2, 2026 17:29

@SameerMesiah97 SameerMesiah97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the tests.

Comment thread airflow-core/tests/unit/models/test_dagbag.py
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Aug 13, 2026
@potiuk potiuk added the closed because of open PR limit Closed as a one-time step of introducing the open pull request limit label Sep 25, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @Eason09053360 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 33 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dag-processor closed because of open PR limit Closed as a one-time step of introducing the open pull request limit ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants