Skip to content

Fix tasks clear --task-regex matching as a plain substring - #72941

Closed
Eason09053360 wants to merge 1 commit into
apache:mainfrom
Eason09053360:fix-tasks-clear-task-regex-substring-match
Closed

Eason09053360 wants to merge 1 commit into
apache:mainfrom
Eason09053360:fix-tasks-clear-task-regex-substring-match

Conversation

@Eason09053360

@Eason09053360 Eason09053360 commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Why

airflow tasks clear -t/--task-regex is documented as a regex, but since #47360 dropped regex support from partial_subset, the CLI has passed the pattern through as a plain substring match. A pattern such as '^runme_[02]$' silently clears nothing and exits 0, while --dag-regex on the same command still uses re.search.

What

task_clear now filters task ids with re.search itself and passes the matched set to partial_subset, which stays non-regex for its API and UI callers. An invalid pattern exits with a one-line Invalid --task-regex error instead of a traceback. As in Airflow 2, an unescaped . now matches any character; --dag-regex combined with --task-regex still crashes and is tracked in #66884.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Fable 5.1)

Generated-by: Claude Code (Fable 5.1) following the guidelines

The flag, its help text and the docs all promise a regular expression,
but since apache#47360 removed regex support from partial_subset (to stop the
REST API root parameter from being parsed as a regex) the CLI passed the
pattern straight through and it was matched as a literal substring. Any
pattern with metacharacters silently matched nothing and cleared nothing.

Resolve the regex in the CLI, the only caller that promises one, and
hand partial_subset a concrete set of task ids so the shared method
keeps its non-regex contract. An invalid pattern now exits with a
one-line error instead of a traceback.
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @Eason09053360 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 33 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants