Repository navigation
Fix dateless dag.test and tasks test destroying unrelated Dag runs - #72656
Eason09053360 wants to merge 1 commit into
Conversation
Airflow 3 allows Dag runs without a logical date, which the helper behind these two debugging commands never accounted for. An absent date widened both its collision lookup and its pre-test clear into match-everything queries, so testing a single task could delete a run the user had triggered from the UI, along with its task instances and their history. A command whose whole purpose is local debugging must not touch data it was never pointed at.
05b3ab5 to
0e21134
Compare
|
Hello @Eason09053360 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 33 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why
airflow tasks testandDAG.test()can delete a Dag run the user triggered from theUI, along with its task instances.
Airflow 3 lets runs have no logical date — manual and asset-triggered runs store
NULL— but the helper behind both entry points still treats an absent date as"match anything":
get_or_create_dagrundeletes the run occupying the logical date it is about to use.The lookup uses
==, which SQLAlchemy renders asIS NULL, so a dateless test deletesan arbitrary dateless run — and
DagRun.task_instancescascades.DAG.test()first clears task instances viaclear_dags, passing the logical date asboth bounds.
Nonedrops both, leavingTaskInstance.dag_id == <dag_id>— every runof the Dag.
NULL dates cannot collide under the
(dag_id, logical_date)unique key, so bothoperations are skipped when the date is absent.
What
Both call sites guarded, one regression test each.
session.commit()becamesession.flush(): the line moves in this diff anyway, andairflow-coreforbids a callee committing a session it was handed.Repeated dateless
dag.test()calls now accumulate runs instead of each deleting thelast.
--logical-date <D>still replaces a real run sitting atD.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines