emrg: docs — README 补充 p12 双证书本地验证命令 + CI 早检行为说明(#467 对称) - #468
Merged
Conversation
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-1415
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-1418
独立复核:
- 与 CI 逻辑一致性:文档验证命令(find-certificate -c + 输出判空)与 build-release.yml Import step(#464/#467,第 94-96 行)完全一致 — 双证书 + 私钥三者齐备语义对齐
- 正反两态验证:本机实测 find-certificate 无匹配证书时 exit code 恒为 0(App=0 / Installer=0),印证"必须输出判空而非退出码"(#455 教训)— 文档写的
非空 ✅语义正确 - 内容准确:"只有 Installer → .app 跳过签名 → 公证失败"(#467 对称缺口)、"CI 早检不等到 Sign pkg/公证"(#464/#467)均与 workflow 实际行为一致
- 纯文档改动(+6/-1),无 workflow 逻辑变更,pytest 473 passed 基线不受影响
argszero
commented
Aug 6, 2026
This was referenced Aug 6, 2026
argszero
added a commit
that referenced
this pull request
Aug 11, 2026
…etry) (#690) #688 made icon products (png/icns/ico) gitignored — CI generates them at build time, but local installer builds (make-installer.sh / build-runtime.sh) would fail with missing assets unless the host runs the generator first. - DEVELOPMENT.md: new 'Packaging (installer builds)' section under Development Workflow — run `bash packaging/gen-assets.sh` first (idempotent; renderer priority rsvg-convert → Chrome headless → sips; .icns needs macOS iconutil, skipped elsewhere) - Agent.md: 'Packaging' section under Test Commands with the same note - mirrors the #467/#468 host-symmetry principle: CI validation + documented host-side self-check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景:#467 后 CI Import step 会对称校验双证书(Application + Installer)+ 私钥。但宿主操作文档
.github/workflows/README.md的验证章节只教验证私钥,未教验证双证书——宿主导出 p12 后本地验证会漏掉'缺 Application/缺 Installer'场景,更新 Secret 后才在 CI 暴露 → 一轮构建浪费(v0.2.7 已 9 次失败,教训深刻)。改动:
security find-certificate -c "Developer ID Application/Installer" -a),与 CI emrg: p12 双证书对称校验 — Application + Installer 缺一不可(防止只导 Installer 导致 .app 未签名) #467 检查完全一致(输出判空语义)验证: