Skip to content

emrg: docs — README 补充 p12 双证书本地验证命令 + CI 早检行为说明(#467 对称) - #468

Merged
argszero merged 1 commit into
masterfrom
docs/p12-dual-cert-verify
Aug 6, 2026
Merged

emrg: docs — README 补充 p12 双证书本地验证命令 + CI 早检行为说明(#467 对称)#468
argszero merged 1 commit into
masterfrom
docs/p12-dual-cert-verify

Conversation

@argszero

@argszero argszero commented Aug 6, 2026

Copy link
Copy Markdown
Owner

背景#467 后 CI Import step 会对称校验双证书(Application + Installer)+ 私钥。但宿主操作文档 .github/workflows/README.md 的验证章节只教验证私钥,未教验证双证书——宿主导出 p12 后本地验证会漏掉'缺 Application/缺 Installer'场景,更新 Secret 后才在 CI 暴露 → 一轮构建浪费(v0.2.7 已 9 次失败,教训深刻)。

改动

  1. 验证章节:补充双证书检查命令(security find-certificate -c "Developer ID Application/Installer" -a),与 CI emrg: p12 双证书对称校验 — Application + Installer 缺一不可(防止只导 Installer 导致 .app 未签名) #467 检查完全一致(输出判空语义)
  2. 双证书章节:补充'只有 Installer 证书'的失败模式(emrg: p12 双证书对称校验 — Application + Installer 缺一不可(防止只导 Installer 导致 .app 未签名) #467 对称缺口)+ 说明 CI 现在会在 Import step 早检(emrg: pkg 签名补 Import step 早检 — find-certificate 校验 Developer ID Installer 证书(输出判空) #464/emrg: p12 双证书对称校验 — Application + Installer 缺一不可(防止只导 Installer 导致 .app 未签名) #467),不再等到 Sign pkg/公证才报错

验证

  • 文档命令正反两态实测(本机:Application 非空 / Installer 空)✅
  • pytest 473 passed ✅ / import ✅
  • 纯文档改动,无 workflow 逻辑变更

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-1415

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-1418

独立复核:

  1. 与 CI 逻辑一致性:文档验证命令(find-certificate -c + 输出判空)与 build-release.yml Import step(#464/#467,第 94-96 行)完全一致 — 双证书 + 私钥三者齐备语义对齐
  2. 正反两态验证:本机实测 find-certificate 无匹配证书时 exit code 恒为 0(App=0 / Installer=0),印证"必须输出判空而非退出码"(#455 教训)— 文档写的 非空 ✅ 语义正确
  3. 内容准确:"只有 Installer → .app 跳过签名 → 公证失败"(#467 对称缺口)、"CI 早检不等到 Sign pkg/公证"(#464/#467)均与 workflow 实际行为一致
  4. 纯文档改动(+6/-1),无 workflow 逻辑变更,pytest 473 passed 基线不受影响

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-1421(本实例)。独立复核:① 文档验证命令与 CI #467 检查完全一致(find-certificate -c + 输出判空语义)——本机正反两态实测:Application 非空 ✅、Installer 空 ✅;② 补全'只有 Installer 证书'失败模式(#467 对称缺口)+ CI 早检行为说明,宿主本地验证可提前发现缺证书避免构建浪费;③ 纯文档改动无 workflow 逻辑变更。第 3 个连续 ✅,可合并。

@argszero
argszero merged commit 8a5ff99 into master Aug 6, 2026
1 check passed
@argszero
argszero deleted the docs/p12-dual-cert-verify branch August 6, 2026 06:24
argszero added a commit that referenced this pull request Aug 11, 2026
…etry) (#690)

#688 made icon products (png/icns/ico) gitignored — CI generates them at
build time, but local installer builds (make-installer.sh / build-runtime.sh)
would fail with missing assets unless the host runs the generator first.

- DEVELOPMENT.md: new 'Packaging (installer builds)' section under
  Development Workflow — run `bash packaging/gen-assets.sh` first
  (idempotent; renderer priority rsvg-convert → Chrome headless → sips;
  .icns needs macOS iconutil, skipped elsewhere)
- Agent.md: 'Packaging' section under Test Commands with the same note
- mirrors the #467/#468 host-symmetry principle: CI validation + documented
  host-side self-check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant